- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove useless object in "DeactivateStorageDomainWithO...
by juan.hernandez＠redhat.com 30 Sep '15

30 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Remove useless object in "DeactivateStorageDomainWithOvfUpdateCommand" ...................................................................... core: Remove useless object in "DeactivateStorageDomainWithOvfUpdateCommand" This is needed in order to avoid the following findbugs warning: Useless object created Our analysis shows that this object is useless. It's created and modified, but its value never go outside of the method or produce any side-effect. Either there is a mistake and object was intended to be This analysis rarely produces false-positives. Common false-positive cases include: - This object used to implicitly throw some obscure exception. - This object used as a stub to generalize the code. - This object used to hold strong references to weak/soft-referenced objects. Bug kind and pattern: UC - UC_USELESS_OBJECT Change-Id: I0c8407fdeb14d00771d2b4f7c8781bd6a98306e8 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainWithOvfUpdateCommand.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46581 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c8407fdeb14d00771d2b4f7c8781bd6a98306e8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Remove useless object in "AddExistingFileStorageDomain...
by juan.hernandez＠redhat.com 30 Sep '15

30 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Remove useless object in "AddExistingFileStorageDomainCommand" ...................................................................... core: Remove useless object in "AddExistingFileStorageDomainCommand" This is needed in order to avoid the following findbugs warning: Useless object created Our analysis shows that this object is useless. It's created and modified, but its value never go outside of the method or produce any side-effect. Either there is a mistake and object was intended to be used or it can be removed. This analysis rarely produces false-positives. Common false-positive cases include: - This object used to implicitly throw some obscure exception. - This object used as a stub to generalize the code. - This object used to hold strong references to weak/soft-referenced objects. Bug kind and pattern: UC - UC_USELESS_OBJECT Change-Id: I9ae42a7ac1e00d91706d07e612cc08f873c2a6a5 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46580 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ae42a7ac1e00d91706d07e612cc08f873c2a6a5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[master]: packaging: use ovirt-live-artworks
by sbonazzo＠redhat.com 30 Sep '15

30 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: use ovirt-live-artworks ...................................................................... packaging: use ovirt-live-artworks Change-Id: I3a4dc45958cde092257f2d61a722d6f42f08784c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in M centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/engine-setup-yad.sh D centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/images/ovirt-icon-128.png D centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/images/ovirt-setup.png D centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/images/ovirt-usb-stick.png D centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/images/ovirt-usb-stick.svg D centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/images/ovirt-wallpaper-16:10.jpg D centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/images/ovirt-wallpaper-16:9.jpg D centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/images/ovirt-wallpaper-4:3.jpg 9 files changed, 4 insertions(+), 29 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a4dc45958cde092257f2d61a722d6f42f08784c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[master]: artwork: re-package for el7 compatibility
by sbonazzo＠redhat.com 30 Sep '15

30 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: artwork: re-package for el7 compatibility ...................................................................... artwork: re-package for el7 compatibility Change-Id: If7fd8c86a1afc17b391e8486cd79af76ace33196 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-live-artwork/configure.ac M ovirt-live-artwork/ovirt-live-artwork.spec.in D ovirt-live-artwork/wallpapers/1600x1200.jpg D ovirt-live-artwork/wallpapers/2133x1200.jpg M ovirt-live-artwork/wallpapers/Makefile.am A ovirt-live-artwork/wallpapers/gnome/Makefile.am A ovirt-live-artwork/wallpapers/gnome/oVirtLive.xml A ovirt-live-artwork/wallpapers/mate/Makefile.am A ovirt-live-artwork/wallpapers/mate/oVirtLive.xml A ovirt-live-artwork/wallpapers/normalish/Makefile.am A ovirt-live-artwork/wallpapers/normalish/oVirtLive.jpg A ovirt-live-artwork/wallpapers/oVirtLive.xml A ovirt-live-artwork/wallpapers/standard/Makefile.am A ovirt-live-artwork/wallpapers/standard/oVirtLive.jpg A ovirt-live-artwork/wallpapers/tv-wide/Makefile.am A ovirt-live-artwork/wallpapers/tv-wide/oVirtLive.jpg A ovirt-live-artwork/wallpapers/wide/Makefile.am R ovirt-live-artwork/wallpapers/wide/oVirtLive.jpg 18 files changed, 237 insertions(+), 15 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46863 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7fd8c86a1afc17b391e8486cd79af76ace33196 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Fix JAXB annotations of scheduling policy unit
by juan.hernandez＠redhat.com 30 Sep '15

30 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix JAXB annotations of scheduling policy unit ...................................................................... restapi: Fix JAXB annotations of scheduling policy unit This complex type uses a JAXB annotation to assign to the Java getter of the "properties" element the "getPropertiesMetaData" name. This isn't consistent with the rest of the API, where the name of the getter uses the plural of the name of the element, in this case "getProperties". This patch fixes that. Change-Id: I9d8b0520c7abff47e3e9dd5fc8bbb70c190ffd39 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PolicyUnitMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/PolicyUnitMapperTest.java 3 files changed, 8 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46859 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d8b0520c7abff47e3e9dd5fc8bbb70c190ffd39 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: The default display type conforms the architecture
by piotr.kliczewski＠gmail.com 30 Sep '15

30 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: The default display type conforms the architecture ...................................................................... core: The default display type conforms the architecture REST Add VM request: If display type is not specified in request and template's display is not supported on the architecture (like SPICE vs. PPC), then first supported is taken (osinfo-defaults.properties) Change-Id: Idaa30b05447c426b8740c68306d8ecf2ac8e2ef9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1253263 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 2 files changed, 50 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/46850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idaa30b05447c426b8740c68306d8ecf2ac8e2ef9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Add JAXB annotation to gluster profile elements
by juan.hernandez＠redhat.com 30 Sep '15

30 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add JAXB annotation to gluster profile elements ...................................................................... restapi: Add JAXB annotation to gluster profile elements This annotation is used to make sure that the name of the corresponding Java getter names are plural, is what is used in the rest of the API. Change-Id: Ia54f68c52f0bc3ead7088c5957357335ed917c38 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GlusterVolumeProfileInfoMapper.java 2 files changed, 16 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46857 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia54f68c52f0bc3ead7088c5957357335ed917c38 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use multiple "vcpu_pins.vcpu_pin" instead of multip...
by juan.hernandez＠redhat.com 30 Sep '15

30 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use multiple "vcpu_pins.vcpu_pin" instead of multiple "vcpu_pin" ...................................................................... restapi: Use multiple "vcpu_pins.vcpu_pin" instead of multiple "vcpu_pin" Currently the way to specify the virtual to physical CPU pinning of a virtual machie is to use multiple "vcpu_pin" elements: <vm> <cpu> <cpu_tune> <vcpu_pin>...</vcpu_pin> <vcpu_pin>...</vcpu_pin> ... </cpu_tune> </cpu> </vm> In order to conform to the common practice in other parts of the API this has been changed to use a wrapper element, in this case "vcpu_pins": <vm> <cpu> <cpu_tune> <vcpu_pins> <vcpu_pin>...</vcpu_pin> <vcpu_pin>...</vcpu_pin> ... </vcpu_pins> </cpu_tune> </cpu> </vm> Change-Id: Ia87c261c4c3ba0a668b04a2b7cf80ddd2131de01 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 5 files changed, 85 insertions(+), 20 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia87c261c4c3ba0a668b04a2b7cf80ddd2131de01 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Renamed the statistics "type" property to "kind"
by juan.hernandez＠redhat.com 30 Sep '15

30 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Renamed the statistics "type" property to "kind" ...................................................................... restapi: Renamed the statistics "type" property to "kind" The statistics used to be represented using a "type" element that indicates the kind of statistic (gauge, counter, etc) and also a "type" attribute that indicates the type of the values (integer, string, etc): <statistic> <type>GAUGE</type> <values type="INTEGER"> <value>...</value> <value>...</value> ... </values> </statistic> To avoid the use of the "type" concept for both things the first has been replaced by "kind", and both `kind` and `type` are now elements: <statistic> <kind>GAUGE</kind> <type>INTEGER</type> <values> <value>...</value> <value>...</value> ... </values> </statistic> Change-Id: I1139776b25babdb550d553d0ab90f364ca6179aa Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractStatisticalQuery.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStatisticsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GlusterVolumeProfileInfoMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/StatisticResourceUtils.java 6 files changed, 48 insertions(+), 20 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46854 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1139776b25babdb550d553d0ab90f364ca6179aa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: ovirt-engine-extension-aaa-ldap: split 3.6 from master
by sbonazzo＠redhat.com 30 Sep '15

30 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine-extension-aaa-ldap: split 3.6 from master ...................................................................... ovirt-engine-extension-aaa-ldap: split 3.6 from master since engine is not built anymore on master, for 3.6 we need different yum repos. Change-Id: I20936462b71a6552393c43fedcc6df3f265c996c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-extension-aaa-ldap/ovirt-engine-extension-aaa-ldap_create-rpms.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml 2 files changed, 8 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46851 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20936462b71a6552393c43fedcc6df3f265c996c Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0