- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove useless map in "VmManagementCommandBase"
by juan.hernandez＠redhat.com 01 Oct '15

01 Oct '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Remove useless map in "VmManagementCommandBase" ...................................................................... core: Remove useless map in "VmManagementCommandBase" This is needed in order to avoid the following findbugs warning: Useless object created Our analysis shows that this object is useless. It's created and modified, but its value never go outside of the method or produce any side-effect. Either there is a mistake and object was intended to be used or it can be removed. This analysis rarely produces false-positives. Common false-positive cases include: - This object used to implicitly throw some obscure exception. - This object used as a stub to generalize the code. - This object used to hold strong references to weak/soft-referenced objects. Bug kind and pattern: UC - UC_USELESS_OBJECT Change-Id: I6e773e3a1ae8d901d9d6e3e9a09c3942447c923f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java 1 file changed, 18 insertions(+), 35 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46578 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e773e3a1ae8d901d9d6e3e9a09c3942447c923f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Don't use Infinispan subsystem "start" attribute
by mperina＠redhat.com 01 Oct '15

01 Oct '15

Martin Peřina has submitted this change and it was merged. Change subject: core: Don't use Infinispan subsystem "start" attribute ...................................................................... core: Don't use Infinispan subsystem "start" attribute The "start" attribute of the "cache-manager" element of the Infinispan sybsystem of the application server was removed in version 9 of WildFly. Instead of relying on that to ensure that the cache is started before the backend it is better to explicitly require it using the EJB deployment descriptor "ejb-jar.xml". Change-Id: I84f2fe41a5d4e72be7a696680742599b109fad8f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A backend/manager/modules/bll/src/main/resources/META-INF/ejb-jar.xml M packaging/services/ovirt-engine/ovirt-engine.xml.in 2 files changed, 44 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84f2fe41a5d4e72be7a696680742599b109fad8f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[master]: post ovirt-live-artwork-1.0.0
by sbonazzo＠redhat.com 01 Oct '15

01 Oct '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: post ovirt-live-artwork-1.0.0 ...................................................................... post ovirt-live-artwork-1.0.0 Change-Id: I1f667b77feb8f1bacfdeaad41bcbea5e606d7862 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-live-artwork/configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f667b77feb8f1bacfdeaad41bcbea5e606d7862 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in otopi[master]: build: update po
by Alon Bar-Lev 01 Oct '15

01 Oct '15

Alon Bar-Lev has submitted this change and it was merged. Change subject: build: update po ...................................................................... build: update po Change-Id: I2775c96ec114504ba1665627dd8ff9ea5f7a0c9e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M po/POTFILES.in 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46882 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2775c96ec114504ba1665627dd8ff9ea5f7a0c9e Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in otopi[master]: java: fix java-8 warnings
by Alon Bar-Lev 01 Oct '15

01 Oct '15

Alon Bar-Lev has submitted this change and it was merged. Change subject: java: fix java-8 warnings ...................................................................... java: fix java-8 warnings Change-Id: Ied2650ac2b7889faa3272d3c5e4d3cd625dd10c1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/java/MachineDialogParser.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied2650ac2b7889faa3272d3c5e4d3cd625dd10c1 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.6]: packaging: use ovirt-live-artworks
by sbonazzo＠redhat.com 30 Sep '15

30 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: use ovirt-live-artworks ...................................................................... packaging: use ovirt-live-artworks Change-Id: I3a4dc45958cde092257f2d61a722d6f42f08784c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in M centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/engine-setup-yad.sh D centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/images/ovirt-icon-128.png D centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/images/ovirt-setup.png D centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/images/ovirt-usb-stick.png D centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/images/ovirt-usb-stick.svg D centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/images/ovirt-wallpaper-16:10.jpg D centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/images/ovirt-wallpaper-16:9.jpg D centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/images/ovirt-wallpaper-4:3.jpg 9 files changed, 4 insertions(+), 29 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46878 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a4dc45958cde092257f2d61a722d6f42f08784c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.6]: artwork: re-package for el7 compatibility
by sbonazzo＠redhat.com 30 Sep '15

30 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: artwork: re-package for el7 compatibility ...................................................................... artwork: re-package for el7 compatibility Change-Id: If7fd8c86a1afc17b391e8486cd79af76ace33196 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit adbd9771a9e32e1b5184fba58f6d58f934a0538c) --- M ovirt-live-artwork/configure.ac M ovirt-live-artwork/ovirt-live-artwork.spec.in D ovirt-live-artwork/wallpapers/1600x1200.jpg D ovirt-live-artwork/wallpapers/2133x1200.jpg M ovirt-live-artwork/wallpapers/Makefile.am A ovirt-live-artwork/wallpapers/gnome/Makefile.am A ovirt-live-artwork/wallpapers/gnome/oVirtLive.xml A ovirt-live-artwork/wallpapers/mate/Makefile.am A ovirt-live-artwork/wallpapers/mate/oVirtLive.xml A ovirt-live-artwork/wallpapers/normalish/Makefile.am A ovirt-live-artwork/wallpapers/normalish/oVirtLive.jpg A ovirt-live-artwork/wallpapers/oVirtLive.xml A ovirt-live-artwork/wallpapers/standard/Makefile.am A ovirt-live-artwork/wallpapers/standard/oVirtLive.jpg A ovirt-live-artwork/wallpapers/tv-wide/Makefile.am A ovirt-live-artwork/wallpapers/tv-wide/oVirtLive.jpg A ovirt-live-artwork/wallpapers/wide/Makefile.am R ovirt-live-artwork/wallpapers/wide/oVirtLive.jpg 18 files changed, 237 insertions(+), 15 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7fd8c86a1afc17b391e8486cd79af76ace33196 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: set Firefox 38 as the supported browser.
by gshereme＠redhat.com 30 Sep '15

30 Sep '15

Greg Sheremeta has submitted this change and it was merged. Change subject: webadmin: set Firefox 38 as the supported browser. ...................................................................... webadmin: set Firefox 38 as the supported browser. Change-Id: Ifea9d5b055a7a012672725cd6134ece85afe4fe5 Bug-Url: https://bugzilla.redhat.com/1223194 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/InternalConfiguration.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Einav Cohen: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/46825 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifea9d5b055a7a012672725cd6134ece85afe4fe5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Move "in_sync" from reported configs to network att...
by juan.hernandez＠redhat.com 30 Sep '15

30 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Move "in_sync" from reported configs to network attachment ...................................................................... restapi: Move "in_sync" from reported configs to network attachment This is needed because lists can't have properties, only elements. Change-Id: Ied9589ea7c4b77cb0ac4f8dec9052e55bf033a59 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkAttachmentMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ReportedConfigurationsMapper.java 3 files changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied9589ea7c4b77cb0ac4f8dec9052e55bf033a59 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use wrapper elements for gluster statistics
by juan.hernandez＠redhat.com 30 Sep '15

30 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use wrapper elements for gluster statistics ...................................................................... restapi: Use wrapper elements for gluster statistics The gluster block and fop statistics are currently represented using repeated elements. This is contrary to the common practice in the rest of the API, as they should be wrapped with an element representing the collection. This patch fixes that. Change-Id: Icccfe581a0cfe64436bec213bcc41b2b5a514c19 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GlusterVolumeProfileInfoMapper.java 2 files changed, 67 insertions(+), 18 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46861 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icccfe581a0cfe64436bec213bcc41b2b5a514c19 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0