- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Removed the "force" parameter from request to get host
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Removed the "force" parameter from request to get host ...................................................................... restapi: Removed the "force" parameter from request to get host The request to retrieve a host used to support a "force" matrix parameter to indicate that the data of the host should be refreshed (calling VDSM to reload host capabilities and devices) before retrieving it from the database: GET /hosts/{host:id};force This "force" parameter has been superseded by the host "refresh" action, but kept for backwards compatibility. It has been completely removed now. Applications that require this functionality should perform two requests, first one to refresh the host: POST /hosts/{host:id}/refresh <action/> And then one to retrieve it, without the "force" parameter: GET /hosts/{host:id} Change-Id: Ia888d20d9db8297372e500dfcfba46aacdb67895 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java 4 files changed, 24 insertions(+), 50 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46512 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia888d20d9db8297372e500dfcfba46aacdb67895 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Rename complex type "API" to "Api"
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Rename complex type "API" to "Api" ...................................................................... restapi: Rename complex type "API" to "Api" This is required to make sure that there is only one rule for the names of complex types: all words, including acronyms, start with one upper case character and all the rest are lower case. Change-Id: I9b71ea6f10ff730992c56f59d90ecbed7adea9f5 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/pdf/FOPMessageBodyWriter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/xml/JAXBProvider.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java 7 files changed, 39 insertions(+), 27 deletions(-) Approvals: Ori Liel: Looks good to me, approved Juan Hernandez: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b71ea6f10ff730992c56f59d90ecbed7adea9f5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Avoid findbugs warning about comparing doubles
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: webadmin: Avoid findbugs warning about comparing doubles ...................................................................... webadmin: Avoid findbugs warning about comparing doubles This is needed to avoid the following findbugs 3.x complain: compareTo()/compare() incorrectly handles float or double value This method compares double or float values using pattern like this: val1 > val2 ? 1 : val1 < val2 ? -1 : 0. This pattern works incorrectly for -0.0 and NaN values which may result in incorrect sorting result or broken collection (if compared values are used as keys). Consider using Double.compare or Float.compare static methods which handle all the special cases correctly. Bug kind and pattern: Co - CO_COMPARETO_INCORRECT_FLOATING Change-Id: I415528d3895fbc56a3e3a4f6620f64d1d6dcc9dc Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I415528d3895fbc56a3e3a4f6620f64d1d6dcc9dc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Add custom findbugs plugin
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Add custom findbugs plugin ...................................................................... core: Add custom findbugs plugin The version of the findbugs plugin that we currently use (version 2.5.2) doesn't work correctly with Java 8, and new versions of the plugin don't support multiple filters files, which we use everywhere. To avoid this issue this patch introduces a custom Maven plugin that merges the multiple filters file into one during runtime, and then executes the findbugs plugin passing only one file. This way we can migrate to the new version of find bugs and then to Java 8. This patch also includes a "findbugs.sh" script that contains the command required to run the custom plugin. Change-Id: If136b2bbaeb0d53017ee8322c76772a226045f55 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A build-tools-root/ovirt-findbugs-maven-plugin/pom.xml A build-tools-root/ovirt-findbugs-maven-plugin/src/main/java/org/ovirt/engine/findbugs/FindbugsMojo.java M build-tools-root/pom.xml A findbugs.sh M ovirt-engine.spec.in 5 files changed, 508 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46402 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If136b2bbaeb0d53017ee8322c76772a226045f55 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Use "parseInt" in "setSessionTimeout"
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: webadmin: Use "parseInt" in "setSessionTimeout" ...................................................................... webadmin: Use "parseInt" in "setSessionTimeout" This is necessary to avoid the following findbugs warning: Boxing/unboxing to parse a primitive A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING Change-Id: Iadd0260cccaa5d52e51266071e1fa7dc2d58edcf Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/restapi/RestApiSessionManager.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Passed CI tests Alexander Wels: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46561 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadd0260cccaa5d52e51266071e1fa7dc2d58edcf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: sharedconf: moving initial broker.conf to engine_ha_statedir
by msivak＠redhat.com 23 Sep '15

23 Sep '15

Martin Sivák has submitted this change and it was merged. Change subject: sharedconf: moving initial broker.conf to engine_ha_statedir ...................................................................... sharedconf: moving initial broker.conf to engine_ha_statedir On oVirt 3.6 the notification system config is on the shared storage. A local copy is keep under engine_ha_statedir to being able to notify failures also if the storage is not available. It periodically got refreshed. Moving there also the initial broker.conf from the rpm. Change-Id: I7a1efcbf346be3ce403175bbe450ff8f0e8b2993 Bug-Url: https://bugzilla.redhat.com/1260757 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit b8dc281871756edbc1622c3640400655d01caff6) --- M ovirt-hosted-engine-ha.spec.in M ovirt_hosted_engine_ha/broker/Makefile.am 2 files changed, 9 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46601 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a1efcbf346be3ce403175bbe450ff8f0e8b2993 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Check the result of "listFiles" in "ReflectionHelper"
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Check the result of "listFiles" in "ReflectionHelper" ...................................................................... restapi: Check the result of "listFiles" in "ReflectionHelper" This is needed in order to avoid the following findbugs warning: Possible null pointer dereference due to return value of called method The return value from a method is dereferenced without a null check, and the return value of that method is one that should generally be checked for null. This may lead to a NullPointerException when the code is executed. Bug kind and pattern: NP - NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE Change-Id: Ie0009295db6a5c3e3a6f5ec538f3bc5673c513e6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ReflectionHelper.java 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46593 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0009295db6a5c3e3a6f5ec538f3bc5673c513e6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Remove useless object in "PackageExplorer"
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Remove useless object in "PackageExplorer" ...................................................................... restapi: Remove useless object in "PackageExplorer" This is needed in order to avoid the following findbugs warning: Useless object created Our analysis shows that this object is useless. It's created and modified, but its value never go outside of the method or produce any side-effect. Either there is a mistake and object was intended to be used or it can be removed. This analysis rarely produces false-positives. Common false-positive cases include: - This object used to implicitly throw some obscure exception. - This object used as a stub to generalize the code. - This object used to hold strong references to weak/soft-referenced objects. Bug kind and pattern: UC - UC_USELESS_OBJECT Change-Id: I0351a5f951e94eb7582ebd1a10d8c7ca2b887f19 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/PackageExplorer.java 1 file changed, 0 insertions(+), 11 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46592 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0351a5f951e94eb7582ebd1a10d8c7ca2b887f19 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Check result of "listFiles" in "PackageExplore"
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Check result of "listFiles" in "PackageExplore" ...................................................................... restapi: Check result of "listFiles" in "PackageExplore" This is needed in order to avoid the following findbugs warning: Possible null pointer dereference due to return value of called method The return value from a method is dereferenced without a null check, and the return value of that method is one that should generally be checked for null. This may lead to a NullPointerException when the code is executed. Bug kind and pattern: NP - NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE Change-Id: I0c8f25ce6e248dd32ccbc52e510f79cab809e90d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/PackageExplorer.java 1 file changed, 14 insertions(+), 10 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46591 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c8f25ce6e248dd32ccbc52e510f79cab809e90d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Add missed features
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add missed features ...................................................................... restapi: Add missed features This is needed in order to avoid the following findbugs warning, and it is a real bug as well: Useless non-empty void method Our analysis shows that this non-empty void method does not actually perform any useful work. Please check it: probably there's a mistake in its code or its body can be fully removed. We are trying to reduce the false positives as much as possible, but in some cases this warning might be wrong. Common false-positive cases include: - The method is intended to trigger loading of some class which may have a side effect. - The method is intended to implicitly throw some obscure exception. Bug kind and pattern: UC - UC_USELESS_VOID_METHOD Change-Id: I28386f1cbee0298ec1142d5c63b6d732de67937a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46590 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28386f1cbee0298ec1142d5c63b6d732de67937a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0