- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: SearchableListModel events
by awels＠redhat.com 22 Sep '15

22 Sep '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: SearchableListModel events ...................................................................... webadmin: SearchableListModel events - SearchableListModel events were not being passed to its associated 'EntityModel' which caused Tags to not get the proper events. This patch fixes that issue. Change-Id: Ifd1b4e9e7752e535bb4760adb72bba462639f54f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1205697 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/common/SelectionTreeNodeModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java 3 files changed, 5 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46309 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd1b4e9e7752e535bb4760adb72bba462639f54f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use element instead of attribute for operating syst...
by juan.hernandez＠redhat.com 22 Sep '15

22 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use element instead of attribute for operating system "type" ...................................................................... restapi: Use element instead of attribute for operating system "type" Currently tye operating system "type" property is represented as an attribute: <os type="other"> ... </os> This is contrary to the common practice in the RESTAPI. This patch replaces it with an inner attribute: <os> <type>other</type> ... </os> Change-Id: Ida446b324e020e1fd7f6a4394d9c78af249c1c56 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd 2 files changed, 17 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46064 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida446b324e020e1fd7f6a4394d9c78af249c1c56 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use elements instead of attributes in boot device
by juan.hernandez＠redhat.com 22 Sep '15

22 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use elements instead of attributes in boot device ...................................................................... restapi: Use elements instead of attributes in boot device Currently boot device element uses attributes for its properties: <boot dev="cdrom"/> This is contrary to the common practice in the RESTAPI. This patch replaces them with inner elements: <boot> <dev>cdrom</dev> </boot> Change-Id: Ica3439f3f9b97e9c953e87175eb4c4fb8a2c995c Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd 2 files changed, 16 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica3439f3f9b97e9c953e87175eb4c4fb8a2c995c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use elements instead of attributes in MAC address
by juan.hernandez＠redhat.com 22 Sep '15

22 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use elements instead of attributes in MAC address ...................................................................... restapi: Use elements instead of attributes in MAC address Currently the MAC address element uses attributes for its properties: <mac address="66:f2:c5:5f:bb:8d"/> This is contrary to the common practice in the RESTAPI. This patch replaces them with inner elements: <mac> <address>66:f2:c5:5f:bb:8d</address> </mac> Change-Id: If5388584913153906257cb5472756e45f5a206dc Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd 2 files changed, 16 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5388584913153906257cb5472756e45f5a206dc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use elements instead of attributes in IP address
by juan.hernandez＠redhat.com 22 Sep '15

22 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use elements instead of attributes in IP address ...................................................................... restapi: Use elements instead of attributes in IP address Currently the IP address element uses attributes for its properties: <ip address="192.168.122.1" netmask="255.255.255.0"/> This is contrary to the common practice in the RESTAPI. This patch replaces them with inner elements: <ip> <address>192.168.122.1</address> <netmask>255.255.255.0</netmask> </ip> Change-Id: I65e092d062b90b2fd7d90eb7ff988ffe83089773 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd 2 files changed, 20 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46060 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65e092d062b90b2fd7d90eb7ff988ffe83089773 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use elements in power management agent options
by juan.hernandez＠redhat.com 22 Sep '15

22 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use elements in power management agent options ...................................................................... restapi: Use elements in power management agent options Currently the power management agent options element uses attributes for its properties: <options> <option name="port" value="22"/> <option name="slot" value="5"/> ... </options> This is contrary to the common practice in the RESTAPI. This patch replaces them with inner elements: <options> <option> <name>port</name> <value>22</value> </option> <option> <name>slot</name> <value>5</value> </option> ... </options> Change-Id: I28e214b59be911a7abaf12bfd30f30ef8f799279 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd 2 files changed, 31 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28e214b59be911a7abaf12bfd30f30ef8f799279 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use element for power management agent "type"
by juan.hernandez＠redhat.com 22 Sep '15

22 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use element for power management agent "type" ...................................................................... restapi: Use element for power management agent "type" Currently the power management "type" property is represented as an attribute: <agent type="apc"> <username>myuser</username> ... </agent> This is contrary to the common practice in the RESTAPI. This patch replaces it with an inner attribute: <agent> <type>apc</type> <username>myuser</username> ... </agent> Change-Id: I29c278856a55afde4f0d769c40426d9ed5daff1f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd 2 files changed, 19 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29c278856a55afde4f0d769c40426d9ed5daff1f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use elements instead of attributes in VIRTIO SCSI
by juan.hernandez＠redhat.com 22 Sep '15

22 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use elements instead of attributes in VIRTIO SCSI ...................................................................... restapi: Use elements instead of attributes in VIRTIO SCSI Currently the VIRTIO ISCSI element uses attributes for its properties: <virtio_scsi enabled="true"/> This is contrary to the common practice in the RESTAPI. This patch replaces them with inner elements: <virtio_scsi> <enabled>true</enabled> </virtio_scsi> Change-Id: Ia72fdeab1670a285d76d6df24c1ab909341b1730 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd 2 files changed, 16 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46035 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia72fdeab1670a285d76d6df24c1ab909341b1730 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use elements instead of attributes in "console"
by juan.hernandez＠redhat.com 22 Sep '15

22 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use elements instead of attributes in "console" ...................................................................... restapi: Use elements instead of attributes in "console" Currently "console" element uses attributes for its properties: <console enabled="true"/> This is contrary to the common practice in the RESTAPI. This patch replaces them with inner elements: <console> <enabled>true</enabled> </console> Change-Id: Ib805ad6858771d651c30439fb0b3177337ca6ebb Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/README.md M backend/manager/modules/restapi/interface/definition/src/main/schema/api.xsd 2 files changed, 16 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46032 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib805ad6858771d651c30439fb0b3177337ca6ebb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: fence agent duplicate agents
by awels＠redhat.com 22 Sep '15

22 Sep '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fence agent duplicate agents ...................................................................... webadmin: fence agent duplicate agents - Fence agents should allow the same IP but with different management types. It should NOT allow duplicate ip/type combinations. Change-Id: Ic3c947a782997482e20a166a99bbbf8f785c1323 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1257575 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/FenceAgentModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 3 files changed, 12 insertions(+), 5 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46479 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3c947a782997482e20a166a99bbbf8f785c1323 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0