- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Remove useless object in "BackendGraphicsConsoleRes...
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Remove useless object in "BackendGraphicsConsoleResource" ...................................................................... restapi: Remove useless object in "BackendGraphicsConsoleResource" This is needed in order to avoid the following findbugs warning: Useless object created Our analysis shows that this object is useless. It's created and modified, but its value never go outside of the method or produce any side-effect. Either there is a mistake and object was intended to be used or it can be removed. This analysis rarely produces false-positives. Common false-positive cases include: - This object used to implicitly throw some obscure exception. - This object used as a stub to generalize the code. - This object used to hold strong references to weak/soft-referenced objects. Bug kind and pattern: UC - UC_USELESS_OBJECT Change-Id: I2a42dec0128c3d5a0178dc92e96b219cf284efef Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGraphicsConsoleResource.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46589 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a42dec0128c3d5a0178dc92e96b219cf284efef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use "Integer.parseInt" in "BackendResource"
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use "Integer.parseInt" in "BackendResource" ...................................................................... restapi: Use "Integer.parseInt" in "BackendResource" This is needed in order to avoid the following findbugs error: Boxing/unboxing to parse a primitive A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING Change-Id: Ie3bb154661495b1f1fb10d46ec08447e920dbcb6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46588 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3bb154661495b1f1fb10d46ec08447e920dbcb6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Fix condition in "IconHelper"
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix condition in "IconHelper" ...................................................................... restapi: Fix condition in "IconHelper" This is needed in order to avoid the following findbugs warning, but it also looks like a real bug: Repeated conditional tests The code contains a conditional test is performed twice, one right after the other (e.g., x == 0 || x == 0). Perhaps the second occurrence is intended to be something else (e.g., x == 0 || y == 0). Bug kind and pattern: RpC - RpC_REPEATED_CONDITIONAL_TEST Change-Id: I329dc96c77cd91c175fea8cb70580605dc062782 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/IconHelper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jakub Niedermertl: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46587 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I329dc96c77cd91c175fea8cb70580605dc062782 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Avoid useless condition in "VersionMapper"
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Avoid useless condition in "VersionMapper" ...................................................................... restapi: Avoid useless condition in "VersionMapper" This is needed in order to avoid the following findbugs warning: Condition has no effect This condition always produces the same result as the value of the involved variable was narrowed before. Probably something else was meant or condition can be removed. Bug kind and pattern: UC - UC_USELESS_CONDITION Change-Id: Id1df506d4f924d120e50f4058b2518bee7bd9901 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VersionMapper.java 1 file changed, 6 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46585 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1df506d4f924d120e50f4058b2518bee7bd9901 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Use "Integer.parseInt" in "PermitMapper"
by juan.hernandez＠redhat.com 23 Sep '15

23 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Use "Integer.parseInt" in "PermitMapper" ...................................................................... restapi: Use "Integer.parseInt" in "PermitMapper" This is needed in order to avoid the following findbugs error: Boxing/unboxing to parse a primitive A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method. Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING Change-Id: I2e23d4f8fbabd7db188e0b817b5e21cbd8375f6e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46584 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e23d4f8fbabd7db188e0b817b5e21cbd8375f6e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: setup: add default state transition notifications
by sbonazzo＠redhat.com 23 Sep '15

23 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: add default state transition notifications ...................................................................... setup: add default state transition notifications Add a default value for state transition notifications. Change-Id: I08816776a4b345300e8d022a0336d4a3a0584b97 Bug-Url: https://bugzilla.redhat.com/1260757 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit 3c46e495c15e6c2c8e92a35ffdf0009aa712042d) --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/ha/ha_notifications.py 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46570 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08816776a4b345300e8d022a0336d4a3a0584b97 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: ovirt-hosted-engine-ha: support branched 3.6
by sbonazzo＠redhat.com 23 Sep '15

23 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-hosted-engine-ha: support branched 3.6 ...................................................................... ovirt-hosted-engine-ha: support branched 3.6 support the new branch for 3.6 Change-Id: I3a9606726617a7be4c1671e6cd24fc15b8c8d7be Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-hosted-engine-ha/ovirt-hosted-engine-ha_create-rpms.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a9606726617a7be4c1671e6cd24fc15b8c8d7be Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Hotfix of icon validation for IE
by vszocs＠redhat.com 23 Sep '15

23 Sep '15

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Hotfix of icon validation for IE ...................................................................... webadmin: Hotfix of icon validation for IE It disables part of client side icon validation on IE browsers. The disabled part relies on parsing of images using <img> tag. IE parses images asynchronously as opposed to Chrome or Firefox (after caching). Current frontend validation assumes synchronous behavior. There are still backend icon validations. Change-Id: I2766e993c3e03b5a040a178e26b8b71c93ac585c Bug-Url: https://bugzilla.redhat.com/1263994 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/IconValidation.java 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46532 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2766e993c3e03b5a040a178e26b8b71c93ac585c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: setup: add default state transition notifications
by sbonazzo＠redhat.com 23 Sep '15

23 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: add default state transition notifications ...................................................................... setup: add default state transition notifications Add a default value for state transition notifications. Change-Id: I08816776a4b345300e8d022a0336d4a3a0584b97 Bug-Url: https://bugzilla.redhat.com/1260757 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/ha/ha_notifications.py 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46543 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08816776a4b345300e8d022a0336d4a3a0584b97 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[master]: sharedconf: moving initial broker.conf to engine_ha_statedir
by msivak＠redhat.com 23 Sep '15

23 Sep '15

Martin Sivák has submitted this change and it was merged. Change subject: sharedconf: moving initial broker.conf to engine_ha_statedir ...................................................................... sharedconf: moving initial broker.conf to engine_ha_statedir On oVirt 3.6 the notification system config is on the shared storage. A local copy is keep under engine_ha_statedir to being able to notify failures also if the storage is not available. It periodically got refreshed. Moving there also the initial broker.conf from the rpm. Change-Id: I7a1efcbf346be3ce403175bbe450ff8f0e8b2993 Bug-Url: https://bugzilla.redhat.com/1260757 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-hosted-engine-ha.spec.in M ovirt_hosted_engine_ha/broker/Makefile.am 2 files changed, 9 insertions(+), 4 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a1efcbf346be3ce403175bbe450ff8f0e8b2993 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0