- Engine-commits - oVirt List Archives

Change in ovirt-guest-agent[ovirt-3.6]: PEP8 1.62 compliance fixes
by vfeenstr＠redhat.com 23 Sep '15

23 Sep '15

Vinzenz Feenstra has submitted this change and it was merged. Change subject: PEP8 1.62 compliance fixes ...................................................................... PEP8 1.62 compliance fixes Change-Id: I50b6fedea4a9691b44fd527f1c9bb9cf0ddbde77 Bug-Url: https://bugzilla.redhat.com/1265164 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> (cherry picked from commit c7d34e391a3ca8b78e7e024e6f6919fa03f46898) --- M ovirt-guest-agent/CredServer.py M ovirt-guest-agent/GuestAgentWin32.py M ovirt-guest-agent/OVirtAgentLogic.py M ovirt-guest-agent/ovirt-guest-agent.py 4 files changed, 6 insertions(+), 6 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46576 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50b6fedea4a9691b44fd527f1c9bb9cf0ddbde77 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[master]: Imports reorder
by vfeenstr＠redhat.com 23 Sep '15

23 Sep '15

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Imports reorder ...................................................................... Imports reorder Change-Id: Iab4245af990f35ab2fd3eb34531c59089f33b957 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/CredServer.py M ovirt-guest-agent/GuestAgentLinux2.py M ovirt-guest-agent/GuestAgentWin32.py M ovirt-guest-agent/LockActiveSession.py M ovirt-guest-agent/OVirtAgentLogic.py M ovirt-guest-agent/OVirtGuestService.py M ovirt-guest-agent/VirtIoChannel.py M ovirt-guest-agent/WinFile.py M ovirt-guest-agent/ovirt-guest-agent.py M ovirt-guest-agent/setup.py 10 files changed, 70 insertions(+), 55 deletions(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified; Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab4245af990f35ab2fd3eb34531c59089f33b957 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-guest-agent[master]: PEP8 1.62 compliance fixes
by vfeenstr＠redhat.com 23 Sep '15

23 Sep '15

Vinzenz Feenstra has submitted this change and it was merged. Change subject: PEP8 1.62 compliance fixes ...................................................................... PEP8 1.62 compliance fixes Change-Id: I50b6fedea4a9691b44fd527f1c9bb9cf0ddbde77 Bug-Url: https://bugzilla.redhat.com/1265164 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/CredServer.py M ovirt-guest-agent/GuestAgentWin32.py M ovirt-guest-agent/OVirtAgentLogic.py M ovirt-guest-agent/ovirt-guest-agent.py 4 files changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified; Looks good to me, approved Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50b6fedea4a9691b44fd527f1c9bb9cf0ddbde77 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: Engine: Hide bad 'Done' message for PM test
by oourfali＠redhat.com 23 Sep '15

23 Sep '15

Oved Ourfali has submitted this change and it was merged. Change subject: Engine: Hide bad 'Done' message for PM test ...................................................................... Engine: Hide bad 'Done' message for PM test VSDM returns 'Done' by default for fencing operations. This is not useful and appending it to log messages results in a confusing message. So if the message is 'Done', it's better to ignore it. This patch does that. Bug-Url: https://bugzilla.redhat.com/1203741 Change-Id: Icd4a0a788fba25c491f693747f00f4c64f4413d4 Signed-off-by: Ori Liel <oliel(a)redhat.com> Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/pm/FenceOperationResult.java 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46541 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd4a0a788fba25c491f693747f00f4c64f4413d4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: aaa-jdbc: Add jobs for oVirt 3.6
by dcaroest＠redhat.com 23 Sep '15

23 Sep '15

David Caro has submitted this change and it was merged. Change subject: aaa-jdbc: Add jobs for oVirt 3.6 ...................................................................... aaa-jdbc: Add jobs for oVirt 3.6 Adds branch ovirt-engine-extension-aaa-jdbc-1.0 which will be used for oVirt 3.6 builds Change-Id: I1b642238ff2a7a19c2e37d82550e56267e39da37 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-extension-aaa-jdbc/ovirt-engine-extension-aaa-jdbc_create-rpms.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml 2 files changed, 11 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for review Jenkins CI: Passed CI tests David Caro: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/46445 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b642238ff2a7a19c2e37d82550e56267e39da37 Gerrit-PatchSet: 6 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>

1 0

Change in jenkins[master]: ovirt-engine_standard: add missing job
by sbonazzo＠redhat.com 23 Sep '15

23 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine_standard: add missing job ...................................................................... ovirt-engine_standard: add missing job add missing check-patch for 3.6 on el6 Change-Id: I8b25ce1dac4f6d8452e3b09a16d6eee24378e443 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46357 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b25ce1dac4f6d8452e3b09a16d6eee24378e443 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>

1 0

Change in jenkins[master]: Restored renew_certificate in 3.5 upgrade answer file
by sbonazzo＠redhat.com 23 Sep '15

23 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Restored renew_certificate in 3.5 upgrade answer file ...................................................................... Restored renew_certificate in 3.5 upgrade answer file The line was removed from the file because it was failing 3.5->3.5 upgrade job, but after removing it 3.4->3.5 upgrades started failing. Restoring the line, with boolean False instead of True. Change-Id: I03172acafda0b2ccf81cd075fdebd8d9237a6a96 Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- M jobs/ovirt-engine_upgrade_to_3.5/setup.file.otopi 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Passed CI tests; Ready for merge Sharon Naftaly: Verified -- To view, visit https://gerrit.ovirt.org/46439 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03172acafda0b2ccf81cd075fdebd8d9237a6a96 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>

1 0

Change in jenkins[master]: ovirt-engine_standard: added check-merged
by sbonazzo＠redhat.com 23 Sep '15

23 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine_standard: added check-merged ...................................................................... ovirt-engine_standard: added check-merged Change-Id: Icbe41c0867e2c071037d45c9a05e0542dbd9fb33 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46542 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbe41c0867e2c071037d45c9a05e0542dbd9fb33 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: SearchableListModel events
by piotr.kliczewski＠gmail.com 22 Sep '15

22 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: SearchableListModel events ...................................................................... webadmin: SearchableListModel events - SearchableListModel events were not being passed to its associated 'EntityModel' which caused Tags to not get the proper events. This patch fixes that issue. Change-Id: Ifd1b4e9e7752e535bb4760adb72bba462639f54f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1205697 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/common/SelectionTreeNodeModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java 3 files changed, 5 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46539 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd1b4e9e7752e535bb4760adb72bba462639f54f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: fence agent duplicate agents
by piotr.kliczewski＠gmail.com 22 Sep '15

22 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: fence agent duplicate agents ...................................................................... webadmin: fence agent duplicate agents - Fence agents should allow the same IP but with different management types. It should NOT allow duplicate ip/type combinations. Change-Id: Ic3c947a782997482e20a166a99bbbf8f785c1323 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1257575 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/FenceAgentModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 3 files changed, 12 insertions(+), 5 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46538 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3c947a782997482e20a166a99bbbf8f785c1323 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0