- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: prevent maintenance a host with hard affinity
by tnisan＠redhat.com 30 Nov '14

30 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: prevent maintenance a host with hard affinity ...................................................................... core: prevent maintenance a host with hard affinity Maintenance a host can break the affinity rule of its running vm The user should be aware of it, and manually handle it: soften the affinity rule or migrate the VMs. Change-Id: Idd93ddca562bf739b2cd423e907be1b6da861735 Bug-Url: https://bugzilla.redhat.com/1084794 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityFilterPolicyUnit.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/AffinityGroupDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/AffinityGroupDaoImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AffinityGroupDaoTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/affinity_groups_sp.sql 10 files changed, 101 insertions(+), 11 deletions(-) Approvals: Gilad Chaplik: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd93ddca562bf739b2cd423e907be1b6da861735 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add missing disk profile translation
by dfediuck＠redhat.com 30 Nov '14

30 Nov '14

Doron Fediuck has submitted this change and it was merged. Change subject: core: add missing disk profile translation ...................................................................... core: add missing disk profile translation Change-Id: I6cc18994af7b37a1e736f0190b31ff63dfcf4d26 Bug-Url: https://bugzilla.redhat.com/1161939 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 3 files changed, 5 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified Roy Golan: Looks good to me, but someone else must approve Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6cc18994af7b37a1e736f0190b31ff63dfcf4d26 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: set Disk Profile for cloned VM from snapshot
by rgolan＠redhat.com 30 Nov '14

30 Nov '14

Roy Golan has submitted this change and it was merged. Change subject: core: set Disk Profile for cloned VM from snapshot ...................................................................... core: set Disk Profile for cloned VM from snapshot Disk Profile was missing in disk image mapping to storage_doamin_image_map. Change-Id: Iab5f79e853a1482ccabf6c287d663da87ab332fe Bug-Url: https://bugzilla.redhat.com/1161939 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified Roy Golan: Looks good to me, approved Liron Aravot: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab5f79e853a1482ccabf6c287d663da87ab332fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: check if the HE guest can be migrated before maintenace
by tnisan＠redhat.com 30 Nov '14

30 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: check if the HE guest can be migrated before maintenace ...................................................................... core: check if the HE guest can be migrated before maintenace When putting VDS to maintenance mode the HE guest is migrated by the ha-agent so it's not checked by the engine at all. In case there is no VDS to migrate the HE guest to the migration will never happen and the host stays in "preparing for maintenance" until the admin activates it manually. This patch adds the logic to check if there is a VDS which can be used for HE guest. It's a bit racy, but it will prevent at least the case described in the referenced bugzilla. Change-Id: I0b9cbcd03f01ca34c6c31308b7321214e15cafc7 Bug-Url: https://bugzilla.redhat.com/1157378 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java 1 file changed, 21 insertions(+), 2 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jiří Moskovčák: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b9cbcd03f01ca34c6c31308b7321214e15cafc7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: configurable ssl protocol
by tnisan＠redhat.com 30 Nov '14

30 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: configurable ssl protocol ...................................................................... core: configurable ssl protocol We need to make ssl protocol configurable. I tested 3.5 engine and vdsm with all combinations (sslv3, tlsv1) and there were no issues. I tested 3.0 engine with 3.5 vdsm and noticed that when tlsv1 was set on vdsm side the communication failed with wrong protocol version. I tested 3.0 vdsm with latest engine (tlsv1) and it worked after hacking host-deploy. Change-Id: I33a33c15e8a995eb8de7d5131b3dbadc6191f873 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1154184 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssl/AuthSSLProtocolSocketFactory.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/attestation/AttestationService.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EngineManagerProvider.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/TransportFactory.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIntegrationTest.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 11 files changed, 52 insertions(+), 21 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33a33c15e8a995eb8de7d5131b3dbadc6191f873 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: handle memory allignment when checking the balloon h...
by tnisan＠redhat.com 30 Nov '14

30 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: handle memory allignment when checking the balloon health ...................................................................... engine: handle memory allignment when checking the balloon health Engine used to check if the ballooning works properly by comparing the target memory with the actual available memory and throws a warning if it doesn't match, the problem is when the requsted target memory value is not alligned. The system then returns the alligned memory and the engine thinks the balloon is not working, becuase the requested value != curent value. This patch changes the behaviour so it only checks if the current value is closer to the requested value than the previous value (in other words: if the current memory moves towards the requested target) Change-Id: Ibc308a2049c117e2409f480adfcd4a3da495a0b9 Bug-Url: https://bugzilla.redhat.com/1120197 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBalloonInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java 3 files changed, 51 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jiří Moskovčák: Verified Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc308a2049c117e2409f480adfcd4a3da495a0b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: Allow registerVds with same name and hostname if provisioned
by tnisan＠redhat.com 30 Nov '14

30 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: Allow registerVds with same name and hostname if provisioned ...................................................................... Allow registerVds with same name and hostname if provisioned Currently we delete the old vds record with InstallingOS status to allow adding new record as waiting for approval. This is wrong approach which causes lose of all the initial information that set on the vds record. With this fix we don't delete the record and skip the duplication check Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1115343 Change-Id: I157b567b2c868b12a89a394e909e97895338380d Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java 1 file changed, 19 insertions(+), 10 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I157b567b2c868b12a89a394e909e97895338380d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: check if the HE guest can be migrated before maintenace
by rgolan＠redhat.com 30 Nov '14

30 Nov '14

Roy Golan has submitted this change and it was merged. Change subject: core: check if the HE guest can be migrated before maintenace ...................................................................... core: check if the HE guest can be migrated before maintenace When putting VDS to maintenance mode the HE guest is migrated by the ha-agent so it's not checked by the engine at all. In case there is no VDS to migrate the HE guest to the migration will never happen and the host stays in "preparing for maintenance" until the admin activates it manually. This patch adds the logic to check if there is a VDS which can be used for HE guest. It's a bit racy, but it will prevent at least the case described in the referenced bugzilla. Change-Id: I0b9cbcd03f01ca34c6c31308b7321214e15cafc7 Bug-Url: https://bugzilla.redhat.com/1157378 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java 1 file changed, 21 insertions(+), 2 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jiří Moskovčák: Verified Roy Golan: Looks good to me, approved Omer Frenkel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35401 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b9cbcd03f01ca34c6c31308b7321214e15cafc7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Inject BackendInternal instead of lookup
by rgolan＠redhat.com 30 Nov '14

30 Nov '14

Roy Golan has submitted this change and it was merged. Change subject: core: Inject BackendInternal instead of lookup ...................................................................... core: Inject BackendInternal instead of lookup Inject CDI insead of expensive static jndi lookups Change-Id: I81cacb4a7613a1ba34abb742385ef08f9436cb43 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81cacb4a7613a1ba34abb742385ef08f9436cb43 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Inject instead of expensive JNDI lookups
by rgolan＠redhat.com 30 Nov '14

30 Nov '14

Roy Golan has submitted this change and it was merged. Change subject: core: Inject instead of expensive JNDI lookups ...................................................................... core: Inject instead of expensive JNDI lookups Inject BackendCommandObjectsHandler instead of continuously fetch it using jndi lookup Change-Id: Ie1efa3a0cefa2f2ece6cd0c5aa4f8be8dd07055f Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Roy Golan: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35495 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1efa3a0cefa2f2ece6cd0c5aa4f8be8dd07055f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0