- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Moved disk alias genenration in AddDiskCommand to exec...
by tnisan＠redhat.com 27 Nov '14

27 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Moved disk alias genenration in AddDiskCommand to execution ...................................................................... core: Moved disk alias genenration in AddDiskCommand to execution Moved the disk alias generation in AddDiskCommand to the execution phase as in the job properties calculation the VM disk map is not yet populated. Also the disk alias was omitted from the execution message as we cannot assure that in 100% of the times a disk alias will be specified (the VM name is not there for the same reason) Bug-Url: https://bugzilla.redhat.com/1168252 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Change-Id: Id30fa5d3a99dd12b8c45633d592d017c3a6ffd1b --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 2 files changed, 2 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id30fa5d3a99dd12b8c45633d592d017c3a6ffd1b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Fixing multiple src rpms build
by dcaroest＠redhat.com 27 Nov '14

27 Nov '14

David Caro has submitted this change and it was merged. Change subject: Fixing multiple src rpms build ...................................................................... Fixing multiple src rpms build On fc21 it seems that building more than one src rpm at a time breaks, now it should build them one by one. Change-Id: I52f340135af03b89abd963acbd1155597fbc09c6 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/shell-scripts/mock_build_onlyrpm.sh 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35675 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52f340135af03b89abd963acbd1155597fbc09c6 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: change import vm to be VmCommand - part 3
by ahadas＠redhat.com 27 Nov '14

27 Nov '14

Arik Hadas has submitted this change and it was merged. Change subject: core: change import vm to be VmCommand - part 3 ...................................................................... core: change import vm to be VmCommand - part 3 Introduce ImportValidator that stores the validation logics which are required for import operations, to reduce the coupling between ImportVmcommand and MoveOrCopyTemplateCommand. This validator will be used later in other import commands. The tests which test the logic of the validation were moved to ImportValidatorTest and the tests in ImportVmCommandTest were changed such that they will check that the right error is returned from the canDoAction method, assuming that the validator returns the appropriate error. Change-Id: I7fa61e7f493d196acdb40bfe461665d6668c6508 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/ImportValidatorTest.java 6 files changed, 392 insertions(+), 50 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fa61e7f493d196acdb40bfe461665d6668c6508 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: ui: Fix search button logic
by tnisan＠redhat.com 27 Nov '14

27 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: ui: Fix search button logic ...................................................................... ui: Fix search button logic Commit 60331c40535c95950274984d89177643df5686db broke the search button logic. This patch returns the same refresh logic that was next to the current changes. Change-Id: Ia86fa287a050e030d28ab96eeecfb888dd1cb22b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1165669 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java 3 files changed, 36 insertions(+), 2 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia86fa287a050e030d28ab96eeecfb888dd1cb22b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Reduced visibility of methods in ExportVmCommand
by tnisan＠redhat.com 27 Nov '14

27 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Reduced visibility of methods in ExportVmCommand ...................................................................... core: Reduced visibility of methods in ExportVmCommand Change-Id: I07ccaed16483a25a4798954bc6bb96e8ef344877 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07ccaed16483a25a4798954bc6bb96e8ef344877 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: New Error Message for an IDE Hot Plug
by tnisan＠redhat.com 27 Nov '14

27 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: New Error Message for an IDE Hot Plug ...................................................................... core: New Error Message for an IDE Hot Plug Hot plugging a disk to an IDE interface is currently not supported at all (by any OS). Thus, the previous error message saying that the guest OS version is not supported is irrelevant. Change-Id: I10acfe04f2089708de7212b179d5e3d71edb4a12 Bug-Url: https://bugzilla.redhat.com/1126547 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 13 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10acfe04f2089708de7212b179d5e3d71edb4a12 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: avoid adding ovf store when register disk fails
by tnisan＠redhat.com 27 Nov '14

27 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: avoid adding ovf store when register disk fails ...................................................................... core: avoid adding ovf store when register disk fails Trying to add an ovf store when the disk registration failed it will result in a low level sql error: ERROR: insert or update on table "storage_domains_ovf_info" violates foreign key constraint "storage_domains_ovf_info_ovf_disk_id_fkey" Change-Id: I947a04e14305cd96afa8c455391f2084856d1fc5 Bug-Url: https://bugzilla.redhat.com/1168132 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/35580 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I947a04e14305cd96afa8c455391f2084856d1fc5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Indentation fix
by tnisan＠redhat.com 27 Nov '14

27 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Indentation fix ...................................................................... core: Indentation fix Change-Id: I236605587b4b43c4490f9897ca71aa786745d240 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/35455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I236605587b4b43c4490f9897ca71aa786745d240 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: Use correct Avalon Framework .jar files in EL7
by sbonazzo＠redhat.com 27 Nov '14

27 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: Use correct Avalon Framework .jar files in EL7 ...................................................................... packaging: Use correct Avalon Framework .jar files in EL7 In version 7 of RHEL and CentOS the Avalon Framework .jar files are split, like in Fedora, but currently we assume that they aren't, as that was the case in version 6. This modifies the .spec file so that this difference is taken into account. Change-Id: Idd0ea12dfbd3ad695cc2a3390fd3d104d2823ea9 Bug-Url: https://bugzilla.redhat.com/1168405 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Juan Hernandez: Verified oVirt Jenkins CI Server: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd0ea12dfbd3ad695cc2a3390fd3d104d2823ea9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: added event log when mixing RHLE 6 and 7 in one cluster
by tnisan＠redhat.com 27 Nov '14

27 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: added event log when mixing RHLE 6 and 7 in one cluster ...................................................................... core: added event log when mixing RHLE 6 and 7 in one cluster It was already disabled to mix this two RHELs, but there was not added a specific message in the event log. This patch adds it, an example: "Not possible to mix RHEL 6.x and 7.x hosts in one cluster. Tried adding RHEL - 6Server - 6.5.0.1.el6 host to a cluster with RHEL - 7Server - 7.5.0.1.el7 hosts." Change-Id: Ia8e58e10f181b6742b88b464739ed39610ac69de Bug-Url: https://bugzilla.redhat.com/1167827 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8e58e10f181b6742b88b464739ed39610ac69de Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0