- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: Engine: log total time to migration
by shavivi＠redhat.com 30 Nov '14

30 Nov '14

Shahar Havivi has submitted this change and it was merged. Change subject: Engine: log total time to migration ...................................................................... Engine: log total time to migration Engine is logging the actual time that last migration took, but not the total time that all the migration process took (ie with retries). Bug-Url: https://bugzilla.redhat.com/1054143 Change-Id: Ib87bb88de09a61b9c3e3d4565deb23c9cb07bbf3 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MigrateVmParameters.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 17 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35451 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib87bb88de09a61b9c3e3d4565deb23c9cb07bbf3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Add try/catch block in end action of ExportVmCommand
by tnisan＠redhat.com 29 Nov '14

29 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add try/catch block in end action of ExportVmCommand ...................................................................... core: Add try/catch block in end action of ExportVmCommand When exporting a VM with the collapse snapshot option, the VM ovf is updated after the images export ends successfully. If this operation will fail and throw an exception the source VM will be stayed in locked status. This patch surrounds the operation with a try/catch block in order to log the fault and continue the end action correctly to unlock the VM and it's disks. Bug-Url: https://bugzilla.redhat.com/1167297 Change-Id: I67e5119f0f65ce77bc30b6762192e927c88c4434 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 13 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67e5119f0f65ce77bc30b6762192e927c88c4434 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Moved disk alias genenration in AddDiskCommand to exec...
by tnisan＠redhat.com 29 Nov '14

29 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Moved disk alias genenration in AddDiskCommand to execution ...................................................................... core: Moved disk alias genenration in AddDiskCommand to execution Moved the disk alias generation in AddDiskCommand to the execution phase as in the job properties calculation the VM disk map is not yet populated. Also the disk alias was omitted from the execution message as we cannot assure that in 100% of the times a disk alias will be specified (the VM name is not there for the same reason) Bug-Url: https://bugzilla.redhat.com/1168252 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Change-Id: Id30fa5d3a99dd12b8c45633d592d017c3a6ffd1b --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 2 files changed, 2 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35698 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id30fa5d3a99dd12b8c45633d592d017c3a6ffd1b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: copy instance type fields to the VM
by piotr.kliczewski＠gmail.com 28 Nov '14

28 Nov '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: copy instance type fields to the VM ...................................................................... restapi: copy instance type fields to the VM As a consequence of the https://bugzilla.redhat.com/1149663 the instance type fields are not copied to the VM on server anymore and frontends (WA/UP/REST) need to take care of it. More specifically it works like this: If only the instance type is selected, it has to copy its properties to the newly created VM (on VM level this can be overridden) If both the template and the instance type is selected, the instance type overrides the template. When copying the parameters from instance type to the VM, only the ones which are supported on the target cluster/OS are taken into account. Change-Id: Id8ff7a39fe74c73d8984fb34169b69649dab7c15 Bug-Url: https://bugzilla.redhat.com/1149663 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/VmHelper.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 4 files changed, 213 insertions(+), 123 deletions(-) Approvals: Tomas Jelinek: Verified Juan Hernandez: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35427 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8ff7a39fe74c73d8984fb34169b69649dab7c15 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: sync: handle group loops
by piotr.kliczewski＠gmail.com 28 Nov '14

28 Nov '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: sync: handle group loops ...................................................................... aaa: sync: handle group loops Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1168631 Change-Id: Ie90ad3cbef9675be8c0ceba47c22609a9985b518 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java 1 file changed, 29 insertions(+), 10 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35704 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie90ad3cbef9675be8c0ceba47c22609a9985b518 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[master]: codegen, sdk: Rename "export" to "export_"
by juan.hernandez＠redhat.com 28 Nov '14

28 Nov '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen, sdk: Rename "export" to "export_" ...................................................................... codegen, sdk: Rename "export" to "export_" The classes generated by the generateDS.py tool contain an "export" method intended to convert the objects to the corresponding XML document. The broker classes generated by our own code generator also generate "export" methods for some resources that have an "export" action, for example virtual machines. These two methods clash, making it impossible to generate XML for some broker classes. To avoid this class this patch modifies our code generator so that it will modify the code generated with generateDS.py, renaming the "export" method to "export_". Change-Id: Iad8a031684ddaed11c1b11efc379e746888cd0a2 Bug-Url: https://bugzilla.redhat.com/1167851 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M generator/src/main/java/org/ovirt/engine/sdk/generator/xsd/XsdCodegen.java M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/infrastructure/common.py M src/ovirtsdk/utils/parsehelper.py M src/ovirtsdk/xml/params.py 6 files changed, 831 insertions(+), 816 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad8a031684ddaed11c1b11efc379e746888cd0a2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: codegen: Remove unused function
by juan.hernandez＠redhat.com 28 Nov '14

28 Nov '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Remove unused function ...................................................................... codegen: Remove unused function This patch removes a function of the XML schema generator that is never used. The change has no impact in the generated code. Change-Id: I79fa56613fe904e4e1087d5bcb41f122b354f9ab Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/engine/sdk/generator/xsd/XsdCodegen.java 1 file changed, 0 insertions(+), 17 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79fa56613fe904e4e1087d5bcb41f122b354f9ab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: aaa: sync: handle group loops
by yzaslavs＠redhat.com 28 Nov '14

28 Nov '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: sync: handle group loops ...................................................................... aaa: sync: handle group loops Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1168631 Change-Id: Ie90ad3cbef9675be8c0ceba47c22609a9985b518 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java 1 file changed, 29 insertions(+), 10 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie90ad3cbef9675be8c0ceba47c22609a9985b518 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add try/catch block in end action of ExportVmCommand
by tnisan＠redhat.com 27 Nov '14

27 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add try/catch block in end action of ExportVmCommand ...................................................................... core: Add try/catch block in end action of ExportVmCommand When exporting a VM with the collapse snapshot option, the VM ovf is updated after the images export ends successfully. If this operation will fail and throw an exception the source VM will be stayed in locked status. This patch surrounds the operation with a try/catch block in order to log the fault and continue the end action correctly to unlock the VM and it's disks. Bug-Url: https://bugzilla.redhat.com/1167297 Change-Id: I67e5119f0f65ce77bc30b6762192e927c88c4434 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 13 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67e5119f0f65ce77bc30b6762192e927c88c4434 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: Use correct Avalon Framework .jar files in EL7
by tnisan＠redhat.com 27 Nov '14

27 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: packaging: Use correct Avalon Framework .jar files in EL7 ...................................................................... packaging: Use correct Avalon Framework .jar files in EL7 In version 7 of RHEL and CentOS the Avalon Framework .jar files are split, like in Fedora, but currently we assume that they aren't, as that was the case in version 6. This modifies the .spec file so that this difference is taken into account. Change-Id: Idd0ea12dfbd3ad695cc2a3390fd3d104d2823ea9 Bug-Url: https://bugzilla.redhat.com/1168405 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit b5d7622f742152d62d850349d7475efed5ff4f3b) --- M ovirt-engine.spec.in 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/35667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd0ea12dfbd3ad695cc2a3390fd3d104d2823ea9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0