- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: Add discovered IP address to provision call
by oourfali＠redhat.com 01 Dec '14

01 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: Add discovered IP address to provision call ...................................................................... Add discovered IP address to provision call In later patch we add to the vds address field the fqdn of the discovered host before the host is provisioned. in the provision call foreman needs the original discovered IP address. Therefore this patch saves the ip and pass it when the provision call is done. Change-Id: I915ed42da851a60a6480f68735b005ab4c3f4a4b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1165668 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/HostProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVdsActionParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 5 files changed, 14 insertions(+), 6 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I915ed42da851a60a6480f68735b005ab4c3f4a4b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: ui: Fixing popupHostView css style
by oourfali＠redhat.com 01 Dec '14

01 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: ui: Fixing popupHostView css style ...................................................................... ui: Fixing popupHostView css style Change-Id: Icbd0177f9758308a39e38b5f57e8c2e3bc8ef55d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1165670 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbd0177f9758308a39e38b5f57e8c2e3bc8ef55d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: ui: fixing addHost form issues when playing with using host ...
by oourfali＠redhat.com 01 Dec '14

01 Dec '14

Oved Ourfali has submitted this change and it was merged. Change subject: ui: fixing addHost form issues when playing with using host provider ...................................................................... ui: fixing addHost form issues when playing with using host provider Apparently hiding the host provider form was buggy. In this patch we fix the fields cleaning and the visibility of the provider parameters. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1165670 Change-Id: I700ec281a1bd1617d0168d59c8daef5b5bcf4f6b Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java 3 files changed, 12 insertions(+), 18 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I700ec281a1bd1617d0168d59c8daef5b5bcf4f6b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Improve LexoNumericComparator case-insensitive behavior
by lvernia＠redhat.com 01 Dec '14

01 Dec '14

Lior Vernia has submitted this change and it was merged. Change subject: core: Improve LexoNumericComparator case-insensitive behavior ...................................................................... core: Improve LexoNumericComparator case-insensitive behavior It is generally bad to return 0 when comparing strings that aren't identical - I can think of at least two good reasons. Firstly, due to dysfunctional TreeSet behavior in Java (it uses a comparator to tell whether two items are identical - this actually breaks the contract of Set, which is guaranteed to only refer to items as identical if they return the same hashCode() or true for equals()), it is best to distinguish between non-identical strings even if they're equal when compared case-insensitively. Secondly, when collections of items are sorted, it's best to have a deterministic order between them - otherwise "equal" rows may switch places (e.g. upon refresh). Change-Id: I097cdb5f4f784577586160f10c0ef151fc9c9b4f Bug-Url: https://bugzilla.redhat.com/1167641 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/LexoNumericComparator.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/comparators/LexoNumericComparatorTest.java 2 files changed, 28 insertions(+), 6 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/35572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I097cdb5f4f784577586160f10c0ef151fc9c9b4f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : [mla] query execution failed due to insufficient pe...
by yzaslavs＠redhat.com 01 Dec '14

01 Dec '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine : [mla] query execution failed due to insufficient permissions ...................................................................... engine : [mla] query execution failed due to insufficient permissions GetTasksStatusesByTasksIDsQuery throws insufficient permissions when querying for task ids Change-Id: I2d036f6a03a5f46342945452340133bd8150ce45 Bug-Url: https://bugzilla.redhat.com/1153043 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTasksStatusesByTasksIDsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java 3 files changed, 31 insertions(+), 4 deletions(-) Approvals: Ravi Nori: Verified Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d036f6a03a5f46342945452340133bd8150ce45 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: do not decrease pending resources twice on run vm
by ahadas＠redhat.com 30 Nov '14

30 Nov '14

Arik Hadas has submitted this change and it was merged. Change subject: core: do not decrease pending resources twice on run vm ...................................................................... core: do not decrease pending resources twice on run vm We used to decrease the pending resources twice when running VM - when the VM is switched to powering-up (onPoweringUp) and when it is switched to up (runningSucceeded). The problem is that we don't update the cached field, lastDecreasedVds, so on runningSucceeded we don't know that the pending resources were already been decreased. This patch changes the pending decrement in onPoweringUp method such that the VDS we are decrementing the pending resources from will be cached. Change-Id: Ie73f98504ae61ec20a722501fdd49930892dd80a Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 4 files changed, 9 insertions(+), 8 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/35669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie73f98504ae61ec20a722501fdd49930892dd80a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: decrement pending vm on 'run in paused mode'
by ahadas＠redhat.com 30 Nov '14

30 Nov '14

Arik Hadas has submitted this change and it was merged. Change subject: core: decrement pending vm on 'run in paused mode' ...................................................................... core: decrement pending vm on 'run in paused mode' In a flow where VM is started in paused state neither of runningSucceeded nor runningFailed methods in RunVmCommand are called. The command is kept in the collection of async commands until the VM will be resumed. On resume, the reportCompleted method of the original RunVmCommand will be called and it will be removed from the async command collection. Thus, the pending resources are not cleared in this flow. The solution is to decrease the pending resources in the reportCompleted method if they were not decreased before. Change-Id: Icc931118a848c1c7507c407d955537761dd1a742 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/35636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc931118a848c1c7507c407d955537761dd1a742 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Restore storage_pool_id to storage_domain_for_search
by tnisan＠redhat.com 30 Nov '14

30 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Restore storage_pool_id to storage_domain_for_search ...................................................................... core: Restore storage_pool_id to storage_domain_for_search In commit a7caea90, data center uuid for storage search was removed. This fix returns it when the SD is attach to a single DC. Change-Id: I24cbfe91073f888d58d44b853aca94d0024ef917 Bug-Url: https://bugzilla.redhat.com/1166182 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M packaging/dbscripts/create_views.sql 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24cbfe91073f888d58d44b853aca94d0024ef917 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Restore storage_pool_id to storage_domain_for_search
by gchaplik＠redhat.com 30 Nov '14

30 Nov '14

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Restore storage_pool_id to storage_domain_for_search ...................................................................... core: Restore storage_pool_id to storage_domain_for_search In commit a7caea90, data center uuid for storage search was removed. This fix returns it when the SD is attach to a single DC. Change-Id: I24cbfe91073f888d58d44b853aca94d0024ef917 Bug-Url: https://bugzilla.redhat.com/1166182 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M packaging/dbscripts/create_views.sql 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, but someone else must approve Eli Mesika: Looks good to me, but someone else must approve Gilad Chaplik: Verified; Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/35627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24cbfe91073f888d58d44b853aca94d0024ef917 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix storage QoS UI validation
by gchaplik＠redhat.com 30 Nov '14

30 Nov '14

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: fix storage QoS UI validation ...................................................................... webadmin: fix storage QoS UI validation The storage values weren't validated. Also added a check to allow setting total or read/write. Change-Id: Ia4f69ce1b7751e066c6a1e15f482805bbc7df16a Bug-Url: https://bugzilla.redhat.com/1168558 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/StorageQosMetricParametersModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 19 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35676 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4f69ce1b7751e066c6a1e15f482805bbc7df16a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0