- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Add HostNetworkQos widget
by lvernia＠redhat.com 24 Nov '14

24 Nov '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Add HostNetworkQos widget ...................................................................... webadmin: Add HostNetworkQos widget Added model and view for a reusable host network QoS widget, to be used when overriding QoS configuration on a specific host interface and in a dialog of its own (same as other QoS entities). Change-Id: I6a97c260ba18d21d911a0338149fefc2c6222c52 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/HostNetworkQosParametersModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/HostNetworkQosWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/HostNetworkQosWidget.ui.xml 5 files changed, 193 insertions(+), 0 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a97c260ba18d21d911a0338149fefc2c6222c52 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Implement HostNetworkQos [de]serialization
by lvernia＠redhat.com 24 Nov '14

24 Nov '14

Lior Vernia has submitted this change and it was merged. Change subject: engine: Implement HostNetworkQos [de]serialization ...................................................................... engine: Implement HostNetworkQos [de]serialization Implemented HostNetworkQosMapper, which serializes and deserializes HostNetworkQos entities according to the vdsm contract. Change-Id: I8fab9e53938823463ff01af0a153390804f276c3 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkQosMapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 2 files changed, 89 insertions(+), 2 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fab9e53938823463ff01af0a153390804f276c3 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Added workspace cleanup job
by dcaroest＠redhat.com 24 Nov '14

24 Nov '14

David Caro has submitted this change and it was merged. Change subject: Added workspace cleanup job ...................................................................... Added workspace cleanup job Removes all the workspaces from all the slaves (even offline ones) that are not currently used by any job. It also cheks that there are no stalled mounts on the workspace and tries to umount before deleting. Added also a nice summary in case some of them failed to cleanup. Change-Id: I97ad249a432129ca0f8b176d9fa8dbe6b1bfb5b5 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A jobs/confs/groovy-scripts/cleanup_workspaces.groovy A jobs/confs/groovy-scripts/cleanup_workspaces.postbuild.groovy A jobs/confs/yaml/jobs/system/system_cleanup-workspaces.yaml 3 files changed, 202 insertions(+), 0 deletions(-) Approvals: David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97ad249a432129ca0f8b176d9fa8dbe6b1bfb5b5 Gerrit-PatchSet: 6 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Added possible json option value encoding
by dcaroest＠redhat.com 24 Nov '14

24 Nov '14

David Caro has submitted this change and it was merged. Change subject: Added possible json option value encoding ...................................................................... Added possible json option value encoding Sometimes mock has options that are python arrays, or dicts, before all the options were used just as strings, now if possible, it will try to decode an object using json parser. Change-Id: I66feb645fab0308b7fea9e759cdb5d88b2278a41 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M mock_configs/mock_genconfig 1 file changed, 11 insertions(+), 5 deletions(-) Approvals: David Caro: Verified; Looks good to me, approved Objections: Ewoud Kohl van Wijngaarden: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/35238 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66feb645fab0308b7fea9e759cdb5d88b2278a41 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: prevent persistence of runtime NUMA info
by gchaplik＠redhat.com 24 Nov '14

24 Nov '14

Gilad Chaplik has submitted this change and it was merged. Change subject: core: prevent persistence of runtime NUMA info ...................................................................... core: prevent persistence of runtime NUMA info NUMA runtime info is shown wrongfully (bug 1100202), also causes double pinning on the same node (bug fix). This patch removes the persistence of NUMA runtime info, till it gets resolved. Change-Id: Ic87e09d1afae2e577f5a03ebaccc12a32ccf7681 Bug-Url: https://bugzilla.redhat.com/1147880 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 0 insertions(+), 13 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35235 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic87e09d1afae2e577f5a03ebaccc12a32ccf7681 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in mom[master]: Track and log exceptions during thread init
by alitke＠redhat.com 24 Nov '14

24 Nov '14

Adam Litke has submitted this change and it was merged. Change subject: Track and log exceptions during thread init ...................................................................... Track and log exceptions during thread init We are currently tracking and logging exceptions that happen in mom threads within their run loop. We should also log exceptions that are raised during thread initialization. Change-Id: Iaf2289a401156c9384b4237f631313c4031a6cf2 Signed-off-by: Adam Litke <alitke(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/35437 Reviewed-by: Martin Sivák <msivak(a)redhat.com> --- M mom/__init__.py M tests/GeneralTests.py 2 files changed, 18 insertions(+), 14 deletions(-) Approvals: Adam Litke: Verified; Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf2289a401156c9384b4237f631313c4031a6cf2 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: packaging: setup: better handling of preexisting storage domain
by sbonazzo＠redhat.com 24 Nov '14

24 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: better handling of preexisting storage domain ...................................................................... packaging: setup: better handling of preexisting storage domain Better handling of preexisting storage domain validating it Change-Id: I622e0540ca21eea5ebddbfa4361bfb6537ca42d8 Bug-Url: https://bugzilla.redhat.com/1155637 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit edc763f1a773e59baa7d3c965c6dff5344cb3ace) --- M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 1 file changed, 16 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/35388 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I622e0540ca21eea5ebddbfa4361bfb6537ca42d8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Enable Long xmlrpc support for new VM and disk hotplug
by tnisan＠redhat.com 24 Nov '14

24 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Enable Long xmlrpc support for new VM and disk hotplug ...................................................................... engine: Enable Long xmlrpc support for new VM and disk hotplug This is needed for the two commands to support Long based values in the ioTune QoS policy parameters. Change-Id: I82673b6dec7ba320c56a1cf6e0cd3f1dde86fd22 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145621 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Tal Nisan: Looks good to me, approved Martin Sivák: Verified -- To view, visit http://gerrit.ovirt.org/35278 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82673b6dec7ba320c56a1cf6e0cd3f1dde86fd22 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Use proper units in Storage QoS when talking to VDSM
by tnisan＠redhat.com 24 Nov '14

24 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Use proper units in Storage QoS when talking to VDSM ...................................................................... engine: Use proper units in Storage QoS when talking to VDSM The engine used Mbps and VDSM expects B/s. This patch changes the engine side to use MB/s (as is more common when dealing with storage) and properly translates that to Bytes when sending the value to VDSM. Change-Id: I2644e9e029c8b6ebe4b5b7626f7b1ed6b6b5aea4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145621 Signed-off-by: Martin Sivák <msivak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/StorageQos.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 3 files changed, 20 insertions(+), 14 deletions(-) Approvals: Martin Sivák: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2644e9e029c8b6ebe4b5b7626f7b1ed6b6b5aea4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Enhance the xml-rpc Long support to deal with Maps a...
by tnisan＠redhat.com 24 Nov '14

24 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Enhance the xml-rpc Long support to deal with Maps and Lists ...................................................................... engine: Enhance the xml-rpc Long support to deal with Maps and Lists It is common to have a Long value in a sub-map of an xml-rpc argument. The current implementation does not deal with this case. The ideal solution to this would be to instruct the marshaller to do this. Unfortunately that is not possible and we have to work around that limitation. Change-Id: I5a5933a68f937c4734b547c173188e88bd7b9464 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145665 Signed-off-by: Martin Sivák <msivak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java 1 file changed, 32 insertions(+), 5 deletions(-) Approvals: Martin Sivák: Verified Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35352 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a5933a68f937c4734b547c173188e88bd7b9464 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0