- Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[master]: be more verbose when starting the HE VM fails
by msivak＠redhat.com 25 Nov '14

25 Nov '14

Martin Sivák has submitted this change and it was merged. Change subject: be more verbose when starting the HE VM fails ...................................................................... be more verbose when starting the HE VM fails Change-Id: Ieb4842048aa690925284d62685156f56485dd41e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1150087 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/hosted_engine.py 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34204 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb4842048aa690925284d62685156f56485dd41e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: Latest template instace safe recognition
by tjelinek＠redhat.com 25 Nov '14

25 Nov '14

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal, webadmin: Latest template instace safe recognition ...................................................................... userportal, webadmin: Latest template instace safe recognition Regular template and latest template (the one pointing to the lates version) were recognized by matching of localized UI name. This patch introduces frontend only class LatestVmTemplate to mark latest templates. Change-Id: I161f1d9603ea17ef7fc3801eb3dfa0cb924af2b4 Bug-Url: https://bugzilla.redhat.com/1166152 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/LatestVmTemplate.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 6 files changed, 76 insertions(+), 56 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified -- To view, visit http://gerrit.ovirt.org/35472 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I161f1d9603ea17ef7fc3801eb3dfa0cb924af2b4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Fixed issue introduced by #35238
by dcaroest＠redhat.com 25 Nov '14

25 Nov '14

David Caro has submitted this change and it was merged. Change subject: Fixed issue introduced by #35238 ...................................................................... Fixed issue introduced by #35238 Now all the strings have extra single quotes, and the script parses the config to get some values, adapted. Change-Id: Ie7a6ac35940ab2d89a748e0f5da9d68e2e39a3cd Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/shell-scripts/build_mock_srcrpm.sh M jobs/confs/shell-scripts/mock_build_onlyrpm.sh 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35500 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7a6ac35940ab2d89a748e0f5da9d68e2e39a3cd Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: etl: etl version is now defined by package settings
by ydary＠redhat.com 25 Nov '14

25 Nov '14

Yaniv Dary has submitted this change and it was merged. Change subject: etl: etl version is now defined by package settings ...................................................................... etl: etl version is now defined by package settings This will pervent mismatch with spec defined version, since the default will be set by spec. Change-Id: Id058b661464ae8348fe03b4f549cf1d40c9fd5fe Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M etl_export/ovirt_engine_dwh/historyetl_3_6/contexts/Default.properties M etl_export/ovirt_engine_dwh/parallelrun_3_6/contexts/Default.properties M etl_export/src/ovirt_engine_dwh/historyetl_3_6/HistoryETL.java M etl_export/src/ovirt_engine_dwh/parallelrun_3_6/ParallelRun.java M tos_project/process/HistoryETL_3.6.item M tos_project/process/HistoryETL_3.6.properties M tos_project/process/ParallelRun_3.6.item M tos_project/process/ParallelRun_3.6.properties 8 files changed, 53 insertions(+), 74 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35084 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id058b661464ae8348fe03b4f549cf1d40c9fd5fe Gerrit-PatchSet: 9 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: do not instantiate singleton class
by rgolan＠redhat.com 25 Nov '14

25 Nov '14

Roy Golan has submitted this change and it was merged. Change subject: core: do not instantiate singleton class ...................................................................... core: do not instantiate singleton class - removed instantiation of class which is singleton and should not be instantiated, and should be injected if needed, and which field was unsused - removed other unused stuff Change-Id: Id142e03724cf83e10aa631e2785632610d7cecc9 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Martin Mucha: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30513 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id142e03724cf83e10aa631e2785632610d7cecc9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: fix for CID 1243174 cidrContainer static
by alkaplan＠redhat.com 25 Nov '14

25 Nov '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: fix for CID 1243174 cidrContainer static ...................................................................... engine: fix for CID 1243174 cidrContainer static modify CidrContainer inner class to static Change-Id: I2b29ce4450c05bac92095b45327a4183727b8a43 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/CidrAnnotationTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b29ce4450c05bac92095b45327a4183727b8a43 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Support multiple links to DC from SD
by juan.hernandez＠redhat.com 25 Nov '14

25 Nov '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Support multiple links to DC from SD ...................................................................... restapi: Support multiple links to DC from SD Currently the Storage Domains available in the top level /storagedomains collection don't have a reference to the Data Centers that they are attached to. Only the /datacenters/{datacenter:id}/storagedomains collection provides this information, but in the context of particular Data Center, so there is no way to easily find out to which Data Centers a Storage Domain is attached to. In general a Storage Domain may be attached to multiple Data Centers simultaneously (an ISO Storage Domain in particular). To simplify finding the Data Centers this patch adds a new "data_centers" attribute to all the Storage Domain collections. This will contain a set of links to the Data Centers. For example: GET /storagedomains/{storagedomain:id} <storage_domain id="..." href="..."> <name>mydata</name> <data_centers> <data_center id="..." href="..."/> <data_center id="..." href="..."/> ... </data_centers> </storage_domain> The previously existing "data_center" (capable of holding one Data Center only) will be preserved for backwards compatibility, but it will removed in the next major release. Change-Id: I55c52309645f73d7a790c07135c21acf91feb824 Bug-Url: https://bugzilla.redhat.com/1132499 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAttachedStorageDomainResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAttachedStorageDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/StorageDomainHelper.java 6 files changed, 77 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35406 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55c52309645f73d7a790c07135c21acf91feb824 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix CDA for AddVmCommand
by shavivi＠redhat.com 25 Nov '14

25 Nov '14

Shahar Havivi has submitted this change and it was merged. Change subject: core: Fix CDA for AddVmCommand ...................................................................... core: Fix CDA for AddVmCommand The command allowed a user to add a VM using REST before the DC was initialized, this VM caused problems in some flows. Added a check for the storage pool status that will cause the command to fail when the DC is down. Change-Id: I2586b0026c85f053b6cd0aebeb555d760afc0937 Bug-Url: https://bugzilla.redhat.com/1157229 Signed-off-by: Eldan Shachar <eshachar(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java 2 files changed, 7 insertions(+), 0 deletions(-) Approvals: Eldan Shachar: Verified Shahar Havivi: Looks good to me, approved Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35454 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2586b0026c85f053b6cd0aebeb555d760afc0937 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Show non-overridden QoS values for host interface
by lvernia＠redhat.com 24 Nov '14

24 Nov '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Show non-overridden QoS values for host interface ...................................................................... webadmin: Show non-overridden QoS values for host interface Previously only overridden values would be shown - this fetches the QoS values even if they're configured on the network instead of the interface (and there's no overriding on the interface). Change-Id: I74331880697e86dd4764cbdf7cbecaa5210612d8 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 23 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/34134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74331880697e86dd4764cbdf7cbecaa5210612d8 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Ensure that all networks on NIC have QoS
by lvernia＠redhat.com 24 Nov '14

24 Nov '14

Lior Vernia has submitted this change and it was merged. Change subject: engine: Ensure that all networks on NIC have QoS ...................................................................... engine: Ensure that all networks on NIC have QoS Because of various damaging edge cases where some networks have QoS configured on top of one logical interface while others don't, this blocks a setup networks operation if only some of the networks on the interface have it configured. Change-Id: I59bf1bd6fcd26c3229cf0068d06e643b1abe1003 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 110 insertions(+), 13 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34132 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59bf1bd6fcd26c3229cf0068d06e643b1abe1003 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0