- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Push ioTune QoS info when hotplugging disk
by dfediuck＠redhat.com 25 Nov '14

25 Nov '14

Doron Fediuck has submitted this change and it was merged. Change subject: core: Push ioTune QoS info when hotplugging disk ...................................................................... core: Push ioTune QoS info when hotplugging disk This adds the support for disk QoS for disks that are hotplugged while the VM is already running. Change-Id: Ic4bb85cd307089088be77cff28adbc783ebcaedd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145665 Signed-off-by: Martin Sivák <msivak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 2 files changed, 33 insertions(+), 12 deletions(-) Approvals: Martin Sivák: Verified Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4bb85cd307089088be77cff28adbc783ebcaedd Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Adding an existing block Storage Domain should be blocked
by mlipchuk＠redhat.com 25 Nov '14

25 Nov '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Adding an existing block Storage Domain should be blocked ...................................................................... core: Adding an existing block Storage Domain should be blocked Adding an existing Storage Domain should be blocked by a CDA message Change-Id: Iba5194e4c87ba96a7482fa52b18a2e9812663c7e Bug-Url: https://bugzilla.redhat.com/1148803 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommandTest.java 2 files changed, 33 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/35508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba5194e4c87ba96a7482fa52b18a2e9812663c7e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add lock when importing an exsiting block Storage Domain
by mlipchuk＠redhat.com 25 Nov '14

25 Nov '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add lock when importing an exsiting block Storage Domain ...................................................................... core: Add lock when importing an exsiting block Storage Domain Add memory lock while importing an existing block Storage Domain. Change-Id: I43dfed013fcbf9965466a00e01b5c81cc6dc9174 Bug-Url: https://bugzilla.redhat.com/1148803 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/35509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43dfed013fcbf9965466a00e01b5c81cc6dc9174 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: change import vm to be VmCommand - part 2
by ahadas＠redhat.com 25 Nov '14

25 Nov '14

Arik Hadas has submitted this change and it was merged. Change subject: core: change import vm to be VmCommand - part 2 ...................................................................... core: change import vm to be VmCommand - part 2 Inline checkStoragePool method call and moved fillMacAddress method, to reduce the coupling between ImportVmCommand and MoveOrCopyTemplateCommand. Change-Id: Ie7063d22fbe4bd81de24f050660e35b3ea7b96cd Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java 2 files changed, 9 insertions(+), 9 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/34986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7063d22fbe4bd81de24f050660e35b3ea7b96cd Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in mom[master]: CpuTune - use previous value if quota or period is None
by alitke＠redhat.com 25 Nov '14

25 Nov '14

Adam Litke has submitted this change and it was merged. Change subject: CpuTune - use previous value if quota or period is None ...................................................................... CpuTune - use previous value if quota or period is None The policy may not set the value of quota or period if it detected no change. the controller than isn't performing the call to setVmCpuTune. The fix will make sure to call setVmCpuTune whenever one of the params changed and it isn't null. Bug-Url: https://bugzilla.redhat.com/1143992 Change-Id: I6ee063062b3596dde0e16d78900688d5dfb059bd Signed-off-by: Roy Golan <rgolan(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/35329 Reviewed-by: Martin Sivák <msivak(a)redhat.com> Reviewed-by: Doron Fediuck <dfediuck(a)redhat.com> Reviewed-by: Adam Litke <alitke(a)redhat.com> --- M mom/Controllers/CpuTune.py 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Adam Litke: Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Doron Fediuck: Looks good to me, but someone else must approve Roy Golan: Verified -- To view, visit http://gerrit.ovirt.org/35329 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ee063062b3596dde0e16d78900688d5dfb059bd Gerrit-PatchSet: 5 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Cluster parameters override
by juan.hernandez＠redhat.com 25 Nov '14

25 Nov '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Cluster parameters override ...................................................................... restapi: Cluster parameters override This feature allows to configure the 'emulated machine' and 'cpu model' parameters for each VM separately instead of relying on the cluster default. Change-Id: Ibfe64e713edd43cad33b385699159db534112c02 Bug-Url: https://bugzilla.redhat.com/838487 Feature-page:http://www.ovirt.org/Features/Cluster_parameters_override Signed-off-by: Eldan Shachar <eshachar(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmBaseMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 4 files changed, 40 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfe64e713edd43cad33b385699159db534112c02 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: Revert "setup: Changing task cleaner utility to also handle ...
by oourfali＠redhat.com 25 Nov '14

25 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: Revert "setup: Changing task cleaner utility to also handle removal of commands" ...................................................................... Revert "setup: Changing task cleaner utility to also handle removal of commands" This reverts commit a5462c7356b90b1465e05f4bb84f63a0005892bc. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1167769 Change-Id: I5f08ff501606d06907704b60c57e950837d4e162 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M packaging/setup/dbutils/taskcleaner.sh M packaging/setup/dbutils/taskcleaner_sp.sql 2 files changed, 5 insertions(+), 88 deletions(-) Approvals: Yedidyah Bar David: Looks good to me, but someone else must approve Yair Zaslavsky: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35512 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f08ff501606d06907704b60c57e950837d4e162 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Image configuration adjustments for cloning a VM
by tnisan＠redhat.com 25 Nov '14

25 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Image configuration adjustments for cloning a VM ...................................................................... core: Image configuration adjustments for cloning a VM While cloning a VM, in some cases disk image configurations must be applied before executing the command. Specifically when cloning a VM's snapshot with thin NFS, raw disk allocation, to a VM with thin block disk allocation- the raw format needs to be changed to COW. Change-Id: Id924e9beab5d84277fad4f3a2a40b14571beaf22 Bug-Url: https://bugzilla.redhat.com/1121397 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommandTest.java 4 files changed, 29 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Amit Aviram: Verified -- To view, visit http://gerrit.ovirt.org/35225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id924e9beab5d84277fad4f3a2a40b14571beaf22 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Revert "setup: Changing task cleaner utility to also handle ...
by yzaslavs＠redhat.com 25 Nov '14

25 Nov '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: Revert "setup: Changing task cleaner utility to also handle removal of commands" ...................................................................... Revert "setup: Changing task cleaner utility to also handle removal of commands" This reverts commit 036eb1652e4252c967d24e25518b140665eac9db. Change-Id: I5f08ff501606d06907704b60c57e950837d4e162 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M packaging/setup/dbutils/taskcleaner.sh M packaging/setup/dbutils/taskcleaner_sp.sql 2 files changed, 5 insertions(+), 88 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f08ff501606d06907704b60c57e950837d4e162 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix Live Merge recovery with JSON-RPC hosts
by oourfali＠redhat.com 25 Nov '14

25 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Fix Live Merge recovery with JSON-RPC hosts ...................................................................... core: Fix Live Merge recovery with JSON-RPC hosts JSON-RPC calls to the reconcileVolumeChain verb were not done correctly, causing recovery to fail if live merge was interrupted by e.g. host shutdown during the merge operation. Change-Id: If1b23580ae6023754d2e02000dc5913262b3ef8b Bug-Url: https://bugzilla.redhat.com/1161127 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Greg Padgett: Verified Allon Mureinik: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35017 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1b23580ae6023754d2e02000dc5913262b3ef8b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0