- Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: core: Allow automation of first interactions
by sbonazzo＠redhat.com 24 Nov '14

24 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: core: Allow automation of first interactions ...................................................................... core: Allow automation of first interactions Move questions to stage setup, add to answer file. Change-Id: Iffb05e4a520aa8f8f8a2d7f36e60aee556360302 Bug-Url: https://bugzilla.redhat.com/1101285 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit a294fdfc7a410aadb6fd1c72594989e2f3ef1a26) --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/core/misc.py M src/plugins/ovirt-hosted-engine-setup/core/shell.py 3 files changed, 38 insertions(+), 11 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/35443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffb05e4a520aa8f8f8a2d7f36e60aee556360302 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add Video managed device for VM's/Template's OVF.
by mlipchuk＠redhat.com 23 Nov '14

23 Nov '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add Video managed device for VM's/Template's OVF. ...................................................................... core: Add Video managed device for VM's/Template's OVF. The number of monitors data in the Template should be part of the OVF data. so the information will still be availale after the attach of a Storage Domain with import of existing entities. This information consists in the video device of the entity, therefore the fix adds video devices while building the OVF data, same as being done in the export VM/Template process. Change-Id: I5583edadd75bce7dfb3f5ba04cfcbe38f1dc7091 Bug-Url: https://bugzilla.redhat.com/1136902 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/34734 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5583edadd75bce7dfb3f5ba04cfcbe38f1dc7091 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Use debug on register operation.
by tnisan＠redhat.com 23 Nov '14

23 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Use debug on register operation. ...................................................................... core: Use debug on register operation. When register a disk with snapshot, there is no reason to log an error but instead only use a debug level log. Change-Id: If302d623ab13217776e0cb6ec49dda9cc59b7b39 Bug-Url: https://bugzilla.redhat.com/1136808 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDisksQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/35446 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If302d623ab13217776e0cb6ec49dda9cc59b7b39 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Improve reporting when scheduling fails on network
by gchaplik＠redhat.com 23 Nov '14

23 Nov '14

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: Improve reporting when scheduling fails on network ...................................................................... engine: Improve reporting when scheduling fails on network This fixes and improves the way we construct canDoAction messages in the NetworkPolicyUnit. Change-Id: Ic60daf20842ba69457b293f451060e21381faf80 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1132951 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1114987 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NetworkPolicyUnit.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 42 insertions(+), 43 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic60daf20842ba69457b293f451060e21381faf80 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Use debug on register operation.
by mlipchuk＠redhat.com 23 Nov '14

23 Nov '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use debug on register operation. ...................................................................... core: Use debug on register operation. When register a disk with snapshot, there is no reason to log an error but instead only use a debug level log. Change-Id: If302d623ab13217776e0cb6ec49dda9cc59b7b39 Bug-Url: https://bugzilla.redhat.com/1136808 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDisksQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified Liron Aravot: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33154 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If302d623ab13217776e0cb6ec49dda9cc59b7b39 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: fixing display of host fqdn in addHost form
by oourfali＠redhat.com 23 Nov '14

23 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: ui: fixing display of host fqdn in addHost form ...................................................................... ui: fixing display of host fqdn in addHost form In this patch we create the initial vds name record with the hostgroup domain url. Hostname should be field automatically based on the picked hostgroup and the name. When user change the name field the hostname should be updated accordingly. Change-Id: I74e17d69423e1c02028f596ecafb13a21ab3e3ca Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1165668 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalDiscoveredHost.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java 4 files changed, 78 insertions(+), 21 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74e17d69423e1c02028f596ecafb13a21ab3e3ca Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Not possible to edit an instance type
by ofrenkel＠redhat.com 23 Nov '14

23 Nov '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: Not possible to edit an instance type ...................................................................... core: Not possible to edit an instance type A regression introduced in 176bafa8f9ecdc7bf4f06cb0bebd7c2044de2832 The mOldTemplate has to be loaded also when the cluster is null (the case of instance type). Change-Id: I3229350827f2d4dc90ba815007d7cbf1e73b74bc Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35429 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3229350827f2d4dc90ba815007d7cbf1e73b74bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: refresh button wrapping
by tnisan＠redhat.com 23 Nov '14

23 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: refresh button wrapping ...................................................................... webadmin: refresh button wrapping - Fixed refresh button wrapping when there is not enough room to fit all the buttons. Change-Id: I1fc13aea7950ab3f4965131dcc2b32e4ea837192 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1163929 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fc13aea7950ab3f4965131dcc2b32e4ea837192 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: Multi view table columns inconsistent
by tnisan＠redhat.com 23 Nov '14

23 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: userportal,webadmin: Multi view table columns inconsistent ...................................................................... userportal,webadmin: Multi view table columns inconsistent - since a463914769e87b5fb55999bcd25d56167b8e3d16 columns available in all view would not get removed and would always end up at the front of the grid even if other columns that can disappear were in front of them. This patch fixes that problem. Change-Id: I143894af611f8364da943433e81378690adcb0e8 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1157215 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java 1 file changed, 21 insertions(+), 37 deletions(-) Approvals: Alexander Wels: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I143894af611f8364da943433e81378690adcb0e8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Add discovered IP address to provision call
by oourfali＠redhat.com 23 Nov '14

23 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: Add discovered IP address to provision call ...................................................................... Add discovered IP address to provision call In later patch we add to the vds address field the fqdn of the discovered host before the host is provisioned. in the provision call foreman needs the original discovered IP address. Therefore this patch saves the ip and pass it when the provision call is done. Change-Id: I915ed42da851a60a6480f68735b005ab4c3f4a4b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1165668 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/HostProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVdsActionParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 5 files changed, 14 insertions(+), 6 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I915ed42da851a60a6480f68735b005ab4c3f4a4b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0