- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: OpenStack image provider
by juan.hernandez＠redhat.com 20 Nov '14

20 Nov '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: OpenStack image provider ...................................................................... restapi: OpenStack image provider This patch adds the resources for the OpenStack image providers. The representation of the resource will look like this: GET /openstackimageproviders <openstack_image_providers> <openstack_image_provider id="{provider:id}">...</openstack_image_provider> ... </openstack_image_providers> GET /openstackimageproviders/{provider:id} <openstack_image_provider id="{provider:id}"> <name>myprovider</name> <description>My provider</description> <url>http://glance.example.com</url> <requires_authentication>true</requires_authentication> <username>myuser</username> <password>mypass</password> <tenant_name>mytenant</tenant_name> <properties> <property> <name>prop1</name> <value>value1</myvalue> </property> <property> <name>prop2</name> <value>value2</myvalue> </property> </properties> </openstack_image_provider> The providers collection will support listing, getting, adding, and removing providers, with the usual methods. The provider resource will support getting, deleting and updating the provider, with the usual methods. In addition it will support the "testconnectivity" and "importcertificates" operations. The first is used to check the connectivity with the external provider: POST /openstackimageproviders/{provider:id}/testconnectivity <action/> The second is used to import the chain of certificates of the external provider: POST /openstackimageproviders/{provider:id}/importcertificates <action/> The third is used to import the image: POST /openstackimageproviders/{provider:id}/importcertificates <action/> The provider resource includes subcollections for certificates and images. For certificates it will look like this: GET /openstackimageproviders/{provider:id}/certificates <certificates> <certificate id="{host:id}">...</certificate> ... </certificates> GET /openstackimageproviders/{provider:id}/certificates/{certificate:id} <certificate id="{certificate:id}"> <subject>CN=glance.example.com</subject> <content>...</content> </certificate> For images: GET /openstackimageproviders/{provider:id}/images <openstack_images> <openstack_image id="{image:id}">...</openstack_image> ... </openstack_images> GET /openstackimageproviders/{provider:id}/images/{image:id} <openstack_image id="{image:id}"> <name>myimage</name> </openstack_image> The image resource supports the "import" operation: POST /openstackimageproviders/{provider:id}/images/{image:id}/import <action> <storagedomain> <name>mysd</name> </storagedomain> <cluster> <name>mycluster</name> </cluster> <import_as_template>false</import_as_template> </action> Change-Id: I77fca2208b18d54f9177ec8b0178768a6b815f20 Related-To: https://bugzilla.redhat.com/1132259 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenStackImageProviderResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenStackImageProvidersResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenStackImageResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/openstack/OpenStackImagesResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ApiRootLinksCreator.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImageProviderHelper.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImageProviderResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImageProvidersResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImageResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImagesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImageProviderResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImageProvidersResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImageResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackImagesResourceTest.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/openstack/OpenStackImageMapper.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/openstack/OpenStackImageProviderMapper.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/openstack/OpenStackImageMapperTest.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/openstack/OpenStackImageProviderMapperTest.java 25 files changed, 1,445 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77fca2208b18d54f9177ec8b0178768a6b815f20 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Null check on domain volume group when attempting t...
by tnisan＠redhat.com 20 Nov '14

20 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Null check on domain volume group when attempting to extend domain ...................................................................... restapi: Null check on domain volume group when attempting to extend domain When editing a block domain via REST, the LUN passed in the new entity can come either from the LUNs collection and in case it's empty from the volume group property and it's LUNs, added a null check on the volume group since when you do not provide LUNs it automatically falls back to volume group which might be null Change-Id: Ic762bdfb4c01d7b9344c94878d6662b9866a4090 Bug-Url: https://bugzilla.redhat.com/1115966 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic762bdfb4c01d7b9344c94878d6662b9866a4090 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: pep8
by sbonazzo＠redhat.com 20 Nov '14

20 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: pep8 ...................................................................... packaging: setup: pep8 Change-Id: I38c6c1827b3447f77a9add81e65d99ac6246096e Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/base/core/reconfigure.py 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38c6c1827b3447f77a9add81e65d99ac6246096e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: Add --reconfigure-optional-components
by sbonazzo＠redhat.com 20 Nov '14

20 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Add --reconfigure-optional-components ...................................................................... packaging: setup: Add --reconfigure-optional-components Change-Id: I4df3dd4f1966c30b42c9dd32d2df85a8b7cad387 Bug-Url: https://bugzilla.redhat.com/1072360 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/bin/ovirt-engine-setup M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-common/base/core/__init__.py A packaging/setup/plugins/ovirt-engine-common/base/core/reconfigure.py 4 files changed, 108 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35319 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4df3dd4f1966c30b42c9dd32d2df85a8b7cad387 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: setup: Allow to reconfigure
by sradco＠redhat.com 20 Nov '14

20 Nov '14

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: Allow to reconfigure ...................................................................... packaging: setup: Allow to reconfigure Requires http://gerrit.ovirt.org/35319 Change-Id: Ic5db441da86ac8e974142aea6ff2106ed63b6d72 Bug-Url: https://bugzilla.redhat.com/1072360 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/dwh/constants.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/35320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5db441da86ac8e974142aea6ff2106ed63b6d72 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: Allow to reconfigure
by sradco＠redhat.com 20 Nov '14

20 Nov '14

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: Allow to reconfigure ...................................................................... packaging: setup: Allow to reconfigure Requires http://gerrit.ovirt.org/35319 Change-Id: Id75dfe342536322856ee33522b96e5f17081db93 Bug-Url: https://bugzilla.redhat.com/1072360 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/reports/constants.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/35322 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id75dfe342536322856ee33522b96e5f17081db93 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: exceptions should be propagated in builtin ldap provider
by tnisan＠redhat.com 20 Nov '14

20 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: aaa: exceptions should be propagated in builtin ldap provider ...................................................................... aaa: exceptions should be propagated in builtin ldap provider All exceptions which are caught during the privileged action execution should be propagated and not swollowed. In addition, NegativeArraySizeException is handled as a severe exception, meaning there will be no attempt to try the next server if is caught Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1165721 Change-Id: Iafa1dcf67545e81a14981bb3c33e52a570684d72 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LDAPTemplateWrapper.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapSearchExceptionHandler.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/kerberos/AuthenticationResult.java 3 files changed, 7 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yair Zaslavsky: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35346 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafa1dcf67545e81a14981bb3c33e52a570684d72 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: make RemoveTemplateSnapshotCommand non-transactional
by oourfali＠redhat.com 20 Nov '14

20 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: make RemoveTemplateSnapshotCommand non-transactional ...................................................................... core: make RemoveTemplateSnapshotCommand non-transactional Change-Id: I71fa8364b24a1729bec3ea838b87b102040bad18 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveTemplateSnapshotCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71fa8364b24a1729bec3ea838b87b102040bad18 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Revert "core: Add foreign keys from async_tasks to command_e...
by yzaslavs＠redhat.com 20 Nov '14

20 Nov '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: Revert "core: Add foreign keys from async_tasks to command_entities" ...................................................................... Revert "core: Add foreign keys from async_tasks to command_entities" This reverts commit cff91e9211234966692c43a1dfc211858d72a2b7. Change-Id: I0bedf18c44368297da6201530ea9321496bd5be6 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/upgrade/03_06_0570_revert_async_tasks_fk.sql 4 files changed, 8 insertions(+), 16 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bedf18c44368297da6201530ea9321496bd5be6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: better handling of preexisting storage domain
by sbonazzo＠redhat.com 20 Nov '14

20 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: better handling of preexisting storage domain ...................................................................... packaging: setup: better handling of preexisting storage domain Better handling of preexisting storage domain validating it Change-Id: I622e0540ca21eea5ebddbfa4361bfb6537ca42d8 Bug-Url: https://bugzilla.redhat.com/1155637 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 1 file changed, 16 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/35351 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I622e0540ca21eea5ebddbfa4361bfb6537ca42d8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0