- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Simplify report redirect
by awels＠redhat.com 21 Nov '14

21 Nov '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Simplify report redirect ...................................................................... webadmin: Simplify report redirect - Reports had several redirect servlet instances, one for each type of interaction with the reporting server. The difference was parameters defined in the configuration. This patch passes the parameters to the UI using the host page instead of new servlets in web.xml. - Added parsing method to HtmlParameters to preserve parameters on the url. - Fixed SSO issue where if a user was already logged in it would provide the wrong SSO token and report integration would fail. Change-Id: Ic4718bf7f734ea72d2494fc463a87cb7675df0c4 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/RedirectServlet.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServlet.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/utils/FrontendUrlUtils.java M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServletTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/HtmlParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportsUrls.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportsListModel.java 12 files changed, 130 insertions(+), 30 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33550 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4718bf7f734ea72d2494fc463a87cb7675df0c4 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.5]: spec: enable vdsm-reg to autostart
by dougsland＠redhat.com 21 Nov '14

21 Nov '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: spec: enable vdsm-reg to autostart ...................................................................... spec: enable vdsm-reg to autostart This patch enables vdsm-reg to autostart for systemd schema or sysv. Change-Id: I5aad8014ad37838ceb1ab467380fbe9ffc62ae0b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1152916 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35435 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5aad8014ad37838ceb1ab467380fbe9ffc62ae0b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-node-plugin-vdsm[master]: spec: enable vdsm-reg to autostart
by dougsland＠redhat.com 21 Nov '14

21 Nov '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: spec: enable vdsm-reg to autostart ...................................................................... spec: enable vdsm-reg to autostart This patch enables vdsm-reg to autostart for systemd schema or sysv. Change-Id: I5aad8014ad37838ceb1ab467380fbe9ffc62ae0b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1152916 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5aad8014ad37838ceb1ab467380fbe9ffc62ae0b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in mom[master]: Improve the way we declare and use (optional) collector fields
by alitke＠redhat.com 21 Nov '14

21 Nov '14

Adam Litke has submitted this change and it was merged. Change subject: Improve the way we declare and use (optional) collector fields ...................................................................... Improve the way we declare and use (optional) collector fields Entity and Monitor objects were updated to work with optional fields better. Both were also updated to throw an error when an access to non-declared field is attempted. It is now also possible to specify default value for field in Entity.Stat to make the optional fields more usable in the policy. Guest Memory collector field declaration was changed to explicitly state the collected fields. This should reduce the confusion in what fields are supposed to be collected in libvirt vs. in vdsm environment. It is my opinion that the field declaration is part of the collector's metadata and should be explicitly specified rather than inferred. New Guest Memory collector (GuestMemoryOptional) that treats all fields as optional is added as an example. It also helps when a policy should support more than ballooning and is supposed to work (with ballooning ignored) even when no guest agent is available and internal memory stats are missing. This should keep us compatible with vdsm who has GuestMemory in mom.conf and give us the option to use the new collector with updated ballooning policy in the future vdsm releases. Change-Id: I631056568b5a69e18f6ed02730c41ab59f460aad Signed-off-by: Roy Golan <rgolan(a)redhat.com> Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: http://gerrit.ovirt.org/34528 Reviewed-by: Adam Litke <alitke(a)redhat.com> --- M mom/Collectors/GuestMemory.py A mom/Collectors/GuestMemoryOptional.py M mom/Collectors/Makefile.am M mom/Entity.py M mom/Monitor.py 5 files changed, 46 insertions(+), 9 deletions(-) Approvals: Adam Litke: Looks good to me, approved Martin Sivák: Verified -- To view, visit http://gerrit.ovirt.org/34528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I631056568b5a69e18f6ed02730c41ab59f460aad Gerrit-PatchSet: 10 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: copy instance type fields to the VM
by juan.hernandez＠redhat.com 21 Nov '14

21 Nov '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: copy instance type fields to the VM ...................................................................... restapi: copy instance type fields to the VM As a sonsequence of the https://bugzilla.redhat.com/1149663 the instance type fields are not copyed to the VM on server anymore and the frontends (WA/UP/REST) need to take care of it. More specifically it works like this: If only the instance type is selected, it has to copy it's properties to the newly created VM (on VM level this can be overridden) If both the template and the instance type is selected, the instance type overrides the template. When copying the parameters from instance type to the VM, only the ones which are supported on the target cluster/OS are taken into account. Change-Id: Id8ff7a39fe74c73d8984fb34169b69649dab7c15 Bug-Url: https://bugzilla.redhat.com/1149663 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/VmHelper.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 4 files changed, 207 insertions(+), 121 deletions(-) Approvals: Tomas Jelinek: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8ff7a39fe74c73d8984fb34169b69649dab7c15 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: jsonrpc: version bump
by piotr.kliczewski＠gmail.com 21 Nov '14

21 Nov '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: jsonrpc: version bump ...................................................................... jsonrpc: version bump New version of jsonrpc with jackson parsing flags. Change-Id: I2a3fdf2835c49c3555796e9d4f26b3cc2aec96bc Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1155146 --- M ovirt-engine.spec.in M pom.xml 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35418 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a3fdf2835c49c3555796e9d4f26b3cc2aec96bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: userportal, webadmin: Multi view table columns inconsistent
by awels＠redhat.com 21 Nov '14

21 Nov '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal,webadmin: Multi view table columns inconsistent ...................................................................... userportal,webadmin: Multi view table columns inconsistent - since a463914769e87b5fb55999bcd25d56167b8e3d16 columns available in all view would not get removed and would always end up at the front of the grid even if other columns that can disappear were in front of them. This patch fixes that problem. Change-Id: I143894af611f8364da943433e81378690adcb0e8 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1157215 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java 1 file changed, 21 insertions(+), 37 deletions(-) Approvals: Alexander Wels: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I143894af611f8364da943433e81378690adcb0e8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: refresh button wrapping
by awels＠redhat.com 21 Nov '14

21 Nov '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: refresh button wrapping ...................................................................... webadmin: refresh button wrapping - Fixed refresh button wrapping when there is not enough room to fit all the buttons. Change-Id: I1fc13aea7950ab3f4965131dcc2b32e4ea837192 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1163929 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35171 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fc13aea7950ab3f4965131dcc2b32e4ea837192 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix exception on VM status column
by awels＠redhat.com 21 Nov '14

21 Nov '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Fix exception on VM status column ...................................................................... webadmin: Fix exception on VM status column - When hovering over or clicking on the status column in the VM main tab the console would display an exception. This patch solves that. This is the right status column Change-Id: I1d5cfaa291fe26b1a7439a8a71e8e04d8dc539b0 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StatusCompositeCellWithElementId.java 1 file changed, 13 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Verified Greg Sheremeta: Looks good to me, but someone else must approve Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d5cfaa291fe26b1a7439a8a71e8e04d8dc539b0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-host-deploy[master]: gluster: start glusterpmd service after reboot.
by Alon Bar-Lev 21 Nov '14

21 Nov '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: gluster: start glusterpmd service after reboot. ...................................................................... gluster: start glusterpmd service after reboot. Added start of glusterpmd service after reboot. Change-Id: I6b4d631b23250b513b42ff0509e8d230b1cb3d9b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138108 Signed-off-by: ndarshan <dnarayan(a)redhat.com> --- M ChangeLog M src/plugins/ovirt-host-deploy/gluster/glusterpmd.py 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, approved Darshan N: Verified -- To view, visit http://gerrit.ovirt.org/35415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b4d631b23250b513b42ff0509e8d230b1cb3d9b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0