- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Enhance the xml-rpc Long support to deal with Maps a...
by tnisan＠redhat.com 20 Nov '14

20 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Enhance the xml-rpc Long support to deal with Maps and Lists ...................................................................... engine: Enhance the xml-rpc Long support to deal with Maps and Lists It is common to have a Long value in a sub-map of an xml-rpc argument. The current implementation does not deal with this case. The ideal solution to this would be to instruct the marshaller to do this. Unfortunately that is not possible and we have to work around that limitation. Change-Id: I5a5933a68f937c4734b547c173188e88bd7b9464 Signed-off-by: Martin Sivák <msivak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java 1 file changed, 32 insertions(+), 5 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Martin Sivák: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a5933a68f937c4734b547c173188e88bd7b9464 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Calculate disk alias on add disk prior to setting the ...
by tnisan＠redhat.com 20 Nov '14

20 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Calculate disk alias on add disk prior to setting the job message ...................................................................... core: Calculate disk alias on add disk prior to setting the job message The disk alias to be created is calculated during the execution phase so if the user hasn't specified one, during the job creation the alias will not appear in the task description, the setting of the alias (whether it's default or the one the user supplied) is now done in the job message calculation phase Change-Id: Idee55da516bca986993e973dffc9058187e12a34 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1143967 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idee55da516bca986993e973dffc9058187e12a34 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: Fixing build for fedora 21
by oourfali＠redhat.com 20 Nov '14

20 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: Fixing build for fedora 21 ...................................................................... aaa: Fixing build for fedora 21 Fixes InitializingBeand and DisposableBean not begin not recognized Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)rehdat.com> Change-Id: Id3e9d6366a34ff6315833180940a7275804a1519 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/pom.xml 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35341 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3e9d6366a34ff6315833180940a7275804a1519 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: ui: Fixing popupHostView css style
by oourfali＠redhat.com 20 Nov '14

20 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: ui: Fixing popupHostView css style ...................................................................... ui: Fixing popupHostView css style Change-Id: Icbd0177f9758308a39e38b5f57e8c2e3bc8ef55d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1165670 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Yaniv Bronhaim: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbd0177f9758308a39e38b5f57e8c2e3bc8ef55d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: Fix search button logic
by oourfali＠redhat.com 20 Nov '14

20 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: ui: Fix search button logic ...................................................................... ui: Fix search button logic Commit 60331c40535c95950274984d89177643df5686db broke the search button logic. This patch returns the same refresh logic that was next to the current changes. Change-Id: Ia86fa287a050e030d28ab96eeecfb888dd1cb22b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1165669 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java 3 files changed, 37 insertions(+), 2 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35325 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia86fa287a050e030d28ab96eeecfb888dd1cb22b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Remove suffix from mgmt address taken from the ComputerResou...
by oourfali＠redhat.com 20 Nov '14

20 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: Remove suffix from mgmt address taken from the ComputerResource conf ...................................................................... Remove suffix from mgmt address taken from the ComputerResource conf This parameter is used by ovirt-node and should include only fqdn or ip4 addr with port number or without. For example 10.35.1.85:8080 Change-Id: I5a40ca0b4870d1955b01d18c88df467b8da35fc4 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/34859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a40ca0b4870d1955b01d18c88df467b8da35fc4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: fixing addHost form issues when playing with using host ...
by oourfali＠redhat.com 20 Nov '14

20 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: ui: fixing addHost form issues when playing with using host provider ...................................................................... ui: fixing addHost form issues when playing with using host provider Apparently hiding the host provider form was buggy. In this patch we fix the fields cleaning and the visibility of the provider parameters. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1165670 Change-Id: I700ec281a1bd1617d0168d59c8daef5b5bcf4f6b Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java 3 files changed, 12 insertions(+), 18 deletions(-) Approvals: Yaniv Bronhaim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I700ec281a1bd1617d0168d59c8daef5b5bcf4f6b Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: core: Allow automation of first interactions
by sbonazzo＠redhat.com 20 Nov '14

20 Nov '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: core: Allow automation of first interactions ...................................................................... core: Allow automation of first interactions Move questions to stage setup, add to answer file. Change-Id: Iffb05e4a520aa8f8f8a2d7f36e60aee556360302 Bug-Url: https://bugzilla.redhat.com/1101285 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/core/misc.py M src/plugins/ovirt-hosted-engine-setup/core/shell.py 3 files changed, 38 insertions(+), 11 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/35302 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffb05e4a520aa8f8f8a2d7f36e60aee556360302 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: revert : core: Add foreign keys from async_tasks to command_...
by oourfali＠redhat.com 20 Nov '14

20 Nov '14

Oved Ourfali has submitted this change and it was merged. Change subject: revert : core: Add foreign keys from async_tasks to command_entities ...................................................................... revert : core: Add foreign keys from async_tasks to command_entities Bare in mind, this is not a pure git revert as DB scripts cannot be reverted (a script that performs "logical revert" should be added) Change-Id: Icf54510178460095b09f529b2c5d26eee9efdeec Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/upgrade/03_05_1180_revert_add_foreign_keys_tk_async_tasks_table.sql 4 files changed, 8 insertions(+), 16 deletions(-) Approvals: Oved Ourfali: Looks good to me, approved Yair Zaslavsky: Verified -- To view, visit http://gerrit.ovirt.org/35380 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf54510178460095b09f529b2c5d26eee9efdeec Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Calculate disk alias on add disk prior to setting the ...
by tnisan＠redhat.com 19 Nov '14

19 Nov '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Calculate disk alias on add disk prior to setting the job message ...................................................................... core: Calculate disk alias on add disk prior to setting the job message The disk alias to be created is calculated during the execution phase so if the user hasn't specified one, during the job creation the alias will not appear in the task description, the setting of the alias (whether it's default or the one the user supplied) is now done in the job message calculation phase Change-Id: Idee55da516bca986993e973dffc9058187e12a34 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1143967 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idee55da516bca986993e973dffc9058187e12a34 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0