- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: skip non-responding hosts in proxy selection.
by tnisan＠redhat.com 30 Sep '14

30 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: skip non-responding hosts in proxy selection. ...................................................................... core: skip non-responding hosts in proxy selection. non-responding host is selected as a proxy for fencing operations This patch adds the host NonResponsive status as an illegal status for the proxy selection algorithm. Hosts that are in NonResponsive state have communication problems that prevents them from being proxy candidates. Change-Id: Idaa861b32b20cca43a7fe41f318c3e8bcec4c95d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145321 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idaa861b32b20cca43a7fe41f318c3e8bcec4c95d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: frontend: Fix SPICE-ActiveX upgrade issues
by tnisan＠redhat.com 30 Sep '14

30 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Fix SPICE-ActiveX upgrade issues ...................................................................... frontend: Fix SPICE-ActiveX upgrade issues This patch basically reverts previous IE 11 workaround: Syntax error (missing '+' to concatenate strings) in SpicePluginImpl caused silent fail of activex plugin in IE. This patch addresses this. This patch also removes IE11 workaround from SpicePluginImpl (i.e. dummy <PARAM NAME="SecurePort" VALUE="0">). Current SPICE ActiveX plugin already works on IE 11 without this workaround (moreover - it crashes with it!). Change-Id: I884eafed9985991f5f810378792fb45e00837a5e Bug-Url: https://bugzilla.redhat.com/1081533 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/33488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I884eafed9985991f5f810378792fb45e00837a5e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Fix SPICE-ActiveX upgrade issues
by tjelinek＠redhat.com 30 Sep '14

30 Sep '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Fix SPICE-ActiveX upgrade issues ...................................................................... frontend: Fix SPICE-ActiveX upgrade issues This patch basically reverts previous IE 11 workaround: Syntax error (missing '+' to concatenate strings) in SpicePluginImpl caused silent fail of activex plugin in IE. This patch addresses this. This patch also removes IE11 workaround from SpicePluginImpl (i.e. dummy <PARAM NAME="SecurePort" VALUE="0">). Current SPICE ActiveX plugin already works on IE 11 without this workaround (moreover - it crashes with it!). Change-Id: I884eafed9985991f5f810378792fb45e00837a5e Bug-Url: https://bugzilla.redhat.com/1081533 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/33487 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I884eafed9985991f5f810378792fb45e00837a5e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: notifier: add support for snmpv6 in SNMP_MANAGERS.
by oourfali＠redhat.com 30 Sep '14

30 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: notifier: add support for snmpv6 in SNMP_MANAGERS. ...................................................................... notifier: add support for snmpv6 in SNMP_MANAGERS. Change-Id: I9a21038928b7e553feefb9ab7669eac588c1c93c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073498 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java A backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/transport/snmp/ProfileTest.java M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in 3 files changed, 60 insertions(+), 4 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a21038928b7e553feefb9ab7669eac588c1c93c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core : JBoss Servlet Exception at Page Loads :: no protocol:...
by oourfali＠redhat.com 30 Sep '14

30 Sep '14

Oved Ourfali has submitted this change and it was merged. Change subject: core : JBoss Servlet Exception at Page Loads :: no protocol: /ovirt/reports-interface ...................................................................... core : JBoss Servlet Exception at Page Loads :: no protocol: /ovirt/reports-interface When reports server is not installed and the reports base url is empty the redirect url does not have a protocal associated with it. So the url "/ovirt/reports-interface" throws an exception in server logs Change-Id: I485dff572fe8ce1ffb61d77b5032b540735f93f2 Bug-Url: https://bugzilla.redhat.com/1142748 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/ProxyServlet.java 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I485dff572fe8ce1ffb61d77b5032b540735f93f2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: ovirt-reports: Reports should use current sessionID
by ydary＠redhat.com 30 Sep '14

30 Sep '14

Yaniv Dary has submitted this change and it was merged. Change subject: ovirt-reports: Reports should use current sessionID ...................................................................... ovirt-reports: Reports should use current sessionID Reports should use the new sessionID to get session user from engine if the sessionID has changed Change-Id: I2e7a83b80144696639228889494a929fe4480d0a Bug-Url: https://bugzilla.redhat.com/1116851 Signed-off-by: Ravi Nori <rnori(a)redhat.com> Signed-off-by: Yaniv Dary <ydary(a)redhat.com> (cherry picked from commit 8a7a818c0dbb53e7c499002e662c948beeffa85c) --- M ovirt-engine-reports/EngineAuthentication/src/main/java/org/ovirt/authentication/EngineSimplePreAuthFilter.java M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py 2 files changed, 11 insertions(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33512 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e7a83b80144696639228889494a929fe4480d0a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: packaging: setup: pep8 fixes
by ydary＠redhat.com 30 Sep '14

30 Sep '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: pep8 fixes ...................................................................... packaging: setup: pep8 fixes Change-Id: I46d8bd70a852b0551caf7908e775b9cc161d8556 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 7ca6461330a42c558700030ae8871c368babb9e5) --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/apache.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/pki/jboss.py 3 files changed, 6 insertions(+), 13 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46d8bd70a852b0551caf7908e775b9cc161d8556 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: ovirt-reports: Reports should use current sessionID
by ydary＠redhat.com 30 Sep '14

30 Sep '14

Yaniv Dary has submitted this change and it was merged. Change subject: ovirt-reports: Reports should use current sessionID ...................................................................... ovirt-reports: Reports should use current sessionID Reports should use the new sessionID to get session user from engine if the sessionID has changed Change-Id: I2e7a83b80144696639228889494a929fe4480d0a Bug-Url: https://bugzilla.redhat.com/1116851 Signed-off-by: Ravi Nori <rnori(a)redhat.com> Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M ovirt-engine-reports/EngineAuthentication/src/main/java/org/ovirt/authentication/EngineSimplePreAuthFilter.java M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py 2 files changed, 11 insertions(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33307 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e7a83b80144696639228889494a929fe4480d0a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: ImportVmTemplateCommand storage allocation
by tnisan＠redhat.com 29 Sep '14

29 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: ImportVmTemplateCommand storage allocation ...................................................................... core: ImportVmTemplateCommand storage allocation This patch is a part of a series of patches, adding storage allocation validations to the system when they're missing, and replacing old verification usage with unified, new, correct and tested verification. This patch did this for ImportVmTemplateCommand, using only existing validations. Removing old verification in this command resulted in unused old validation and validation aids, which were also removed in this patch. Added tests to MoveOrCopyTemplateCommand.validateSpaceRequirements() in MoveMoveOrCopyTemplateCommandTest. Change-Id: I6ffc5c00905bb03c9cb3cbffa481e78c9b0ab87a Bug-Url: https://bugzilla.redhat.com/1136721 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmTemplateCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommandTest.java 5 files changed, 95 insertions(+), 65 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/33478 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ffc5c00905bb03c9cb3cbffa481e78c9b0ab87a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Use Collections instead of Lists
by tnisan＠redhat.com 29 Sep '14

29 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Use Collections instead of Lists ...................................................................... core: Use Collections instead of Lists In storage allocation-related methods, use Collections instead if lists when possible. Further validations will be on top of this, specifically storage allocation validation in ImportVmTemplateCommand, hence the bz url bellow. Change-Id: Ic89752086a68ca2f87bc58cefc33d5373c7f8eef Bug-Url: https://bugzilla.redhat.com/1136721 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidator.java 2 files changed, 17 insertions(+), 17 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/33477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic89752086a68ca2f87bc58cefc33d5373c7f8eef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0