- Engine-commits - oVirt List Archives

Change in ovirt-engine-cli[master]: cli: Calculate singulars and plurals correctly
by juan.hernandez＠redhat.com 26 Sep '14

26 Sep '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Calculate singulars and plurals correctly ...................................................................... cli: Calculate singulars and plurals correctly Currently when we need to calculate singulars and plurals we just remove or add a final "s". This doesn't work for names like "SchedulingPolicy" and "SchedulingPolicies". This patch improves the calculations so that they will work correctly for this type of names. Change-Id: I4c7849dadd1161bfd435c7ae79d196c08b3e7e69 Bug-Url: https://bugzilla.redhat.com/1144110 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtcli/command/add.py M src/ovirtcli/command/command.py M src/ovirtcli/utils/typehelper.py 3 files changed, 28 insertions(+), 23 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c7849dadd1161bfd435c7ae79d196c08b3e7e69 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.5]: packaging: setup: Making error messages more verbose
by sbonazzo＠redhat.com 26 Sep '14

26 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Making error messages more verbose ...................................................................... packaging: setup: Making error messages more verbose Making error messages a bit more verbose to help the user pointing out possible problems. Change-Id: I0a722d37420f4a3c9b0af09dc483cc9d73b4faff Bug-Url: https://bugzilla.redhat.com/1144836 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/__main__.py 1 file changed, 29 insertions(+), 11 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/33374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a722d37420f4a3c9b0af09dc483cc9d73b4faff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.5 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-image-uploader[ovirt-image-uploader-3.5]: packaging: setup: Making error messages more verbose
by sbonazzo＠redhat.com 26 Sep '14

26 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Making error messages more verbose ...................................................................... packaging: setup: Making error messages more verbose Making error messages a bit more verbose to help the user pointing out possible problems. Change-Id: I7b7201b23adbb0ee7c452f9a936644b2b7b52ac4 Bug-Url: https://bugzilla.redhat.com/1146070 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit 9f2a96566bb227d19c87c31946272c7bfc90cc61) --- M src/__main__.py 1 file changed, 32 insertions(+), 11 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit http://gerrit.ovirt.org/33373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b7201b23adbb0ee7c452f9a936644b2b7b52ac4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: ovirt-image-uploader-3.5 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: fix alignment in New Cluster dialog / Scheduling p...
by piotr.kliczewski＠gmail.com 25 Sep '14

25 Sep '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: fix alignment in New Cluster dialog / Scheduling policy ...................................................................... webadmin: fix alignment in New Cluster dialog / Scheduling policy New Cluster dialog / Scheduling policy tab had alignment and spacing issues. Fixed. Change-Id: I6dfac25cb6684184ab532302f1836ccd85dd5c9b Bug-Url: https://bugzilla.redhat.com/1123319 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.ui.xml 1 file changed, 13 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/33377 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6dfac25cb6684184ab532302f1836ccd85dd5c9b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: tweak info icons in cluster popup
by piotr.kliczewski＠gmail.com 25 Sep '14

25 Sep '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: tweak info icons in cluster popup ...................................................................... webadmin: tweak info icons in cluster popup Tweak info icon location and spacing in cluster popup. Change-Id: I61c4120ac6869b27d9faa2a3a0481d768911a5bb Bug-Url: https://bugzilla.redhat.com/1123319 Bug-Url: https://bugzilla.redhat.com/1096845 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 2 files changed, 5 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/33371 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61c4120ac6869b27d9faa2a3a0481d768911a5bb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: auto reselect fix
by awels＠redhat.com 25 Sep '14

25 Sep '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal,webadmin: auto reselect fix ...................................................................... userportal,webadmin: auto reselect fix - When only one row was visible in the main grid the application would auto reselect the row even after the user had manually deselected the row. This patch fixes this so as long as the data is not manually refresh (either the button or selecting another tab). It won't reselect the row. Change-Id: Ie393d83ad3a6ac82af90420c25fad811194eae1e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1140237 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Verified Greg Sheremeta: Looks good to me, but someone else must approve Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33346 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie393d83ad3a6ac82af90420c25fad811194eae1e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix alignment in New Cluster dialog / Scheduling p...
by awels＠redhat.com 25 Sep '14

25 Sep '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fix alignment in New Cluster dialog / Scheduling policy ...................................................................... webadmin: fix alignment in New Cluster dialog / Scheduling policy New Cluster dialog / Scheduling policy tab had alignment and spacing issues. Fixed. Change-Id: I6dfac25cb6684184ab532302f1836ccd85dd5c9b Bug-Url: https://bugzilla.redhat.com/1123319 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.ui.xml 1 file changed, 13 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/33225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6dfac25cb6684184ab532302f1836ccd85dd5c9b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: jobs: add ovirt-engine-reports-3.5 builder
by dcaroest＠redhat.com 25 Sep '14

25 Sep '14

David Caro has submitted this change and it was merged. Change subject: jobs: add ovirt-engine-reports-3.5 builder ...................................................................... jobs: add ovirt-engine-reports-3.5 builder Change-Id: I5d40ea33c1c19a736a53173364c7e592d8e1cb92 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/yaml/jobs/ovirt-reports/ovirt-reports_create-rpms.yaml 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified David Caro: Verified; Looks good to me, approved Yaniv Dary: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d40ea33c1c19a736a53173364c7e592d8e1cb92 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: jobs: vdsm_master_create-rpms_merged
by dcaroest＠redhat.com 25 Sep '14

25 Sep '14

David Caro has submitted this change and it was merged. Change subject: jobs: vdsm_master_create-rpms_merged ...................................................................... jobs: vdsm_master_create-rpms_merged yaml coding of the existing job vdsm_master_create-rpms_merged moved to mock build. Had to add some env variables, extra packages, and modify a bit the shell scripts to be able to build vdsm without running the tests. Change-Id: I0fe83d797188662d57a2a4b1f7bf7122f957ace1 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/shell-scripts/build_mock_srcrpm.sh M jobs/confs/shell-scripts/build_mock_srcrpm_releng.sh M jobs/confs/shell-scripts/mock_build_onlyrpm.sh M jobs/confs/shell-scripts/mock_install.sh R jobs/confs/yaml/builders/mock_rpm.yaml M jobs/confs/yaml/jobs/ioprocess/ioprocess_create-rpms.yaml A jobs/confs/yaml/jobs/vdsm/vdsm_create-rpms.yaml M jobs/confs/yaml/templates/create-rpms_mock.yaml 8 files changed, 212 insertions(+), 58 deletions(-) Approvals: David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32512 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0fe83d797188662d57a2a4b1f7bf7122f957ace1 Gerrit-PatchSet: 8 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: tweak info icons in cluster popup
by awels＠redhat.com 25 Sep '14

25 Sep '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: tweak info icons in cluster popup ...................................................................... webadmin: tweak info icons in cluster popup Tweak info icon location and spacing in cluster popup. Change-Id: I61c4120ac6869b27d9faa2a3a0481d768911a5bb Bug-Url: https://bugzilla.redhat.com/1123319 Bug-Url: https://bugzilla.redhat.com/1096845 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 2 files changed, 5 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/33351 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61c4120ac6869b27d9faa2a3a0481d768911a5bb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0