- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: engine: Unassigned log type should not be logged
by tnisan＠redhat.com 28 Sep '14

28 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Unassigned log type should not be logged ...................................................................... engine: Unassigned log type should not be logged The Unassigned log type is used to ignore a logging of an event. Hence, it should not appear in the resource bundle. This patch, back-ported from master branch resolves the reported issue. Change-Id: I4dad0139cc65fe3c90f7c59cda5416db1a83c569 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1142859 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Downstream-Only --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33430 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4dad0139cc65fe3c90f7c59cda5416db1a83c569 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Extract code common for cluster network attach/update
by lvernia＠redhat.com 28 Sep '14

28 Sep '14

Lior Vernia has submitted this change and it was merged. Change subject: engine: Extract code common for cluster network attach/update ...................................................................... engine: Extract code common for cluster network attach/update Validation is very similar in those two commands, so extracted the common code to a superclass both extend. Change-Id: I3869fad7c00313626587ba28f867801795061f69 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkOnClusterCommand.java 3 files changed, 62 insertions(+), 71 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/32905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3869fad7c00313626587ba28f867801795061f69 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[master]: core: filetransaction: restore default selinux default attri...
by Alon Bar-Lev 28 Sep '14

28 Sep '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: filetransaction: restore default selinux default attributes ...................................................................... core: filetransaction: restore default selinux default attributes restore default selinux attributes for modified files or created directories. this will override sysadmin local changes (if exists), but will enable predictable outcome. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1146689 Change-Id: I40621911c4a3cced2b2c552ee1de2696d3a8c6c7 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/otopi/filetransaction.py M src/plugins/otopi/network/ssh.py 3 files changed, 57 insertions(+), 39 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33427 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40621911c4a3cced2b2c552ee1de2696d3a8c6c7 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: don't use hotplug when updating instance type
by ofrenkel＠redhat.com 28 Sep '14

28 Sep '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: don't use hotplug when updating instance type ...................................................................... core: don't use hotplug when updating instance type when updating vms connected to an instance type, if using hotplug (for cpu) and it fails, the change is lost. so always use "apply later" so the changes would anyway apply when the vm is down. Change-Id: I8f5b494a91ef3328fb2631da922c8a3cd582f67b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1136372 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f5b494a91ef3328fb2631da922c8a3cd582f67b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: import vm dialog - fix subtabs refresh
by tnisan＠redhat.com 28 Sep '14

28 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: import vm dialog - fix subtabs refresh ...................................................................... webadmin: import vm dialog - fix subtabs refresh As done in 'ImportVmModel -> initDetailModels', VmImportDiskListModel/VmImportInterfaceListModel should also override 'setEntity' to get the VM object rather than the wrapping ImportVmData EntityModel (same applies for TemplateImport models) Change-Id: Iab5f6f522d007dd88e8d6a14f9ab66f37a1adae4 Bug-Url: https://bugzilla.redhat.com/1141693 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateImportDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateImportInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmImportDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmImportInterfaceListModel.java 4 files changed, 24 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/33295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab5f6f522d007dd88e8d6a14f9ab66f37a1adae4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix typo in error message
by gchaplik＠redhat.com 28 Sep '14

28 Sep '14

Gilad Chaplik has submitted this change and it was merged. Change subject: core: fix typo in error message ...................................................................... core: fix typo in error message Capital letter for profile error message. Change-Id: I4f60451e00c27470ce343c485761c7f2561d1b58 Bug-Url: https://bugzilla.redhat.com/1142887 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33420 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f60451e00c27470ce343c485761c7f2561d1b58 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: add missing profiles audit log translations
by gchaplik＠redhat.com 28 Sep '14

28 Sep '14

Gilad Chaplik has submitted this change and it was merged. Change subject: core: add missing profiles audit log translations ...................................................................... core: add missing profiles audit log translations Change-Id: Ib52db560164f9aa7773bcf96ca7d3f185a58da6b Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/ProfileCommandBase.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 2 files changed, 19 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib52db560164f9aa7773bcf96ca7d3f185a58da6b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Use enum name to search providers
by tnisan＠redhat.com 28 Sep '14

28 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Use enum name to search providers ...................................................................... core: Use enum name to search providers Currently we build search queries for providers using the numeric value of the type, and comparing it to the "providers.provider_type" database column. But this column stores the name of the enum, not the numeric value. This patch changes the autocompleter so that it uses the name. Change-Id: I4822be2cfd57c093d4fdf11f0410c055faea8be2 Bug-Url: https://bugzilla.redhat.com/1145247 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit e9d780841b6a6c984338739d010ff8cc90b2f5ea) --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ProviderConditionFieldAutoCompleter.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified Lior Vernia: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4822be2cfd57c093d4fdf11f0410c055faea8be2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Formatting onImport method on StorageListModel
by tnisan＠redhat.com 28 Sep '14

28 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Formatting onImport method on StorageListModel ...................................................................... webadmin: Formatting onImport method on StorageListModel 1. Using formatter on onImport method 2. put bracket on EOL instead in a new line. Change-Id: I6713974c94808b414282d21fb71df67b514faa8c Bug-Url: https://bugzilla.redhat.com/1136750 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 13 insertions(+), 22 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33253 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6713974c94808b414282d21fb71df67b514faa8c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Adding support to import GlusterFS
by tnisan＠redhat.com 28 Sep '14

28 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Adding support to import GlusterFS ...................................................................... webadmin: Adding support to import GlusterFS Adding support to import GlusterFS Change-Id: Ic66b535004d40f28c4b703f5d5899253cd2616ac Bug-Url: https://bugzilla.redhat.com/1136750 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/33254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic66b535004d40f28c4b703f5d5899253cd2616ac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0