- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: extmgr: add nested exception message into new exception
by tnisan＠redhat.com 28 Sep '14

28 Sep '14

Tal Nisan has submitted this change and it was merged. Change subject: extmgr: add nested exception message into new exception ...................................................................... extmgr: add nested exception message into new exception this enables to see helpful errors while not in debug mode. Topic: AAA Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720 Change-Id: If321921682d4de599db202956babb1af8a7b315b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If321921682d4de599db202956babb1af8a7b315b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Use Collections instead of Lists
by amureini＠redhat.com 26 Sep '14

26 Sep '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Use Collections instead of Lists ...................................................................... core: Use Collections instead of Lists In storage allocation-related methods, use Collections instead if lists when possible. Further validations will be on top of this, specifically storage allocation validation in ImportVmTemplateCommand, hence the bz url bellow. Change-Id: Ic89752086a68ca2f87bc58cefc33d5373c7f8eef Related-To: https://bugzilla.redhat.com/1136721 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidator.java 2 files changed, 17 insertions(+), 17 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/33043 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic89752086a68ca2f87bc58cefc33d5373c7f8eef Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: cleanups in MoveOrCopyTemplateCommand
by amureini＠redhat.com 26 Sep '14

26 Sep '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: cleanups in MoveOrCopyTemplateCommand ...................................................................... core: cleanups in MoveOrCopyTemplateCommand Fix typo, removed unused method and redundant empty line. Change-Id: Icb15c84d10d301bb593ad9930e4b1b56b6ab7af5 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java 1 file changed, 1 insertion(+), 18 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/32972 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb15c84d10d301bb593ad9930e4b1b56b6ab7af5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: Error dialogs don't close on enter
by awels＠redhat.com 26 Sep '14

26 Sep '14

Alexander Wels has submitted this change and it was merged. Change subject: userportal,webadmin: Error dialogs don't close on enter ...................................................................... userportal,webadmin: Error dialogs don't close on enter - When an error dialog popped up the enter key would not close the dialog. This patch fixes the enter key to close the dialog as expected. Change-Id: Iefd72a9de81a64fd7f194252abd46a646bdcc6c5 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1143973 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ErrorPopupPresenterWidget.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefd72a9de81a64fd7f194252abd46a646bdcc6c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: extmgr: add nested exception message into new exception
by yzaslavs＠redhat.com 26 Sep '14

26 Sep '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: extmgr: add nested exception message into new exception ...................................................................... extmgr: add nested exception message into new exception this enables to see helpful errors while not in debug mode. Topic: AAA Change-Id: If321921682d4de599db202956babb1af8a7b315b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If321921682d4de599db202956babb1af8a7b315b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: errors in javadoc
by yzaslavs＠redhat.com 26 Sep '14

26 Sep '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: errors in javadoc ...................................................................... core: errors in javadoc removed empty parts in javadoc fixed bad links, parameter names in javadoc Change-Id: I334d7080989d679fa27082547f1a5950fb530645 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/BeanType.java 2 files changed, 29 insertions(+), 41 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I334d7080989d679fa27082547f1a5950fb530645 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-release[master]: Revert "build: ovirt-release35-001"
by sbonazzo＠redhat.com 26 Sep '14

26 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Revert "build: ovirt-release35-001" ...................................................................... Revert "build: ovirt-release35-001" This reverts commit f18aa6d50f4ddf5779430a30a1f75f618cf303f3. Change-Id: Ifc47514e81a03e6de6ef9a7c02acd911971ffe6f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-release-3.5/configure.ac M ovirt-release-3.5/ovirt-release35.spec.in 2 files changed, 2 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc47514e81a03e6de6ef9a7c02acd911971ffe6f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-release[master]: build: ovirt-release35-001
by sbonazzo＠redhat.com 26 Sep '14

26 Sep '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-release35-001 ...................................................................... build: ovirt-release35-001 Change-Id: Iaba26133ef12e95f0f1e141b1eee5237a26a32b2 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-release-3.5/configure.ac M ovirt-release-3.5/ovirt-release35.spec.in 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaba26133ef12e95f0f1e141b1eee5237a26a32b2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[master]: cli: Update RPM changelog
by juan.hernandez＠redhat.com 26 Sep '14

26 Sep '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Update RPM changelog ...................................................................... cli: Update RPM changelog This patch updates the changelog of the RPM spec, copying the entries from the 3.5 branch. Change-Id: Ibe4155702f9ddd6ddb02c214b9c7d7fead15fffb Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M ovirt-engine-cli.spec.in 2 files changed, 39 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33391 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe4155702f9ddd6ddb02c214b9c7d7fead15fffb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Added ci-tools repo to get correct pep8 building vdsm
by dcaroest＠redhat.com 26 Sep '14

26 Sep '14

David Caro has submitted this change and it was merged. Change subject: Added ci-tools repo to get correct pep8 building vdsm ...................................................................... Added ci-tools repo to get correct pep8 building vdsm Change-Id: I84dc42591e34c9b0aa0325bc5d427daed8f2c1b7 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/yaml/jobs/vdsm/vdsm_create-rpms.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84dc42591e34c9b0aa0325bc5d427daed8f2c1b7 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0