- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: rest: dont always use vm dynamic values
by juan.hernandez＠redhat.com 27 Aug '14

27 Aug '14

Juan Hernandez has submitted this change and it was merged. Change subject: rest: dont always use vm dynamic values ...................................................................... rest: dont always use vm dynamic values Currently, when getting vm, some fields always show the dynamic values (if exists) which contains information that is relevant for the current/last run, for example, if vm has SPICE as display type, but on run-once the user choose VNC, VNC will be shown while the vm is running. another scenario, when user start the vm with SPICE and after that change to VNC, SPICE is always shown, even if user explicitly request the next_run info. in this patch another option is added to the mapper to allow the caller to decide if he wants the dynamic value or not, and it is used for the next_run scenario. all other cases were not changed. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128453 Change-Id: Iae643bd7f887171b389b71d31a36362ba0168709 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 2 files changed, 33 insertions(+), 16 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Omer Frenkel: Verified -- To view, visit http://gerrit.ovirt.org/32006 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae643bd7f887171b389b71d31a36362ba0168709 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: frontend: Allow NLA auth for Native RDP execution
by tnisan＠redhat.com 27 Aug '14

27 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Allow NLA auth for Native RDP execution ...................................................................... frontend: Allow NLA auth for Native RDP execution This patch allows Network Level Authentication in combination with Native RDP client. This is done by setting enablecredsspsupport flag in RDP descriptor to 1. Previously this flag was set to 0 which prevented clients to connect to RDP server with NLA enabled. This patch only affects 'Native client' invocation. The 'Browser plugin' still has this option disabled (enabling it would prevent passing password to ActiveX plugin and therefore SSO would be impossible). Also RDP info icon text in 'Console options' dialog was enhanced with information about NLA and SSO. Change-Id: If686b824aa05b6d0083b9be6eca681797c3c26f3 Bug-Url: https://bugzilla.redhat.com/1131693 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractRdp.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/RdpNativeImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/RdpPluginImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/IRdp.java 5 files changed, 14 insertions(+), 12 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/32028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If686b824aa05b6d0083b9be6eca681797c3c26f3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: Associate users only with managed groups by oVirt
by tnisan＠redhat.com 27 Aug '14

27 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: aaa: Associate users only with managed groups by oVirt ...................................................................... aaa: Associate users only with managed groups by oVirt This patch will store at groupNames only groups that are managed by Ovirt (i.e - groups that exist in the groups DB table). Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720 Change-Id: I8a5daf3c68cc04ebd4ad0ec6cfdfd6cf16ececb9 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SyncUsers.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbUser.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbUserDAOTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUserResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResourceTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/LinqUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/linq/LinqUtilsTest.java 17 files changed, 67 insertions(+), 77 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32008 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a5daf3c68cc04ebd4ad0ec6cfdfd6cf16ececb9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: aaa: Engine should start even if exception occured in load o...
by tnisan＠redhat.com 27 Aug '14

27 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: aaa: Engine should start even if exception occured in load of legacy provider ...................................................................... aaa: Engine should start even if exception occured in load of legacy provider Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1129203 Change-Id: I6ba595253c2569cf581e690b68348e6ae1c804b1 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/DirectorySearcher.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/Utils.java M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/dns/DnsSRVLocator.java M backend/manager/modules/builtin-extensions/src/main/modules/org/ovirt/engine/extensions/builtin/main/module.xml 4 files changed, 27 insertions(+), 10 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ba595253c2569cf581e690b68348e6ae1c804b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: extmgr: Add logging for extension load/initialize
by tnisan＠redhat.com 27 Aug '14

27 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: extmgr: Add logging for extension load/initialize ...................................................................... extmgr: Add logging for extension load/initialize Easier to track what extension may misbehave. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720 Change-Id: I03169863db00b5bf4ac5f827fbd0aebcf73a51f3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java 1 file changed, 12 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03169863db00b5bf4ac5f827fbd0aebcf73a51f3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: backend: Fix timezone on import of Windows VMs
by tnisan＠redhat.com 27 Aug '14

27 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: backend: Fix timezone on import of Windows VMs ...................................................................... backend: Fix timezone on import of Windows VMs Incorrect default timezeone was being set based on uninitialized osId. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1123809 Change-Id: I61197951a3ea7e0aeb1a10a7f11e7cbefd9d99fe Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 12 insertions(+), 13 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/31972 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61197951a3ea7e0aeb1a10a7f11e7cbefd9d99fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin:renaming "OpenStack Network" to "OpenStack Networking"
by tnisan＠redhat.com 27 Aug '14

27 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin:renaming "OpenStack Network" to "OpenStack Networking" ...................................................................... webadmin:renaming "OpenStack Network" to "OpenStack Networking" Change-Id: I6e6fc9b7ae4eb4d4e7c48c079800982dd5866022 Bug-Url: https://bugzilla.redhat.com/1096170 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Eliraz Levi: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e6fc9b7ae4eb4d4e7c48c079800982dd5866022 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: add managed virtio-serial devices on upgrade
by tnisan＠redhat.com 27 Aug '14

27 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: add managed virtio-serial devices on upgrade ...................................................................... core: add managed virtio-serial devices on upgrade The upgrade scripts do the following things: - Change every existing virtio-serial device to be managed - Then is adds managed virtio-serial device to VMs that don't have it In addition, we might get reports of unmanaged virtio-serial devices from VMs that were running at the time of the upgrade, so in that case we'll not add new device, but use the managed device instead. Change-Id: I5b99dd3fa0d43307788a685c0115b32691757454 Bug-Url: https://bugzilla.redhat.com/1028387 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java A packaging/dbscripts/upgrade/03_05_1020_change_virtio_serial_to_managed_device.sql 2 files changed, 36 insertions(+), 3 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b99dd3fa0d43307788a685c0115b32691757454 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Allow NLA auth for Native RDP execution
by tjelinek＠redhat.com 27 Aug '14

27 Aug '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Allow NLA auth for Native RDP execution ...................................................................... frontend: Allow NLA auth for Native RDP execution This patch allows Network Level Authentication in combination with Native RDP client. This is done by setting enablecredsspsupport flag in RDP descriptor to 1. Previously this flag was set to 0 which prevented clients to connect to RDP server with NLA enabled. This patch only affects 'Native client' invocation. The 'Browser plugin' still has this option disabled (enabling it would prevent passing password to ActiveX plugin and therefore SSO would be impossible). Also RDP info icon text in 'Console options' dialog was enhanced with information about NLA and SSO. Change-Id: If686b824aa05b6d0083b9be6eca681797c3c26f3 Bug-Url: https://bugzilla.redhat.com/1131693 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractRdp.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/RdpNativeImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/RdpPluginImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/IRdp.java 5 files changed, 14 insertions(+), 12 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/31997 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If686b824aa05b6d0083b9be6eca681797c3c26f3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Add max length validation to PM password
by oourfali＠redhat.com 27 Aug '14

27 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Add max length validation to PM password ...................................................................... webadmin: Add max length validation to PM password Adds max length (50 chars) validation to PM password option in Host detail popup. Change-Id: I30c6275f70b3692dd9fc25704b302d85e7651720 Bug-Url: https://bugzilla.redhat.com/1129553 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Peřina: Verified -- To view, visit http://gerrit.ovirt.org/31964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30c6275f70b3692dd9fc25704b302d85e7651720 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0