- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: remove unused value from UIConstants
by derez＠redhat.com 26 Aug '14

26 Aug '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: remove unused value from UIConstants ...................................................................... webadmin: remove unused value from UIConstants Removed redundant value form UIConstants interface. Change-Id: I88b9a5049801f5b94805bcd87315b5ff2cf8ef8a Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31944 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88b9a5049801f5b94805bcd87315b5ff2cf8ef8a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin:renaming "OpenStack Network" to "OpenStack Networking"
by lvernia＠redhat.com 26 Aug '14

26 Aug '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin:renaming "OpenStack Network" to "OpenStack Networking" ...................................................................... webadmin:renaming "OpenStack Network" to "OpenStack Networking" Change-Id: I6e6fc9b7ae4eb4d4e7c48c079800982dd5866022 Bug-Url: https://bugzilla.redhat.com/1096170 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e6fc9b7ae4eb4d4e7c48c079800982dd5866022 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-release[master]: Include antlr3 and stringtemplate from JPackage on el6
by sbonazzo＠redhat.com 26 Aug '14

26 Aug '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Include antlr3 and stringtemplate from JPackage on el6 ...................................................................... Include antlr3 and stringtemplate from JPackage on el6 Those two packages are not present in CentOS 6, but are required by Drools. Drools is then used in ovirt-optimizer, which is a new component from the SLA kitchen. Change-Id: I2bde18752ae739de468257f3a51ec8b3326ce5f4 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M ovirt-release-3.5/ovirt-el6-deps.repo.in M ovirt-release-master/ovirt-el6-deps.repo.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31971 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bde18752ae739de468257f3a51ec8b3326ce5f4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Fix display of custom properties on edit VM
by ofrenkel＠redhat.com 26 Aug '14

26 Aug '14

Omer Frenkel has submitted this change and it was merged. Change subject: frontend: Fix display of custom properties on edit VM ...................................................................... frontend: Fix display of custom properties on edit VM In ExistingVmModelBehavior the custom properties sheet was not deserialized from entity to corresponding widget. Also on backend when we were dealing with VM that has next runtime configuration the OvfImport did copy the userDefined and predefined properties but not the aggregate customProperties. Change-Id: I523c61595911138b07ee74563239dd80ccb8cc99 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128433 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I523c61595911138b07ee74563239dd80ccb8cc99 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: ignore cpu profile for instance type
by tnisan＠redhat.com 26 Aug '14

26 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: ignore cpu profile for instance type ...................................................................... core: ignore cpu profile for instance type Since both template and instance type use same commands, CPU profile should be checked only for template. Change-Id: I5d2b043fbcfacd59d61cb26e28078df38554dc9f Bug-Url: https://bugzilla.redhat.com/1084930 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> (cherry picked from commit c9436ab000dbde8cbcc55d6d7582c2b651184149) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31969 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d2b043fbcfacd59d61cb26e28078df38554dc9f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Change disk alias suggestions to use alias recycling
by oourfali＠redhat.com 26 Aug '14

26 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Change disk alias suggestions to use alias recycling ...................................................................... webadmin: Change disk alias suggestions to use alias recycling In change 24061, disk alias suggestions was changed not to suggest a disk alias that is already attached to the VM, this change now also makes sure that the aliases will be recycled (i.e. if we had alias1 and alias2 and we deleted alias1, the next suggestion will be alias1) Change-Id: I8d5b8ba00a144b864208d971def7087182538be2 Bug-Url: https://bugzilla.redhat.com/1122932 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNextAvailableDiskAliasNameByVMIdQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetNextAvailableDiskAliasNameByVMIdQueryTest.java 2 files changed, 13 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d5b8ba00a144b864208d971def7087182538be2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Validate VM disk aliases when creating template
by tnisan＠redhat.com 26 Aug '14

26 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Validate VM disk aliases when creating template ...................................................................... webadmin: Validate VM disk aliases when creating template When creating a template from a VM, validate the future disk aliases of the template so they are not empty and contain only alphanumeric chars Change-Id: I9da39e89c6ae2f289363983e235e65f1d09687ec Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1110309 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9da39e89c6ae2f289363983e235e65f1d09687ec Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: disk dialog - capitalize casing of LUN
by derez＠redhat.com 26 Aug '14

26 Aug '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: disk dialog - capitalize casing of LUN ...................................................................... webadmin: disk dialog - capitalize casing of LUN Disk Dialog: s/Direct Lun/Direct LUN Change-Id: I40cce8e3f19b4e2b81d334d69ee6c2d21161be17 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31948 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40cce8e3f19b4e2b81d334d69ee6c2d21161be17 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: warning for moving disk when VM is paused
by derez＠redhat.com 26 Aug '14

26 Aug '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: warning for moving disk when VM is paused ...................................................................... webadmin: warning for moving disk when VM is paused Added warning [1] also when VM is in Paused status. [1] "Moving disk(s) while the VM is running" Change-Id: I0df1dc2d466a652d4597c9a2a24e4615cd7b309e Bug-Url: https://bugzilla.redhat.com/1110803 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/31943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0df1dc2d466a652d4597c9a2a24e4615cd7b309e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: Report domain monitoring for virt nodes only
by tnisan＠redhat.com 26 Aug '14

26 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: engine: Report domain monitoring for virt nodes only ...................................................................... engine: Report domain monitoring for virt nodes only Storage domain monitoring is required only for virtualization nodes (not for gluster nodes) Change-Id: I8731a81de756cbe0bb221f205c2a6d50c015b86b Bug-Url: https://bugzilla.redhat.com/1105513 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Sahina Bose: Verified Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8731a81de756cbe0bb221f205c2a6d50c015b86b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0