- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: converted some tabs to spaces
by tnisan＠redhat.com 26 Aug '14

26 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: userportal, webadmin: converted some tabs to spaces ...................................................................... userportal, webadmin: converted some tabs to spaces Change-Id: I40178f984902e54bcda002381a0a17523f23b76b Bug-Url: https://bugzilla.redhat.com/1127333 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/DefaultConfirmationPopupView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ForceRemoveConfirmationPopupView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/RemoveConfirmationPopupView.ui.xml 3 files changed, 66 insertions(+), 66 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/31932 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40178f984902e54bcda002381a0a17523f23b76b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

mom
by adhithacholan 26 Aug '14

26 Aug '14

Hi, I am testing mom on rhel7. Guestcputune is not working on default mom rpm package given by redhat. can help me here Regards, Adhi.

1 0

Change in ovirt-engine[ovirt-engine-3.5]: frontend: Fix display of custom properties on edit VM
by tnisan＠redhat.com 26 Aug '14

26 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Fix display of custom properties on edit VM ...................................................................... frontend: Fix display of custom properties on edit VM In ExistingVmModelBehavior the custom properties sheet was not deserialized from entity to corresponding widget. Also on backend when we were dealing with VM that has next runtime configuration the OvfImport did copy the userDefined and predefined properties but not the aggregate customProperties. Change-Id: I523c61595911138b07ee74563239dd80ccb8cc99 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128433 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31990 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I523c61595911138b07ee74563239dd80ccb8cc99 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Validate VM disk aliases when creating template
by tnisan＠redhat.com 26 Aug '14

26 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Validate VM disk aliases when creating template ...................................................................... webadmin: Validate VM disk aliases when creating template When creating a template from a VM, validate the future disk aliases of the template so they are not empty and contain only alphanumeric chars Change-Id: I9da39e89c6ae2f289363983e235e65f1d09687ec Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1110309 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31985 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9da39e89c6ae2f289363983e235e65f1d09687ec Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: add DirectLUN disk - hide disk profile
by tnisan＠redhat.com 26 Aug '14

26 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: add DirectLUN disk - hide disk profile ...................................................................... webadmin: add DirectLUN disk - hide disk profile Disk profile is not applicable for DirectLUN disks, hence, hide from DirectLUN disks dialog. Change-Id: If070376361b67d3502ea8d23c3198d1ed05e08d4 Bug-Url: https://bugzilla.redhat.com/1133776 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If070376361b67d3502ea8d23c3198d1ed05e08d4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: warning for moving disk when VM is paused
by tnisan＠redhat.com 26 Aug '14

26 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: warning for moving disk when VM is paused ...................................................................... webadmin: warning for moving disk when VM is paused Added warning [1] also when VM is in Paused status. [1] "Moving disk(s) while the VM is running" Change-Id: I0df1dc2d466a652d4597c9a2a24e4615cd7b309e Bug-Url: https://bugzilla.redhat.com/1110803 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0df1dc2d466a652d4597c9a2a24e4615cd7b309e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: reset blank template CPU profile
by tnisan＠redhat.com 26 Aug '14

26 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: reset blank template CPU profile ...................................................................... core: reset blank template CPU profile Although blank template resides in default cluster (probably because of db restrictions), it shouldn't be linked to any CPU profile. This causes any VM created in other Cluster than default, to have wrong CPU profile (derived from template). Change-Id: I383dac119e38a2c1d1d313ce738ecbf900612293 Bug-Url: https://bugzilla.redhat.com/1084930 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- A packaging/dbscripts/upgrade/03_05_1010_remove_blank_template_cpu_profile.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32001 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I383dac119e38a2c1d1d313ce738ecbf900612293 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: reset CPU profile when changing VM cluster
by tnisan＠redhat.com 26 Aug '14

26 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: core: reset CPU profile when changing VM cluster ...................................................................... core: reset CPU profile when changing VM cluster Since CPU profile is coupled to cluster, when changing a cluster the 'old' CPU profile is invalid. The edit VM command will validate a right profile for new cluster. Change-Id: I10ce4aa64ffddf500f11c89bb942d9abbac8cf31 Bug-Url: https://bugzilla.redhat.com/1084930 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> (cherry picked from commit c9401694b4471e0b30db5d7eba2f9568f0818847) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32000 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10ce4aa64ffddf500f11c89bb942d9abbac8cf31 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: reset CPU profile when changing VM cluster
by gchaplik＠redhat.com 26 Aug '14

26 Aug '14

Gilad Chaplik has submitted this change and it was merged. Change subject: core: reset CPU profile when changing VM cluster ...................................................................... core: reset CPU profile when changing VM cluster Since CPU profile is coupled to cluster, when changing a cluster the 'old' CPU profile is invalid. The edit VM command will validate a right profile for new cluster. Change-Id: I10ce4aa64ffddf500f11c89bb942d9abbac8cf31 Bug-Url: https://bugzilla.redhat.com/1084930 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31999 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10ce4aa64ffddf500f11c89bb942d9abbac8cf31 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: reset blank template CPU profile
by gchaplik＠redhat.com 26 Aug '14

26 Aug '14

Gilad Chaplik has submitted this change and it was merged. Change subject: core: reset blank template CPU profile ...................................................................... core: reset blank template CPU profile Although blank template resides in default cluster (probably because of db restrictions), it shouldn't be linked to any CPU profile. This causes any VM created in other Cluster than default, to have wrong CPU profile (derived from template). Change-Id: I383dac119e38a2c1d1d313ce738ecbf900612293 Bug-Url: https://bugzilla.redhat.com/1084930 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_0320_remove_blank_template_cpu_profile.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31994 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I383dac119e38a2c1d1d313ce738ecbf900612293 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0