- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Do not suppress dismissed alerts
by oourfali＠redhat.com 27 Aug '14

27 Aug '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Do not suppress dismissed alerts ...................................................................... core: Do not suppress dismissed alerts No health check alert is issued in ui after first message was issued This patch fixed a problem when an alert is dismissed by the user. Current functionality did not addressed dismissed alerts and show for each host instance one alert from each type. In the case that the alert was dismissed by the user, it will not show again. This patch fix the SP that insert to audit log not to suppress the alert in case that the alert exists for the host instance but it was dismissed by the user (delete=true in audit_log table) Change-Id: Ie831e8ec49b81bcb49f106f2fb377cff4dc4566b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1133611 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/audit_log_sp.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie831e8ec49b81bcb49f106f2fb377cff4dc4566b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: extmgr: add logging for extension load/initialize
by yzaslavs＠redhat.com 27 Aug '14

27 Aug '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: extmgr: add logging for extension load/initialize ...................................................................... extmgr: add logging for extension load/initialize easier to track what extension may misbehave. Change-Id: I03169863db00b5bf4ac5f827fbd0aebcf73a51f3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java 1 file changed, 12 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32013 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03169863db00b5bf4ac5f827fbd0aebcf73a51f3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: aaa: fix builtin modules xml file
by yzaslavs＠redhat.com 27 Aug '14

27 Aug '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: aaa: fix builtin modules xml file ...................................................................... aaa: fix builtin modules xml file Change-Id: Ie7af7451b9a67e256ea87de75df301b8a07134a8 Topic: AAA Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/modules/org/ovirt/engine/extensions/builtin/main/module.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7af7451b9a67e256ea87de75df301b8a07134a8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: fix style misalignments in block domain view
by derez＠redhat.com 26 Aug '14

26 Aug '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: fix style misalignments in block domain view ...................................................................... webadmin: fix style misalignments in block domain view Some alignment issues were introduced in block storage dialog and DirectLUN disk dialog (lists/tabs/etc) - see attached screenshots in BZ. Change-Id: I21975fb1fb5193322bf0e0d3565cc03767a4052c Bug-Url: https://bugzilla.redhat.com/1133779 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml 6 files changed, 12 insertions(+), 12 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21975fb1fb5193322bf0e0d3565cc03767a4052c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix alignment in New Cluster dialog / Optimization
by awels＠redhat.com 26 Aug '14

26 Aug '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: fix alignment in New Cluster dialog / Optimization ...................................................................... webadmin: fix alignment in New Cluster dialog / Optimization New Cluster dialog / Optimization tab had alignment and spacing issues. Fixed. Change-Id: Iae1712442dec2988e51312461df4c8669441f4ea Bug-Url: https://bugzilla.redhat.com/1123319 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml 3 files changed, 18 insertions(+), 15 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31938 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae1712442dec2988e51312461df4c8669441f4ea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine, userportal, webadmin: configurable unsupported locales
by awels＠redhat.com 26 Aug '14

26 Aug '14

Alexander Wels has submitted this change and it was merged. Change subject: engine,userportal,webadmin: configurable unsupported locales ...................................................................... engine,userportal,webadmin: configurable unsupported locales - Added UnsupportedDisplayedLocales configuration variable to control which unsupported locales are displayed. Any locales in this list which are also in the UnsupportedLocaleFilter list will still be displayed. - Added UnsupportedLocalesFilter configuration variable to control which locales are unsupported. Any locale in this list will NOT be displayed unless they are also in the UnsupportedDisplayedLocales list. Change-Id: Ib1c882933a365b5f03769ae8e7048aaf3553633b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1096525 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/32010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1c882933a365b5f03769ae8e7048aaf3553633b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine, userportal, webadmin: configurable unsupported locales
by awels＠redhat.com 26 Aug '14

26 Aug '14

Alexander Wels has submitted this change and it was merged. Change subject: engine,userportal,webadmin: configurable unsupported locales ...................................................................... engine,userportal,webadmin: configurable unsupported locales - Added UnsupportedDisplayedLocales configuration variable to control which unsupported locales are displayed. Any locales in this list which are also in the UnsupportedLocaleFilter list will still be displayed. - Added UnsupportedLocalesFilter configuration variable to control which locales are unsupported. Any locale in this list will NOT be displayed unless they are also in the UnsupportedDisplayedLocales list. Change-Id: Ib1c882933a365b5f03769ae8e7048aaf3553633a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1096525 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/UnsupportedLocaleHelper.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/servlet/UnsupportedLocaleHelperTest.java M backend/manager/modules/welcome/pom.xml M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeServlet.java M backend/manager/modules/welcome/src/test/java/org/ovirt/engine/core/WelcomeServletTest.java M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/AbstractGwtDynamicHostPageServletTest.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/UserPortalHostPageServletTest.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServletTest.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/VisibleLocalesInfoData.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginFormView.java M packaging/etc/engine-config/engine-config.properties 15 files changed, 321 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1c882933a365b5f03769ae8e7048aaf3553633a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: fixed error icon position in dialog
by tnisan＠redhat.com 26 Aug '14

26 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fixed error icon position in dialog ...................................................................... webadmin: fixed error icon position in dialog Commit e9f27f4 caused the error icon to be off by a few pixels. Fixed. Change-Id: Ic4ebee8e86f6fdc840e5242a571b2cbc95c82dca Bug-Url: https://bugzilla.redhat.com/1119027 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M packaging/branding/ovirt.brand/common.css 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/31935 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4ebee8e86f6fdc840e5242a571b2cbc95c82dca Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: fix error dialog padding
by tnisan＠redhat.com 26 Aug '14

26 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix error dialog padding ...................................................................... webadmin: fix error dialog padding Commit 2e5c0cd0 incorrectly used margin in the error dialog instead of padding. Fixed. Change-Id: I29c94ed143b568efb1832f129b43fd9fc420b4ae Bug-Url: https://bugzilla.redhat.com/1127333 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ErrorPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/31934 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29c94ed143b568efb1832f129b43fd9fc420b4ae Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: fixed dialog padding
by tnisan＠redhat.com 26 Aug '14

26 Aug '14

Tal Nisan has submitted this change and it was merged. Change subject: userportal, webadmin: fixed dialog padding ...................................................................... userportal, webadmin: fixed dialog padding The error and remove dialogs were missing padding. Fixed. Change-Id: Ie4bce0700dc8de218d9fafbf674eb03481219499 Bug-Url: https://bugzilla.redhat.com/1127333 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/DefaultConfirmationPopupView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ErrorPopupView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ForceRemoveConfirmationPopupView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/RemoveConfirmationPopupView.ui.xml 4 files changed, 11 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/31933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4bce0700dc8de218d9fafbf674eb03481219499 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0