- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: fixed edit icons in Setup Host Network dialog pt 3
by lvernia＠redhat.com 30 Jul '14

30 Jul '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: fixed edit icons in Setup Host Network dialog pt 3 ...................................................................... webadmin: fixed edit icons in Setup Host Network dialog pt 3 Commit 83046362c5e727a80ede49075a630f9be9f82a31 broke the edit icon fix from commit 6c03d4171c06328c665098c18145548aa13dcad8. Edit icon was again misplaced. Fixed. Also refactored the CSS -- grouped common classes for 'setup network dialog', and removed patternfly hacks from NetworkItemPanel. Change-Id: I45d149db76d24b64ae9836c29ea7f03a5dcfcf7c Bug-Url: https://bugzilla.redhat.com/1114991 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NicPanel.java M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 4 files changed, 8 insertions(+), 18 deletions(-) Approvals: oVirt Jenkins CI Server: Looks good to me, but someone else must approve Greg Sheremeta: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45d149db76d24b64ae9836c29ea7f03a5dcfcf7c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: increase guide me button size
by awels＠redhat.com 30 Jul '14

30 Jul '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: increase guide me button size ...................................................................... webadmin: increase guide me button size - Increase the size of the guide me buttons to be the width of the popup window so it doesn't cut of messages in other locales. Change-Id: I686165f9b93b36ad664ddaee50df268b76a2347e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1121108 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Verified Greg Sheremeta: Looks good to me, but someone else must approve Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30809 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I686165f9b93b36ad664ddaee50df268b76a2347e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: initialize variable in test
by amureini＠redhat.com 30 Jul '14

30 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: initialize variable in test ...................................................................... core: initialize variable in test Fix coverity issue CID 1229126. Change-Id: I25b2fbeb703a4d148557f0a8aa6adbaafa4e1923 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidatorTest.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25b2fbeb703a4d148557f0a8aa6adbaafa4e1923 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Extract Validator creation and apply usages
by tnisan＠redhat.com 30 Jul '14

30 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Extract Validator creation and apply usages ...................................................................... core: Extract Validator creation and apply usages There are several places creating a MultipleStorageDomainsValidator based on a VM and DisksImage List in the same manner. Some new code for bellow bzs does the same, as will other patches. This patch removed future code duplicity by extracting the duplicated code into VmCommand. Change-Id: I3a6d04fe1a670c814b44bad5304a894faa8f8510 Bug-Url: https://bugzilla.redhat.com/1054175 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 2 files changed, 7 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/30853 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a6d04fe1a670c814b44bad5304a894faa8f8510 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fixed search Disks when filtered by data-center
by derez＠redhat.com 30 Jul '14

30 Jul '14

Daniel Erez has submitted this change and it was merged. Change subject: core: fixed search Disks when filtered by data-center ...................................................................... core: fixed search Disks when filtered by data-center Similar to fix in chnage-id I04e37501b29a17a634e31e8875d63577e5f9f401 (and following change-id I862873171c6753f8c8863c10c336e981e39dc8cb), searching disks (or clusters) by a data-center looks like [1]. I.e. the left outer join is being made on storage_pool_with_storage_domains; which leads to multiple records since a data-center can contain multiple storage domains. Therefore, reverted to previous search so it uses the 'use-tag' syntax [2]. As a result, a similar issue with search Clusters when filtered by data-center has been fixed as well. [1] SELECT all_disks.* FROM all_disks LEFT OUTER JOIN storage_pool_with_storage_domain ON all_disks.storage_pool_id=storage_pool_with_storage_domain.id WHERE storage_pool_with_storage_domain.name ILIKE 'dc35' AND all_disks.disk_storage_type = '0' [2] SELECT * FROM all_disks WHERE (disk_id IN (SELECT all_disks.disk_id FROM all_disks LEFT OUTER JOIN storage_pool_with_storage_domain ON all_disks.storage_pool_id=storage_pool_with_storage_domain.id WHERE (storage_pool_with_storage_domain.name ILIKE 'dc35' AND all_disks.disk_storage_type = '0'))) Change-Id: I3a792fb63421c7589ed073fb18cfaac46a7dd3a9 Bug-Url: https://bugzilla.redhat.com/1124584 Bug-Url: https://bugzilla.redhat.com/1124593 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxContainer.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a792fb63421c7589ed073fb18cfaac46a7dd3a9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Threshold validation for stateless VM
by amureini＠redhat.com 30 Jul '14

30 Jul '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Threshold validation for stateless VM ...................................................................... core: Threshold validation for stateless VM When a VM is run as stateless, temporary volumes are created for each disk leaf. Threshold validation is added in this patch. Change-Id: Ic15815abfe25bb5d78b5115e2d05bf040fdcfcdb Bug-Url: https://bugzilla.redhat.com/1054175 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/30840 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic15815abfe25bb5d78b5115e2d05bf040fdcfcdb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Changed event message for suspended shutdown
by tnisan＠redhat.com 30 Jul '14

30 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Changed event message for suspended shutdown ...................................................................... core: Changed event message for suspended shutdown Changed event message text displayed at audit log during power off\shutdown of a suspended VM. Change-Id: If788ab1117244b6fd211c17e99ddb8d31a794d35 Bug-Url: https://bugzilla.redhat.com/1073437 Signed-off-by: Eldan Shachar <eshachar(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If788ab1117244b6fd211c17e99ddb8d31a794d35 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Eldan Shachar <eshachar(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[ovirt-engine-reports-3.4]: build: post ovirt-engine-reports-3.4.3
by ydary＠redhat.com 30 Jul '14

30 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: post ovirt-engine-reports-3.4.3 ...................................................................... build: post ovirt-engine-reports-3.4.3 Change-Id: I25aff8fe0b9727a7d564d08e8e040181de052540 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25aff8fe0b9727a7d564d08e8e040181de052540 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.4 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[ovirt-engine-reports-3.4]: build: ovirt-engine-reports-3.4.3-2 respin
by ydary＠redhat.com 30 Jul '14

30 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: build: ovirt-engine-reports-3.4.3-2 respin ...................................................................... build: ovirt-engine-reports-3.4.3-2 respin Change-Id: Ib965cd8886d718e35ab3ae379f3e04f2a77d0b1e Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-reports.spec.in M version.mak 2 files changed, 7 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib965cd8886d718e35ab3ae379f3e04f2a77d0b1e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.4 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Host Edit Network dialog - fix custom properties l...
by tnisan＠redhat.com 30 Jul '14

30 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Host Edit Network dialog - fix custom properties layout ...................................................................... webadmin: Host Edit Network dialog - fix custom properties layout Make dropdown wider so whole string 'Please select a key...' is visible. Change-Id: Iaf25dde046346f8bea239b9e3f6c963f86e74adc Bug-Url: https://bugzilla.redhat.com/1124404 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf25dde046346f8bea239b9e3f6c963f86e74adc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0