- Engine-commits - oVirt List Archives

Change in jenkins[master]: Added ovirt-reports
by eedri＠redhat.com 31 Jul '14

31 Jul '14

Eyal Edri has submitted this change and it was merged. Change subject: Added ovirt-reports ...................................................................... Added ovirt-reports Change-Id: I290af7cb1424903722ffb421d0b5677f5cf3641b Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/shell-scripts/build_local_srcrpm.sh A jobs/confs/yaml/jobs/ovirt-reports/ovirt-reports_create-rpms.yaml A jobs/confs/yaml/scms/ovirt-reports.yaml 3 files changed, 49 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Ewoud Kohl van Wijngaarden: Looks good to me, but someone else must approve Eyal Edri: Looks good to me, approved David Caro: Verified -- To view, visit http://gerrit.ovirt.org/30531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I290af7cb1424903722ffb421d0b5677f5cf3641b Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: jsonrpc: client side heartbeat implementation
by oourfali＠redhat.com 31 Jul '14

31 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: jsonrpc: client side heartbeat implementation ...................................................................... jsonrpc: client side heartbeat implementation There is new vdsHeartBeat option in the database which default value is 10 seconds. This option is propagated down to json client. Change-Id: I9e8a20592542ce1a754dee1917ff9ebba6b8daf9 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/TransportFactory.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIntegrationTest.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M pom.xml 8 files changed, 26 insertions(+), 16 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e8a20592542ce1a754dee1917ff9ebba6b8daf9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: GWT debug mode speedup.
by awels＠redhat.com 30 Jul '14

30 Jul '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: GWT debug mode speedup. ...................................................................... webadmin: GWT debug mode speedup. Debug mode would take around 4:30 to get from the login page to the VM main tab when logging in. This is due to the proxy event on UiCommonInitEvent in AbstractSubTabPresenter. This event would fire and it would cause all sub classes of AbstractSubTabPresenter to initialize and since the code was split, it would have to load every single sub tab presenter everywhere at once. This took about 500ms-3000ms depending on the presenter. With around 200 sub tab presenters, it would take a long long time. This patch removes the proxy event and instead places the handler initialization in the onBind of the presenter. This should have the exact same effect as before (the handlers are initalized when the presenter is activated vs when the application is initalized). Change-Id: I8a5a038cbf7a6cfe8e462eab2e4f18c910c039cc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1110788 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/ClientModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ClientModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/cluster/SubTabClusterGeneralPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostHardwarePresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/virtualMachine/SubTabVirtualMachineGeneralPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/virtualMachine/SubTabVirtualMachineSnapshotPresenter.java 8 files changed, 20 insertions(+), 23 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a5a038cbf7a6cfe8e462eab2e4f18c910c039cc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: increase guide me button size
by tnisan＠redhat.com 30 Jul '14

30 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: increase guide me button size ...................................................................... webadmin: increase guide me button size - Increase the size of the guide me buttons to be the width of the popup window so it doesn't cut of messages in other locales. Change-Id: I686165f9b93b36ad664ddaee50df268b76a2347e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1121108 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30861 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I686165f9b93b36ad664ddaee50df268b76a2347e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Threshold validation for stateless VM
by tnisan＠redhat.com 30 Jul '14

30 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Threshold validation for stateless VM ...................................................................... core: Threshold validation for stateless VM When a VM is run as stateless, temporary volumes are created for each disk leaf. Threshold validation is added in this patch. Change-Id: Ic15815abfe25bb5d78b5115e2d05bf040fdcfcdb Bug-Url: https://bugzilla.redhat.com/1054175 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/30856 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic15815abfe25bb5d78b5115e2d05bf040fdcfcdb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Storage validation when running stateless VM
by tnisan＠redhat.com 30 Jul '14

30 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Storage validation when running stateless VM ...................................................................... core: Storage validation when running stateless VM When a VM is run as stateless, temporary volumes are created for each disk leaf. Up till now there were no storage validations in this case. These were added in this patch, along with some new functionality to the MultipleStorageDomainsValidator, as well as related tests. Change-Id: Id04203119cce475afeef7658db50e132b0c7036a Bug-Url: https://bugzilla.redhat.com/1054175 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidatorTest.java 3 files changed, 60 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/30855 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id04203119cce475afeef7658db50e132b0c7036a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Added VM memory validation on snapshot
by tnisan＠redhat.com 30 Jul '14

30 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Added VM memory validation on snapshot ...................................................................... core: Added VM memory validation on snapshot Up till now there were no storage validations when creating a snapshot of a running VM with the VM's memory. These validations are now added to the relevant command and validators. Relevant tests were amended/added accordingly. Change-Id: I8fc127147bdea8737fecb034c88079521b8a8bd6 Bug-Url: https://bugzilla.redhat.com/1119022 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/NullableMemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/StatelessSnapshotMemoryImageBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorFreeSpaceTest.java 10 files changed, 225 insertions(+), 69 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/30854 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fc127147bdea8737fecb034c88079521b8a8bd6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: fixed edit icons in Setup Host Network dialog pt 3
by tnisan＠redhat.com 30 Jul '14

30 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fixed edit icons in Setup Host Network dialog pt 3 ...................................................................... webadmin: fixed edit icons in Setup Host Network dialog pt 3 Commit 83046362c5e727a80ede49075a630f9be9f82a31 broke the edit icon fix from commit 6c03d4171c06328c665098c18145548aa13dcad8. Edit icon was again misplaced. Fixed. Also refactored the CSS -- grouped common classes for 'setup network dialog', and removed patternfly hacks from NetworkItemPanel. Change-Id: I45d149db76d24b64ae9836c29ea7f03a5dcfcf7c Bug-Url: https://bugzilla.redhat.com/1114991 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NicPanel.java M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 4 files changed, 8 insertions(+), 18 deletions(-) Approvals: Greg Sheremeta: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30843 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45d149db76d24b64ae9836c29ea7f03a5dcfcf7c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Quota tab sorting
by tnisan＠redhat.com 30 Jul '14

30 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Quota tab sorting ...................................................................... webadmin: Quota tab sorting - Implemented sorting on Quota main tab. - Only for name and description - Implemented sorting on Quota sub tabs. - Not implemented for VM/Template Change-Id: I2740a5a15523da95b599de5b7acf688472d6df49 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1119873 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/QuotaConditionFieldAutoCompleter.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/TextColumnWithEditableTooltip.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabQuotaView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaClusterView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaPermissionView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaUserView.java 8 files changed, 80 insertions(+), 53 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2740a5a15523da95b599de5b7acf688472d6df49 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: restapi : the format of profile\user is not supported by RES...
by tnisan＠redhat.com 30 Jul '14

30 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: restapi : the format of profile\user is not supported by REST-API ...................................................................... restapi : the format of profile\user is not supported by REST-API the format of domain\user is not supported by restapi Change-Id: I9c8907d4dc612d67bb881af5a579eb8f16ce238a Bug-Url: https://bugzilla.redhat.com/1123545 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, but someone else must approve Ravi Nori: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c8907d4dc612d67bb881af5a579eb8f16ce238a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0