- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Revert mistake in dal's module.xml
by tnisan＠redhat.com 31 Jul '14

31 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Revert mistake in dal's module.xml ...................................................................... core: Revert mistake in dal's module.xml Revert 52a30e640d5f2db24e9cacbb9e17804641d7d4ed's impact on dal's module.xml file - this dependency is required in runtime albeit not in compile time. Change-Id: I7de24f400c7cc9f55026b173b16b0a3ce8cf1cd3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/modules/org/ovirt/engine/core/dal/main/module.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7de24f400c7cc9f55026b173b16b0a3ce8cf1cd3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: replacing fenceSpmStorage with logic within engine
by laravot＠redhat.com 31 Jul '14

31 Jul '14

Liron Aravot has submitted this change and it was merged. Change subject: core: replacing fenceSpmStorage with logic within engine ...................................................................... core: replacing fenceSpmStorage with logic within engine Currently when the SPM is in different statuses the user can manually confirm that the host has been rebooted in order to attempt to start the spm on a different host. That confirmation propogates to the execution of FenceVdsManuallyCommand that may execute the fenceSpmStorage verb on vdsm through some host. The fenceSpmStorage verb edits the pool metadata to indicate that currently there's no host which is the SPM. Later on when the engine will enter the start spm flow, it will execute the getSpmStatus which should return that there's no spm and then the engine will attempt to start the spm on some host within the data center. On storage pools that use the StoragePoolDiskBackend this flow works, but when using the new MemoryBackend the spm status result is being returned from the cluster lock, the data there isn't editable at the moment so on that case, the spm won't be able to start on other host (as the returned result would indicate that there's a spm). On this patch when a user confirm that the spm has been rebooted, we'll save that in the memory, when the spm selection process will attempt to select a new spm in case that the reported spm was confirmed to be fenced by the user - we'll proceed with starting the spm on another host. Change-Id: I2e489cd4ff1f8e8686c89d8ceab72c3af3653a56 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1092752 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ResetIrsVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ResetIrsVDSCommand.java 4 files changed, 48 insertions(+), 66 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e489cd4ff1f8e8686c89d8ceab72c3af3653a56 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: removing fenceSpmStorage verb and related classes
by laravot＠redhat.com 31 Jul '14

31 Jul '14

Liron Aravot has submitted this change and it was merged. Change subject: core: removing fenceSpmStorage verb and related classes ...................................................................... core: removing fenceSpmStorage verb and related classes The use of fenceSpmStorage was removed in the previous patch in the series, as it's not used anymore it can be safely remove along the related classes. Change-Id: I593a0620696729500d740c632a2a149c09366cbc Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/FenceSpmStorageVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SpmStartVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceSpmStorageVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 8 files changed, 27 insertions(+), 83 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30540 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I593a0620696729500d740c632a2a149c09366cbc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: init: Propagate status return value to start and stop functions
by sbonazzo＠redhat.com 31 Jul '14

31 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: init: Propagate status return value to start and stop functions ...................................................................... init: Propagate status return value to start and stop functions The status function should store the return status both in the RETVAL variable and return it as the function return value so that it can be used by the start, stop, and other functions. Change-Id: I50f7b7e30ead2cab80e62ea38cbdb1376fa7966a Bug-Url: https://bugzilla.redhat.com/1123285 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> (cherry picked from commit 957facc570c100af54c061b111abbe4220e897c8) --- M initscripts/ovirt-ha-agent.init.in M initscripts/ovirt-ha-broker.init.in 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jiří Moskovčák: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50f7b7e30ead2cab80e62ea38cbdb1376fa7966a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: init: Propagate status return value to start and stop functions
by sbonazzo＠redhat.com 31 Jul '14

31 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: init: Propagate status return value to start and stop functions ...................................................................... init: Propagate status return value to start and stop functions The status function should store the return status both in the RETVAL variable and return it as the function return value so that it can be used by the start, stop, and other functions. Change-Id: I50f7b7e30ead2cab80e62ea38cbdb1376fa7966a Bug-Url: https://bugzilla.redhat.com/1123285 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M initscripts/ovirt-ha-agent.init.in M initscripts/ovirt-ha-broker.init.in 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jiří Moskovčák: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30844 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50f7b7e30ead2cab80e62ea38cbdb1376fa7966a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Added slf4j jobs
by dcaroest＠redhat.com 31 Jul '14

31 Jul '14

David Caro has submitted this change and it was merged. Change subject: Added slf4j jobs ...................................................................... Added slf4j jobs Only for el6 Change-Id: I4da38bfab6f22307cdb49e8b37989e29340f6b97 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- A jobs/confs/yaml/jobs/slf4j/slf4j.yaml 1 file changed, 24 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Eyal Edri: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4da38bfab6f22307cdb49e8b37989e29340f6b97 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Added tooltip for mount options in new storage dialog
by tnisan＠redhat.com 31 Jul '14

31 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Added tooltip for mount options in new storage dialog ...................................................................... webadmin: Added tooltip for mount options in new storage dialog Added an explanation tooltip in the mount options option in NFS new storage domain dialog and Posix new storage domain dialog Change-Id: Ieded652097ecd17f17ee27678b57818f4ca88be2 Bug-Url: https://bugzilla.redhat.com/1109053 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/PosixStorageModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java 4 files changed, 19 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieded652097ecd17f17ee27678b57818f4ca88be2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: agent: Log error when restarting
by sbonazzo＠redhat.com 31 Jul '14

31 Jul '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: agent: Log error when restarting ...................................................................... agent: Log error when restarting Log an error message when restarting the agent (fix backport error) Change-Id: I1348653701767fd7720545a695990a6ae286eed9 Bug-Url: https://bugzilla.redhat.com/1124624 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/agent.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jiří Moskovčák: Looks good to me, but someone else must approve Greg Padgett: Verified -- To view, visit http://gerrit.ovirt.org/30814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1348653701767fd7720545a695990a6ae286eed9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Interface up/down events should be displayed in real...
by alkaplan＠redhat.com 31 Jul '14

31 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Interface up/down events should be displayed in real time ...................................................................... engine: Interface up/down events should be displayed in real time And not only one event per 30 minutes. Change-Id: I70dc0968583e40aa712c15b6b1e5a3fa8802775b Bug-Url: https://bugzilla.redhat.com/987299 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30833 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70dc0968583e40aa712c15b6b1e5a3fa8802775b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Added tooltip for mount options in new storage dialog
by tnisan＠redhat.com 31 Jul '14

31 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Added tooltip for mount options in new storage dialog ...................................................................... webadmin: Added tooltip for mount options in new storage dialog Added an explanation tooltip in the mount options option in NFS new storage domain dialog and Posix new storage domain dialog Change-Id: Ieded652097ecd17f17ee27678b57818f4ca88be2 Bug-Url: https://bugzilla.redhat.com/1109053 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/PosixStorageModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java 4 files changed, 19 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieded652097ecd17f17ee27678b57818f4ca88be2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0