- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove useless unused p6spy dependency
by oourfali＠redhat.com 31 Jul '14

31 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Remove useless unused p6spy dependency ...................................................................... core: Remove useless unused p6spy dependency Change-Id: I6535a49ffbc7477409ab530b82d330c1903aeff9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/dal/src/test/resources/spy.properties M backend/manager/modules/pom.xml 2 files changed, 0 insertions(+), 250 deletions(-) Approvals: Allon Mureinik: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6535a49ffbc7477409ab530b82d330c1903aeff9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Update dal's README
by oourfali＠redhat.com 31 Jul '14

31 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Update dal's README ...................................................................... core: Update dal's README Updated the README file to reference the current state of PostgreSQL/Java implementation. Change-Id: I92603c2e6681012d09c16f23fe47400ec22e8b91 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/README 1 file changed, 27 insertions(+), 46 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Allon Mureinik: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92603c2e6681012d09c16f23fe47400ec22e8b91 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove redundant infinispan dep. from dal
by oourfali＠redhat.com 31 Jul '14

31 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Remove redundant infinispan dep. from dal ...................................................................... core: Remove redundant infinispan dep. from dal The dal module does not use infinispan, and should not depend on it. Change-Id: If78b6319adb30e0580af84882824285238a1b651 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/pom.xml M backend/manager/modules/dal/src/main/modules/org/ovirt/engine/core/dal/main/module.xml 2 files changed, 0 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If78b6319adb30e0580af84882824285238a1b651 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove infinispan mocking from bll tests
by oourfali＠redhat.com 31 Jul '14

31 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: Remove infinispan mocking from bll tests ...................................................................... core: Remove infinispan mocking from bll tests This mocking seems to be useless. Perhaps it had some use when it was introduced, but its obvious it plays no function now. Change-Id: I0b7cc1a51971fce44316e9a7c3d14e686b84ec43 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveVdsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java 2 files changed, 0 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b7cc1a51971fce44316e9a7c3d14e686b84ec43 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: fixed search Disks when filtered by data-center
by tnisan＠redhat.com 31 Jul '14

31 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: core: fixed search Disks when filtered by data-center ...................................................................... core: fixed search Disks when filtered by data-center Similar to fix in chnage-id I04e37501b29a17a634e31e8875d63577e5f9f401 (and following change-id I862873171c6753f8c8863c10c336e981e39dc8cb), searching disks (or clusters) by a data-center looks like [1]. I.e. the left outer join is being made on storage_pool_with_storage_domains; which leads to multiple records since a data-center can contain multiple storage domains. Therefore, reverted to previous search so it uses the 'use-tag' syntax [2]. As a result, a similar issue with search Clusters when filtered by data-center has been fixed as well. [1] SELECT all_disks.* FROM all_disks LEFT OUTER JOIN storage_pool_with_storage_domain ON all_disks.storage_pool_id=storage_pool_with_storage_domain.id WHERE storage_pool_with_storage_domain.name ILIKE 'dc35' AND all_disks.disk_storage_type = '0' [2] SELECT * FROM all_disks WHERE (disk_id IN (SELECT all_disks.disk_id FROM all_disks LEFT OUTER JOIN storage_pool_with_storage_domain ON all_disks.storage_pool_id=storage_pool_with_storage_domain.id WHERE (storage_pool_with_storage_domain.name ILIKE 'dc35' AND all_disks.disk_storage_type = '0'))) Change-Id: I3a792fb63421c7589ed073fb18cfaac46a7dd3a9 Bug-Url: https://bugzilla.redhat.com/1124584 Bug-Url: https://bugzilla.redhat.com/1124593 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxContainer.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a792fb63421c7589ed073fb18cfaac46a7dd3a9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: VM's template information is inconsistent after up...
by tnisan＠redhat.com 31 Jul '14

31 Jul '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: VM's template information is inconsistent after upgrading to 3.4 ...................................................................... webadmin: VM's template information is inconsistent after upgrading to 3.4 Having a thin provisioned VM created in 3.3 and updated it to 3.5 the VM General subtab showed: "TemplateName" But if created in 3.4 and later it showed: "TemplateName (Thin/Dependent)" This patch unifies it so also the older VMs show up in the new format. Change-Id: Ie55359039cf45a758f132e8c797f033f73222457 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1084940 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmTemplateNameRenderer.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30815 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie55359039cf45a758f132e8c797f033f73222457 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.4]: packaging: updated insert_calendar_table_values script
by ydary＠redhat.com 31 Jul '14

31 Jul '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: updated insert_calendar_table_values script ...................................................................... packaging: updated insert_calendar_table_values script fixed the script so that the values generated will not be affected due to timezones that are not of round hours. Change-Id: Ib525d093d6c54f3153f23f7d499362ba6d4fb25b Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- A packaging/dbscripts/upgrade/03_04_0100_updated_insert_calendar_table_values_script.sql 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib525d093d6c54f3153f23f7d499362ba6d4fb25b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.4 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Set images with Storage Pool for images already on tar...
by mlipchuk＠redhat.com 31 Jul '14

31 Jul '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Set images with Storage Pool for images already on target. ...................................................................... core: Set images with Storage Pool for images already on target. Setting images with storage pool id only for images which are already on the Storage Domain, since importing a VM from configuration through the REST does not oblegate an initialized Storage Domain Change-Id: I8546a2ac47dab4208da0df4c2cd7bb92fdde1d40 Bug-Url: https://bugzilla.redhat.com/1124879 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/30827 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8546a2ac47dab4208da0df4c2cd7bb92fdde1d40 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Add test for import unregistered VM
by mlipchuk＠redhat.com 31 Jul '14

31 Jul '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add test for import unregistered VM ...................................................................... core: Add test for import unregistered VM Adding a test for ImportVmFromConfigurationCommand to test an import of unregistered VM. Change-Id: Ie6f68a66da4de6b9dbfb664d3678b25582a82496 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVMFromConfigurationCommandTest.java A backend/manager/modules/bll/src/test/resources/vmOvfData.xml 3 files changed, 184 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/29795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6f68a66da4de6b9dbfb664d3678b25582a82496 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Fix Coverity Scan defect in UiCommon test
by tjelinek＠redhat.com 31 Jul '14

31 Jul '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Fix Coverity Scan defect in UiCommon test ...................................................................... frontend: Fix Coverity Scan defect in UiCommon test Change-Id: Ie8bf598c928ed5530a050df45727033c6ff6f464 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmModelBehaviorTest.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Betak: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/30835 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8bf598c928ed5530a050df45727033c6ff6f464 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0