- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: core: sync VM config after Live Merge
by oourfali＠redhat.com 27 Jul '14

27 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: sync VM config after Live Merge ...................................................................... core: sync VM config after Live Merge After a backwards merge, the child of a deleted snapshot will now have a different image associated with it. This needs to be reflected in the VM configuration for the snapshot, else the disks will be marked illegal in the UI and won't function properly when the snapshot is previewed/reverted. Change-Id: Ic37dc1e54b99893bca68088eee80c26e1fbf9f91 Bug-Url: https://bugzilla.redhat.com/1122691 Related-To: https://bugzilla.redhat.com/1083310 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 2 files changed, 44 insertions(+), 4 deletions(-) Approvals: Greg Padgett: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic37dc1e54b99893bca68088eee80c26e1fbf9f91 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: set active image after Live Merge of active layer
by oourfali＠redhat.com 27 Jul '14

27 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: set active image after Live Merge of active layer ...................................................................... core: set active image after Live Merge of active layer Live Merging the active layer should mark the new active image. Change-Id: Ifc2777257b85c52011aa3bd7c9ad56c2ea680b63 Bug-Url: https://bugzilla.redhat.com/1122691 Related-To: https://bugzilla.redhat.com/1083310 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Greg Padgett: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30606 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc2777257b85c52011aa3bd7c9ad56c2ea680b63 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: allow successful retries of Live Merge
by oourfali＠redhat.com 27 Jul '14

27 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: allow successful retries of Live Merge ...................................................................... core: allow successful retries of Live Merge Change RemoveSnapshotSingleDiskLiveCommand and related commands to allow for successful retries after deletion or merge fails. Upon merge failure, images are marked illegal but remain in the volume chain. Retries will start over and attempt to merge the images again. Upon deletion failure (but after a successful merge), the volume chain is updated to reflect the new chain; however, the orphaned images are re-associated with the snapshot to be deleted, marked illegal, and set to have no parents or children. Upon retry, the command will detect this state and skip to the DESTROY_IMAGE execution step. Change-Id: Ib794822c6b03cb05e00dc7e99113127aaed43ce9 Bug-Url: https://bugzilla.redhat.com/1122691 Related-To: https://bugzilla.redhat.com/1083310 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java 3 files changed, 161 insertions(+), 26 deletions(-) Approvals: Greg Padgett: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib794822c6b03cb05e00dc7e99113127aaed43ce9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: set the engine session ID as the reports token
by oourfali＠redhat.com 27 Jul '14

27 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: set the engine session ID as the reports token ...................................................................... webadmin: set the engine session ID as the reports token Recent changes in the engine set the session ID differently. In the past it was identical to the JSESSIONID, but now it is a generated one. This patch sets the reports SSO token to the returned session ID upon login, which is the engine-generated session ID. Change-Id: Id57589fb6266ca513607f474070bd9769e31c2e5 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1122582 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id57589fb6266ca513607f474070bd9769e31c2e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Network dialog- field validation indication for tabs
by alkaplan＠redhat.com 27 Jul '14

27 Jul '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Network dialog- field validation indication for tabs ...................................................................... webadmin: Network dialog- field validation indication for tabs Change-Id: I8b9cfd6d4c8fcb4768c99c42393dd0d0c72f7cbd Bug-Url: https://bugzilla.redhat.com/1115827 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/AbstractNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java 3 files changed, 85 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Verified Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b9cfd6d4c8fcb4768c99c42393dd0d0c72f7cbd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core : Rest API operations Fail on oVirt-engine's logs
by oourfali＠redhat.com 26 Jul '14

26 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: core : Rest API operations Fail on oVirt-engine's logs ...................................................................... core : Rest API operations Fail on oVirt-engine's logs Authentication layer logs error message when Session-TTL header was not passed Change-Id: I88b28fffff075e00a7903f33198040bc95ba3900 Bug-Url: https://bugzilla.redhat.com/1121391 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/RestApiSessionMgmtFilter.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ravi Nori: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88b28fffff075e00a7903f33198040bc95ba3900 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: Keep validation/event message if there is an iso u...
by piotr.kliczewski＠gmail.com 25 Jul '14

25 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Keep validation/event message if there is an iso update to ovirt node host ...................................................................... webadmin: Keep validation/event message if there is an iso update to ovirt node host The code for checking if there is an iso update to ovirt-node host got removed when reworking ovirt host deploy sequence. shouldAlertUpgrade() is still available in HostGeneralModel.java Change-Id: I1b58f3c5f2ce1a7e9f5c151c07c6c32a2cbb8fe1 Bug-Url: https://bugzilla.redhat.com/1117393 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 2 files changed, 56 insertions(+), 1 deletion(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b58f3c5f2ce1a7e9f5c151c07c6c32a2cbb8fe1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal, webadmin: Fixed layout issues in es locale
by tjelinek＠redhat.com 25 Jul '14

25 Jul '14

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: Fixed layout issues in es locale ...................................................................... userportal,webadmin: Fixed layout issues in es locale Some CSS tweaks to have the layout correct on es locale Change-Id: Ic8d116081da88304ae71f3ea6b40c3e893a6177d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1123309 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java 4 files changed, 30 insertions(+), 14 deletions(-) Approvals: Tomas Jelinek: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8d116081da88304ae71f3ea6b40c3e893a6177d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: userportal, webadmin: show advanced options on validation error
by piotr.kliczewski＠gmail.com 25 Jul '14

25 Jul '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: userportal,webadmin: show advanced options on validation error ...................................................................... userportal,webadmin: show advanced options on validation error When there was a validation error in the new/edit VM dialog while only the basic mode was visible, it was not obvious what the problem is. The new behavior is this: - if there is a validation error and the invalid widget is visible in the current screen, do not show the advanced options - if there is a validation error and the invalid widget is not visible, turn on the advanced options so the widget will be visible To support this, the following changes had to be made: - added the method isValid to HasValidation - implemented this method in the needed widgets - added the support of HasValidation also to the EntityModelWidgetWithInfo and DetachableWidget - added a method getInvalidWidgets to DialogTab to find all the invalid widgets Beside this also some small fixes has been done, namely: - added the proper validation of the initial run tab - fixed the validation of the system tab - extracted and cleaned up the resetting of the tab validity Change-Id: I1b419b560fe1e0bc0c8114d2a34f0bc930756aa0 Bug-Url: https://bugzilla.redhat.com/1085380 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractVmPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/EntityModelWidgetWithInfo.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HasValidation.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTab.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EnumRadioEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/WidgetWithLabelEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/BaseEntityModelDetachableWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelDetachableWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelDetachableWidgetWithLabel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/popup/AbstractVmBasedPopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/ImportFcpStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/ImportIscsiStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 17 files changed, 253 insertions(+), 35 deletions(-) Approvals: Tomas Jelinek: Verified Alexander Wels: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b419b560fe1e0bc0c8114d2a34f0bc930756aa0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: set proper default values to Broker.connect() method
by msivak＠redhat.com 25 Jul '14

25 Jul '14

Martin Sivák has submitted this change and it was merged. Change subject: set proper default values to Broker.connect() method ...................................................................... set proper default values to Broker.connect() method Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093646 Change-Id: I2e9c7fc850e1a2f1a6293d5c703d977d1b877523 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/brokerlink.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30696 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e9c7fc850e1a2f1a6293d5c703d977d1b877523 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0