- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine : NPE while using reflection for AsyncTask type
by oourfali＠redhat.com 07 Jul '14

07 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine : NPE while using reflection for AsyncTask type ...................................................................... engine : NPE while using reflection for AsyncTask type If the server is restarted before the async task place holder can be updated with the vdsm id, the async task manager creates a new async task row with action_type unknown. If a command is constructed from this data for CommandAsyncTask VdcActionType Unknown results in no command being found throwing an exception. When action_type is unknown, SPMAsync task is constructed instead of command async task. Change-Id: Ic186992e1f1d4d6a870b323cc018b6cf3e67645a Bug-Url: https://bugzilla.redhat.com/1112557 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskFactory.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Ravi Nori: Verified Arik Hadas: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29156 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic186992e1f1d4d6a870b323cc018b6cf3e67645a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: dal: Remove duplicate fields in VM row mappers
by ofrenkel＠redhat.com 07 Jul '14

07 Jul '14

Omer Frenkel has submitted this change and it was merged. Change subject: dal: Remove duplicate fields in VM row mappers ...................................................................... dal: Remove duplicate fields in VM row mappers Removed duplicate fields that were specified both in AbstractVmRowMapper and its descendants VmStaticRowMapper and VmTemplateRowMapper. Also extracted fields found in both children back to AbstractVmRowMapper. Change-Id: Iab2a3bf9a0deb25b3950f75a351bde4b9e6fef74 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/AbstractVmRowMapper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDAODbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java 4 files changed, 12 insertions(+), 26 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab2a3bf9a0deb25b3950f75a351bde4b9e6fef74 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: avoid findbug issues for encoding and bare exceptions ...
by masayag＠redhat.com 07 Jul '14

07 Jul '14

Moti Asayag has submitted this change and it was merged. Change subject: core: avoid findbug issues for encoding and bare exceptions catch ...................................................................... core: avoid findbug issues for encoding and bare exceptions catch Change-Id: I6f87ad979954807feb68c5fa971da246b01beaef Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Yaniv Bronhaim: Verified Moti Asayag: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f87ad979954807feb68c5fa971da246b01beaef Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Fix return type of vms/{vm:id}/numanodes
by juan.hernandez＠redhat.com 07 Jul '14

07 Jul '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix return type of vms/{vm:id}/numanodes ...................................................................... restapi: Fix return type of vms/{vm:id}/numanodes Currently the type returned by the "list" operation of this resources is "NumaNodes", but it should be "VirtualNumaNodes", otherwise the generator of the Java SDK will not work correctly. Change-Id: I57af48c044012fe9009e51b48c8813114319980b Bug-Url: https://bugzilla.redhat.com/1115610 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmNumaNodesResource.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57af48c044012fe9009e51b48c8813114319980b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Jason Liao <chuan.liao(a)hp.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Allow attach of Storage Domain when retrieve fails
by mlipchuk＠redhat.com 07 Jul '14

07 Jul '14

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Allow attach of Storage Domain when retrieve fails ...................................................................... core: Allow attach of Storage Domain when retrieve fails Allow to complete the command of attach storage domain even when RetrieveImageDataVdsCommand fails. Change-Id: I8b8c572898a07f5d706e2b58c94ce101da6df5ea Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 28 insertions(+), 13 deletions(-) Approvals: Maor Lipchuk: Verified Liron Aravot: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b8c572898a07f5d706e2b58c94ce101da6df5ea Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: intrdoucing host immediate domain recovery mechanism
by laravot＠redhat.com 07 Jul '14

07 Jul '14

Liron Aravot has submitted this change and it was merged. Change subject: core: intrdoucing host immediate domain recovery mechanism ...................................................................... core: intrdoucing host immediate domain recovery mechanism oVirt engine allows hosts to be activated even if they can't access some of the data center's storage domains in case that those domains are marked as "inactive" which means that all the hosts that are already in status up reported them as problematic (therefore there's no need to prevent "new" hosts from being activated). In case that we have an inactive domain that we failed to connect to it's storage server we won't have the link for that domain and we won't be able to produce it (as the mount was possible unavailable when we attempted to connect to the storage server). If the connectivity to that domain will return, host that was already active before might report that he has access to the domain which will cause the engine to change that domain's status to "active". The issue is that hosts that were activated after the connectivity was lost would move to non operational (causing to vm migration..etc) as they possibly won't have connection to the domain (it's a race between the domain status being changed to Active and the domain auto recovery meachanism) and won't have the needed links of that domain. The implemented solution is attempting to prevent hosts from moving to non-operational status to avoid the related affects of it. A new quartz job is set to run every 30 seconds, that job will inspect all reports of hosts that were gatherd since it's last run. The motivation for that implementation is to aggregate the operations on the different hosts together to avoid long wait time and block other "pool" operations. If any hosts has a "new" report on a domain that is active or unknown that it can't access for "storage" reason, those hosts would be reconnected to the active/unknown domains storage servers and will refresh it's storage pool metadata. the engine will attempt to "recover" each host only once for each problematic report to avoid flooding the system with recovery attempts, if the host would still have problem accessing the domain it'll be moved to non operational as usual. Change-Id: Idb7b2fe8c87805986aaf25cd0f24f605d67d4186 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093924 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServerCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ConnectHostToStoragePoolServersParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StoragePoolDomainHelper.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 10 files changed, 363 insertions(+), 56 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27523 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb7b2fe8c87805986aaf25cd0f24f605d67d4186 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: fixing a dependency problem
by oschreib＠redhat.com 07 Jul '14

07 Jul '14

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: fixing a dependency problem ...................................................................... packaging: setup: fixing a dependency problem Fixing a dependency problem moving engine-common import away from base pkg. Change-Id: Id1dd12d87951e322a2863a5723db4cef23a12c2e Bug-url: https://bugzilla.redhat.com/1114978 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/base/dialog/titles.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/dialog/titles.py 2 files changed, 13 insertions(+), 15 deletions(-) Approvals: Simone Tiraboschi: Verified Ofer Schreiber: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1dd12d87951e322a2863a5723db4cef23a12c2e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: API: Interface name is not set via cloud-init api
by oourfali＠redhat.com 07 Jul '14

07 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: API: Interface name is not set via cloud-init api ...................................................................... API: Interface name is not set via cloud-init api Change-Id: I2108863d9ac1463d72b5b5fb139a04fba0f99b0d Bug-Url: https://bugzilla.redhat.com/1115389 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> (cherry picked from commit 42efda3be3c36e0785d114269bcc2b3660c4a138) --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Juan Hernandez: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2108863d9ac1463d72b5b5fb139a04fba0f99b0d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: ui: improve hot plug cpu phrasing
by oourfali＠redhat.com 07 Jul '14

07 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: ui: improve hot plug cpu phrasing ...................................................................... ui: improve hot plug cpu phrasing Change-Id: I8013172ee5410330bad4bfc8f5560ed1eef7988a Bug-Url: https://bugzilla.redhat.com/1114877 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8013172ee5410330bad4bfc8f5560ed1eef7988a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Add gateway & DNS servers columns
by oourfali＠redhat.com 07 Jul '14

07 Jul '14

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Add gateway & DNS servers columns ...................................................................... webadmin: Add gateway & DNS servers columns Added the columns to the external subnet sub-tab under a network, in order to reflect to the user what are the current settings of these fields. Change-Id: I794ee197f31ef89f51f27074d5a8f2a1ca5e51d6 Bug-Url: https://bugzilla.redhat.com/1064749 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> (cherry picked from commit 28d8b6edd41a0786d6caba08bdd7e47aa3cc68fc) --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkExternalSubnetView.java 1 file changed, 26 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Verified Alona Kaplan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I794ee197f31ef89f51f27074d5a8f2a1ca5e51d6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0