- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Add network name to "network used" error message
by lvernia＠redhat.com 19 May '14

19 May '14

Lior Vernia has submitted this change and it was merged. Change subject: engine: Add network name to "network used" error message ...................................................................... engine: Add network name to "network used" error message This to assist users to identify which networks were not created as part of a batch import operation. Change-Id: I238d57ac3ae943aed312f45a2e6b7b4978b8f95b Bug-Url: https://bugzilla.redhat.com/1048752 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 10 insertions(+), 5 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I238d57ac3ae943aed312f45a2e6b7b4978b8f95b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: userportal: Remove unused error NETWORK_NAME_IN_USE
by lvernia＠redhat.com 19 May '14

19 May '14

Lior Vernia has submitted this change and it was merged. Change subject: userportal: Remove unused error NETWORK_NAME_IN_USE ...................................................................... userportal: Remove unused error NETWORK_NAME_IN_USE This error is only used in the webadmin console. Change-Id: I61263b74720bea33d326e6ff7a25f3a1baadc41e Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27815 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61263b74720bea33d326e6ff7a25f3a1baadc41e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Save network configuration by default
by lvernia＠redhat.com 19 May '14

19 May '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Save network configuration by default ...................................................................... webadmin: Save network configuration by default The default used to be to not persist the network configuration, but a user complained that his configuration unexpectedly got wiped. Now the default is to persist the configuration. Change-Id: Ie855130f05291e33df1609878c76e5023527b27c Bug-Url: https://bugzilla.redhat.com/1079691 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/27837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie855130f05291e33df1609878c76e5023527b27c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Allow default profile to turn into ghost entry
by lvernia＠redhat.com 19 May '14

19 May '14

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Allow default profile to turn into ghost entry ...................................................................... webadmin: Allow default profile to turn into ghost entry Previously this was blocked, seemingly because generally ghost toggling events weren't being triggered for the default profile (when it was being update via the network name). This is hopefully fixed by registering for the model event itself. Change-Id: I0330a07a4af5b911aaa5c3214d56ae381771c0cc Bug-Url: https://bugzilla.redhat.com/1064396 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/NetworkProfilesModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.java 3 files changed, 3 insertions(+), 19 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/26885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0330a07a4af5b911aaa5c3214d56ae381771c0cc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: edit running vm
by ofrenkel＠redhat.com 19 May '14

19 May '14

Omer Frenkel has submitted this change and it was merged. Change subject: webadmin: edit running vm ...................................................................... webadmin: edit running vm Update vm-type column in vm main tab to show if vm has next-run configuration. on edit vm, get the next-run configuration if available. Feature page: http://www.ovirt.org/Features/Edit_Running_VM Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1072313 Change-Id: Ica093428d180fb280d53fd40dc5a4109b2aa842e Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmTypeColumn.java A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmType/desktop_changes.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmType/server_changes.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmType/vm_desktop_stateless_changes.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/vmType/vm_server_stateless_changes.png 10 files changed, 100 insertions(+), 18 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27369 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica093428d180fb280d53fd40dc5a4109b2aa842e Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add support to update running vm
by ofrenkel＠redhat.com 19 May '14

19 May '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: add support to update running vm ...................................................................... core: add support to update running vm Allow user update running vm, by saving configuration in a special next_run snapshot (if needed). and restore this configuration once the vm is down. Feature page: http://www.ovirt.org/Features/Edit_Running_VM Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1072313 Change-Id: Ie433352852f53f62e58349ce85475ee89e37ce89 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 16 files changed, 238 insertions(+), 16 deletions(-) Approvals: Roy Golan: Looks good to me, but someone else must approve Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26758 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie433352852f53f62e58349ce85475ee89e37ce89 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Audit log messages - grammar fix
by ahadas＠redhat.com 19 May '14

19 May '14

Arik Hadas has submitted this change and it was merged. Change subject: core: Audit log messages - grammar fix ...................................................................... core: Audit log messages - grammar fix Change-Id: I3a8400104103a4899dfb6b1b908997af51e0631a Bug-Url: https://bugzilla.redhat.com/1017030 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27729 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a8400104103a4899dfb6b1b908997af51e0631a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[master]: codegen: Update generateDS.py version to 2.12a
by juan.hernandez＠redhat.com 19 May '14

19 May '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Update generateDS.py version to 2.12a ...................................................................... codegen: Update generateDS.py version to 2.12a This update is required in order to make sure that empty XML elements aren't lost during conversions. Change-Id: I1fc08804b71aa316262c65ac5a8b6659db467251 Related: https://bugzilla.redhat.com/1091688 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/codegen/xsd/genparams.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fc08804b71aa316262c65ac5a8b6659db467251 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[sdk_3.4]: codegen: Check version of generateDS.py
by juan.hernandez＠redhat.com 19 May '14

19 May '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Check version of generateDS.py ...................................................................... codegen: Check version of generateDS.py Currently we don't check the version of the generateDS.py, as a consecuence the generated code can be different depending on the machine where the code generator is executed. This patch adds a check of the version of generateDS.py, so if isn't the correct one the generation will fail. Change-Id: Iddd3cb4a814db111dc125fbfdf6481d276354517 Related: https://bugzilla.redhat.com/1091688 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 05bc663ecd3ce1e2d20bbbeb45504ed949a9fd7f) --- M src/codegen/xsd/genparams.py 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27836 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iddd3cb4a814db111dc125fbfdf6481d276354517 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-sdk[master]: codegen: Check version of generateDS.py
by juan.hernandez＠redhat.com 19 May '14

19 May '14

Juan Hernandez has submitted this change and it was merged. Change subject: codegen: Check version of generateDS.py ...................................................................... codegen: Check version of generateDS.py Currently we don't check the version of the generateDS.py, as a consecuence the generated code can be different depending on the machine where the code generator is executed. This patch adds a check of the version of generateDS.py, so if isn't the correct one the generation will fail. Change-Id: Iddd3cb4a814db111dc125fbfdf6481d276354517 Related: https://bugzilla.redhat.com/1091688 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/codegen/xsd/genparams.py 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iddd3cb4a814db111dc125fbfdf6481d276354517 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0