- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Vlan id should be shown next to vlan device name
by alkaplan＠redhat.com 19 May '14

19 May '14

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Vlan id should be shown next to vlan device name ...................................................................... webadmin: Vlan id should be shown next to vlan device name In order to show the vlan id next to the vlan device name some changes were done to the host interface sub tab. 1. Removing the address from the brackets next to the vlan device and bond name. 2. Moving the adress column to the VLanPanel next to the network column. All the addresses, vlan and non-vlan will be shown in this column. 3. Splitting the Interface panel into two panels- InterfacePanel and StatisticsPanel. The StatisticsPanel will be the last panel- after the VLanPanel. Notice: there were some look-and-feel issues caused to this tab in commit 0248286a6b70ffe9076731aea406fdbfd6a97b0a. This patch doesn't fix them. Change-Id: Ia900e7d293df479cd9c98cfe66dcd0cb8b1f4fe4 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/BondPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/StatisticsPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/HostInterfaceBondNameRenderer.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/HostVLanNameRenderer.java 9 files changed, 162 insertions(+), 107 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved Lior Vernia: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia900e7d293df479cd9c98cfe66dcd0cb8b1f4fe4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : Refactored gluster volume profile query
by kmayilsa＠redhat.com 19 May '14

19 May '14

Kanagaraj M has submitted this change and it was merged. Change subject: engine : Refactored gluster volume profile query ...................................................................... engine : Refactored gluster volume profile query This patch refactors the volume profile query to take an additional boolean parameter nfs which helps to query the vds for 2 types of stats nfs and brick profile stats Change-Id: I41d80dbb8b6865f67fcadf78baed2a813c423d03 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> Signed-off-by: Sahina Bose <sabose(a)redhat.com> Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeProfileInfoQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeProfileInfoQueryTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterVolumeProfileParameters.java 3 files changed, 68 insertions(+), 9 deletions(-) Approvals: anmolbabu: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41d80dbb8b6865f67fcadf78baed2a813c423d03 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : Refactored gluster volume profile VdsCommand
by kmayilsa＠redhat.com 19 May '14

19 May '14

Kanagaraj M has submitted this change and it was merged. Change subject: engine : Refactored gluster volume profile VdsCommand ...................................................................... engine : Refactored gluster volume profile VdsCommand This patch refactors the volume profile vds command to take an additional boolean parameter nfs which helps to query the glusterfs for 2 types of stats nfs and brick profile stats Change-Id: I26cda9f8603e77296720f2dc062b94d5c10e7fd1 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/BrickProfileDetails.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeProfileInfo.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/NfsProfileDetails.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeProfileInfoVDSParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeProfileInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeProfileInfoReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 9 files changed, 176 insertions(+), 6 deletions(-) Approvals: anmolbabu: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26cda9f8603e77296720f2dc062b94d5c10e7fd1 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: missing final in VmInfoBuilderBase
by gchaplik＠redhat.com 18 May '14

18 May '14

Gilad Chaplik has submitted this change and it was merged. Change subject: core: missing final in VmInfoBuilderBase ...................................................................... core: missing final in VmInfoBuilderBase Auto format fix Change-Id: I2225ae8ccc2f7d404d7cc2997cfb42e75745bbcc Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2225ae8ccc2f7d404d7cc2997cfb42e75745bbcc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: BaseImagesCommand - update disk volume type
by oourfali＠redhat.com 18 May '14

18 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: BaseImagesCommand - update disk volume type ...................................................................... core: BaseImagesCommand - update disk volume type BaseImagesCommand -> endSuccessfully: update disk's VolumeType/VolumeFormat. Specifically in bug context, needed when moving a raw/thin provisioned disk from file domain to block domain. Change-Id: I34f32dfdc0dcf8bad14d114371d9bd0a7314913c Bug-Url: https://bugzilla.redhat.com/1098258 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27813 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34f32dfdc0dcf8bad14d114371d9bd0a7314913c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: tools: add snmp oid validation.
by oourfali＠redhat.com 18 May '14

18 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: tools: add snmp oid validation. ...................................................................... tools: add snmp oid validation. An oid is valid iff 2 <= size() <= 128 and if the first two sub-identifiers are less than 3 and 40 respectively. Emtpy values are not valid. a missing value already generates an exception when getting property. Change-Id: I2469bfac312eb38dad7de093c8fefe144f75bbb2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1073498 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve mooli tayer: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2469bfac312eb38dad7de093c8fefe144f75bbb2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: BaseImagesCommand - update disk volume type
by derez＠redhat.com 18 May '14

18 May '14

Daniel Erez has submitted this change and it was merged. Change subject: core: BaseImagesCommand - update disk volume type ...................................................................... core: BaseImagesCommand - update disk volume type BaseImagesCommand -> endSuccessfully: update disk's VolumeType/VolumeFormat. Specifically in bug context, needed when moving a raw/thin provisioned disk from file domain to block domain. Change-Id: I34f32dfdc0dcf8bad14d114371d9bd0a7314913c Bug-Url: https://bugzilla.redhat.com/1098258 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34f32dfdc0dcf8bad14d114371d9bd0a7314913c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: history: updated network_name in dwh views
by emesika＠redhat.com 18 May '14

18 May '14

Eli Mesika has submitted this change and it was merged. Change subject: history: updated network_name in dwh views ...................................................................... history: updated network_name in dwh views updated network_name to logical_network_name in dhw views. Change-Id: I9b3317062760a7d854ebb90ce6320cbeb73d98bb Bug-Url: https://bugzilla.redhat.com/891073 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/dbscripts/create_dwh_views.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Eli Mesika: Looks good to me, approved Yaniv Dary: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b3317062760a7d854ebb90ce6320cbeb73d98bb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: removed unused member from command test
by derez＠redhat.com 18 May '14

18 May '14

Daniel Erez has submitted this change and it was merged. Change subject: core: removed unused member from command test ...................................................................... core: removed unused member from command test Removed unused member from RemoveDiskSnapshotsCommandTest Change-Id: I4c88d40f0ecfa0235d0e801e2a8013e78bc29bd6 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandTest.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c88d40f0ecfa0235d0e801e2a8013e78bc29bd6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Added download_image to StepEnum for monitoring
by derez＠redhat.com 18 May '14

18 May '14

Daniel Erez has submitted this change and it was merged. Change subject: core: Added download_image to StepEnum for monitoring ...................................................................... core: Added download_image to StepEnum for monitoring Added DOWNLOAD_IMAGE to StepEnum and ExecutionMessages for proper task monitoring (currently used by ImportRepoImageCopyTaskHandler and DownloadImageVDSCommand). Change-Id: I2ee2669edff2d385d759fba3bf7caf77d89efecf Related-To: https://bugzilla.redhat.com/1074311 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCopyTaskHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/StepEnum.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DownloadImageVDSCommand.java 4 files changed, 4 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ee2669edff2d385d759fba3bf7caf77d89efecf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0