- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: frontend: introduced the detachable widgets into the VM dialogs
by tjelinek＠redhat.com 05 May '14

05 May '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: introduced the detachable widgets into the VM dialogs ...................................................................... frontend: introduced the detachable widgets into the VM dialogs Wrapped the widgets which are supposed to be detachable by the detachable widgets (for details on which this are please see the wiki) in the VM dialgos + added the configuration needed to make this widgets detachable in new/edit VM and new/edit pool dialogs feature page: http://www.ovirt.org/Features/Instance_Types Change-Id: I990325e4ec554f0cdd84f6a2bb8772f1d71c705f Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolEditPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolNewPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmPopupWidget.java 5 files changed, 289 insertions(+), 158 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I990325e4ec554f0cdd84f6a2bb8772f1d71c705f Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <laszlo.hornyak(a)gmail.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Warning when deleting an instance type which is at...
by tjelinek＠redhat.com 05 May '14

05 May '14

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Warning when deleting an instance type which is attached to a VM ...................................................................... webadmin: Warning when deleting an instance type which is attached to a VM Frontend part: when deleting an instance type which has VMs based on it, the user will be warned and he/she will have to explicitly approve it. Change-Id: I14bf7cecee9e9a2caa43c51e4f3e4682b63e0a1e Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/instancetypes/InstanceTypeListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/InstanceTypeModelProvider.java 4 files changed, 72 insertions(+), 29 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14bf7cecee9e9a2caa43c51e4f3e4682b63e0a1e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Client shortcuts for VNC sessions
by tjelinek＠redhat.com 05 May '14

05 May '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Client shortcuts for VNC sessions ...................................................................... frontend: Client shortcuts for VNC sessions This patch - adds client shortcut mapping for toggling fullscreen and releasing cursor to VNC descriptor file (.vv file), - sets VNC client window name in the same way SPICE does it, i.e.: (<vm name>:<display number> - <release cursor shortcut>) Change-Id: Ic292e62743debf3c7af11497b74c607ebbaa98bb Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1083766 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractVnc.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/VncNativeImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/IVnc.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java 6 files changed, 67 insertions(+), 27 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26881 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic292e62743debf3c7af11497b74c607ebbaa98bb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: "escape" underscores in spice menu
by tjelinek＠redhat.com 05 May '14

05 May '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: "escape" underscores in spice menu ...................................................................... frontend: "escape" underscores in spice menu this patch doubles underscores in spice menu since single underscore is interpreted as a hotkey by gtk and is not printed (i.e. fedora_20.iso was printed as fedora20.iso). Change-Id: Ibb090a6ae37aad234bf815c40b8dd5a051b24879 Bug-Url: https://bugzilla.redhat.com/963307 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceMenu.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/27033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb090a6ae37aad234bf815c40b8dd5a051b24879 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in jenkins[master]: Fixed issue with non-existing config option
by dcaroest＠redhat.com 05 May '14

05 May '14

David Caro has submitted this change and it was merged. Change subject: Fixed issue with non-existing config option ...................................................................... Fixed issue with non-existing config option When using a mock configuration wothout yum.conf option, it will fail on missing key. Change-Id: Ie7d79734dfb8da64dc1518e8fab4c9a10a2f9f39 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M mock_configs/mock_genconfig 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ewoud Kohl van Wijngaarden: Looks good to me, but someone else must approve David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27381 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7d79734dfb8da64dc1518e8fab4c9a10a2f9f39 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>

1 0

Change in ovirt-engine[master]: frontend: Always assume GuestAgent to be present for SSO req...
by tjelinek＠redhat.com 05 May '14

05 May '14

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Always assume GuestAgent to be present for SSO requests ...................................................................... frontend: Always assume GuestAgent to be present for SSO requests Motivation: There are already so many different names for the guest agent and their versions that it is an impossible task for the engine to maintain that. And it's unreliable for such cases. Besides that, it doesn't tell the engine anyway if there's SSO support or not. Using the application list to identify the guest agent version is not a good idea. Instead we'll check in VDSM whether or not the guest agent is there, since it gets a heartbeat it'll know early enough if it is responsive and only then forward the desktopLogin request. http://gerrit.ovirt.org/27147 Change-Id: Iac7271b4284cc40868ac21ce7eaa4f9ac5e19371 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Vinzenz Feenstra: Verified Frank Kobzik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac7271b4284cc40868ac21ce7eaa4f9ac5e19371 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-engine-3.4]: packaging: setup: Do not check jasper home existance
by ydary＠redhat.com 05 May '14

05 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Do not check jasper home existance ...................................................................... packaging: setup: Do not check jasper home existance as it might not exist - we want to allow: $ yum install ovirt-engine ovirt-engine-reports-setup $ engine-setup and have jasperreports installed by setup. Keep the check for developer mode. Change-Id: I03c17c01c4d8bad7dadfda21ea60eb6d671637df Bug-Url: https://bugzilla.redhat.com/1093360 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit cb9f81c828a591293c67eedc930c6b968adfbb96) --- M packaging/setup/ovirt_engine_setup/reportsconstants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/jasper.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 4 files changed, 19 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27379 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03c17c01c4d8bad7dadfda21ea60eb6d671637df Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: packaging: setup: Do not check jasper home existance
by ydary＠redhat.com 05 May '14

05 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Do not check jasper home existance ...................................................................... packaging: setup: Do not check jasper home existance as it might not exist - we want to allow: $ yum install ovirt-engine ovirt-engine-reports-setup $ engine-setup and have jasperreports installed by setup. Keep the check for developer mode. Change-Id: I03c17c01c4d8bad7dadfda21ea60eb6d671637df Bug-Url: https://bugzilla.redhat.com/1093360 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/reportsconstants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/jasper.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 4 files changed, 19 insertions(+), 0 deletions(-) Approvals: Yedidyah Bar David: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03c17c01c4d8bad7dadfda21ea60eb6d671637df Gerrit-PatchSet: 6 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core, webadmin: Add host# and vm# to cluster tab
by emesika＠redhat.com 05 May '14

05 May '14

Eli Mesika has submitted this change and it was merged. Change subject: core, webadmin: Add host# and vm# to cluster tab ...................................................................... core, webadmin: Add host# and vm# to cluster tab In webadmin add an ability to see the count of VMs and Hosts for a cluster Change-Id: I9935c67db2a88960cd721aec4bfd71e70c9b4f57 Bug-Url: https://bugzilla.redhat.com/1084120 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroupHostsAndVMs.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDAOTest.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabClusterView.java M packaging/dbscripts/vds_groups_sp.sql 9 files changed, 162 insertions(+), 5 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9935c67db2a88960cd721aec4bfd71e70c9b4f57 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Batch updates might create a database deadlock
by yzaslavs＠redhat.com 05 May '14

05 May '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Batch updates might create a database deadlock ...................................................................... core: Batch updates might create a database deadlock Batch updates might create a database deadlock in systems under load Sorting the batch collection by id should solve this problem Change-Id: I1f1868c7a76ea50257f40929573e36ad304c353c Bug-Url: https://bugzilla.redhat.com/1092299 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MassOperationsGenericDaoDbFacade.java 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Liran Zelkha: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f1868c7a76ea50257f40929573e36ad304c353c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0