- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Validate Step Enum (#1092448)
by oliel＠redhat.com 05 May '14

05 May '14

Ori Liel has submitted this change and it was merged. Change subject: restapi: Validate Step Enum (#1092448) ...................................................................... restapi: Validate Step Enum (#1092448) Up until now, if user supplied invalid step-type, the server would fail. This patch adds a validation that the step-type is valid Bug-Url: http://bugzilla.redhat.com/1092448 Change-Id: I7768fb15b0f9c5924cab0f4e2238cf49d21eb655 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepsResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/StepValidator.java 2 files changed, 18 insertions(+), 0 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7768fb15b0f9c5924cab0f4e2238cf49d21eb655 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix Coverty report for CollectVdsNetworkDataVDSCommand
by masayag＠redhat.com 05 May '14

05 May '14

Moti Asayag has submitted this change and it was merged. Change subject: engine: Fix Coverty report for CollectVdsNetworkDataVDSCommand ...................................................................... engine: Fix Coverty report for CollectVdsNetworkDataVDSCommand Add check if engineDisplayNetwork is not null prior accessing its name. Change-Id: I854e51346c01eb57d424a342d13754e17f32f221 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/27371 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I854e51346c01eb57d424a342d13754e17f32f221 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-engine-3.4]: packaging: setup: Removing build-conf files on failure
by ydary＠redhat.com 05 May '14

05 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Removing build-conf files on failure ...................................................................... packaging: setup: Removing build-conf files on failure If setup fails it should cleanup the partially deployed files in order to allow a future clean setup. If those files were already there it restores the backup copy of the older ones, otherwise it simply removes the new files. Change-Id: I2507ea0c6ecd6d0a69f56d0693fcafd21f58992f Bug-Url: https://bugzilla.redhat.com/1091700 Bug-Url: https://bugzilla.redhat.com/1084749 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> (cherry picked from commit 5c99c747baa3013f60bd1d2dd77cc316ccae7c2c) --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/connection.py 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2507ea0c6ecd6d0a69f56d0693fcafd21f58992f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: packaging: setup: Removing build-conf files on failure
by ydary＠redhat.com 05 May '14

05 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: Removing build-conf files on failure ...................................................................... packaging: setup: Removing build-conf files on failure If setup fails it should cleanup the partially deployed files in order to allow a future clean setup. If those files were already there it restores the backup copy of the older ones, otherwise it simply removes the new files. Change-Id: I2507ea0c6ecd6d0a69f56d0693fcafd21f58992f Bug-Url: https://bugzilla.redhat.com/1091700 Bug-Url: https://bugzilla.redhat.com/1084749 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/connection.py 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27167 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2507ea0c6ecd6d0a69f56d0693fcafd21f58992f Gerrit-PatchSet: 18 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Skip empty bridge mappings
by oourfali＠redhat.com 05 May '14

05 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Skip empty bridge mappings ...................................................................... engine: Skip empty bridge mappings If the user hasn't provided bridge mappings, there is no need to pass it to ovirt host deploy. Change-Id: Iaf2337d837ddb456f1c6bb70e2aec96394d2a2ea Bug-Url: https://bugzilla.redhat.com/1093994 Bug-Url: https://bugzilla.redhat.com/1086789 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, but someone else must approve Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf2337d837ddb456f1c6bb70e2aec96394d2a2ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: host-deploy: upgrade to apache-sshd 0.11.0
by oourfali＠redhat.com 05 May '14

05 May '14

Oved Ourfali has submitted this change and it was merged. Change subject: host-deploy: upgrade to apache-sshd 0.11.0 ...................................................................... host-deploy: upgrade to apache-sshd 0.11.0 use of fedora package will be added when fedora provide updated package. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1094123 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093882 Change-Id: I6943590f1c479e71633dcce1180028e06c9a9a17 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dependencies/pom.xml D backend/manager/dependencies/src/main/modules/org/apache/mina/main/module.xml M backend/manager/dependencies/src/main/modules/org/apache/sshd/main/module.xml M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHD.java M ear/src/main/resources/META-INF/MANIFEST.MF M ovirt-engine.spec.in M pom.xml 7 files changed, 20 insertions(+), 41 deletions(-) Approvals: Alon Bar-Lev: Verified Douglas Schilling Landgraf: Verified; Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26777 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6943590f1c479e71633dcce1180028e06c9a9a17 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: [RFE] Improve fencing robustness by retrying...
by emesika＠redhat.com 04 May '14

04 May '14

Eli Mesika has submitted this change and it was merged. Change subject: [RFE] Improve fencing robustness by retrying... ...................................................................... [RFE] Improve fencing robustness by retrying... Improve fencing robustness by retrying failed attempts This patch adds the following logic to the fencing flow: In case that a fencing action is failed, an attempt to repeat the failed action with a different proxy from that used in the failed operation is done. In case that no such proxy is available, the operation is repeated with the same proxy. Change-Id: I817e8a03695d02ee3f59fbefe0fe41483c3989fe Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=961753 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java 1 file changed, 30 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/27309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I817e8a03695d02ee3f59fbefe0fe41483c3989fe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: reports: br12 report - added comments to queries
by ydary＠redhat.com 04 May '14

04 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: br12 report - added comments to queries ...................................................................... reports: br12 report - added comments to queries Changed the code structure so it will be more readable and added commets. Change-Id: I20b1e3ee63a6436acdf1772f247e649f6cb2b1b0 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/five_least_utilized_vms_Over_Time_BR12_files/five_least_utilized_vms_Over_Time_BR12_jrxml.data M packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/five_least_utilized_vms_Over_Time_BR12_files/full details.jrxml.data 2 files changed, 669 insertions(+), 454 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20b1e3ee63a6436acdf1772f247e649f6cb2b1b0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-reports[master]: reports: br3 report - added comments to queries
by ydary＠redhat.com 04 May '14

04 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: reports: br3 report - added comments to queries ...................................................................... reports: br3 report - added comments to queries Changed the code structure so it will be more readable and added commets. Change-Id: I68b44f03aba394cbc7d7410d71f38dabccb69355 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/ovirt-reports/resources/Reports/Trend/Hosts/multiple_hosts_resource_usage_br3_files/br3 full details.jrxml.data M packaging/ovirt-reports/resources/Reports/Trend/Hosts/multiple_hosts_resource_usage_br3_files/multiple_hosts_resource_usage_br3_jrxml.data 2 files changed, 674 insertions(+), 487 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26449 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68b44f03aba394cbc7d7410d71f38dabccb69355 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-dwh[master]: packaging: setup: pep8 fixes
by ydary＠redhat.com 04 May '14

04 May '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: pep8 fixes ...................................................................... packaging: setup: pep8 fixes Change-Id: Idba85ca5e2183967462b2b35f978e2f9a1529b10 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/schema.py 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idba85ca5e2183967462b2b35f978e2f9a1529b10 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0