- Engine-commits - oVirt List Archives

Change in ovirt-log-collector[ovirt-log-collector-3.3]: sos: engine: don't collect db passwords
by sbonazzo＠redhat.com 03 Feb '14

03 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: engine: don't collect db passwords ...................................................................... sos: engine: don't collect db passwords obfuscate sensitive keys in collected configs. avoid to collect legacy empty files. Change-Id: I169d47db602584093210bc4795ff64abc22824fc Bug-Url: https://bugzilla.redhat.com/1060670 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 2122d59b43af58bf72f2e7bc2b614735f9362f24) (cherry picked from commit 0a858e64ed2b4145982e257d8c7802048b7fd2af) --- M src/__main__.py M src/config.py.in.in M src/sos/plugins/engine.py 3 files changed, 72 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I169d47db602584093210bc4795ff64abc22824fc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix NPEx vulnerabities related to osinfo change
by tjelinek＠redhat.com 03 Feb '14

03 Feb '14

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: Fix NPEx vulnerabities related to osinfo change ...................................................................... engine: Fix NPEx vulnerabities related to osinfo change This patch fixes couple of NPEx vulnerabities related to ConsolesBase and OS info in AsyncDataProvider. The vulnerabities happened when changes in osinfo caused invalidity of VMs already stored in the database. The problem was fixed by introducing null checks in appropriate places and a map with the possibility of returning default value if requested key is not found. Change-Id: I04713a90374cac30fd358fdd0fcf02d2a020d477 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1046809 --- A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/MapWithDefaults.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsoleModelsCache.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsolesBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 5 files changed, 74 insertions(+), 31 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/23809 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04713a90374cac30fd358fdd0fcf02d2a020d477 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.4]: sos: engine: collect full service configuration
by sbonazzo＠redhat.com 03 Feb '14

03 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: engine: collect full service configuration ...................................................................... sos: engine: collect full service configuration Collect also /var/tmp/ovirt-engine/config content. Change-Id: Id41c3859731a77cb2c771d327730c277b81a8c54 Bug-Url: https://bugzilla.redhat.com/1035825 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 4f09866ebf9afd3462d02a0e1d349093bae592b9) --- M src/sos/plugins/engine.py 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id41c3859731a77cb2c771d327730c277b81a8c54 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: sos: engine: collect full service configuration
by sbonazzo＠redhat.com 03 Feb '14

03 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: engine: collect full service configuration ...................................................................... sos: engine: collect full service configuration Collect also /var/tmp/ovirt-engine/config content. Change-Id: Id41c3859731a77cb2c771d327730c277b81a8c54 Bug-Url: https://bugzilla.redhat.com/1035825 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/sos/plugins/engine.py 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id41c3859731a77cb2c771d327730c277b81a8c54 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <simone.tiraboschi(a)gmail.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.4]: sos: engine: don't collect db passwords
by sbonazzo＠redhat.com 03 Feb '14

03 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: engine: don't collect db passwords ...................................................................... sos: engine: don't collect db passwords obfuscate sensitive keys in collected configs. avoid to collect legacy empty files. Change-Id: I169d47db602584093210bc4795ff64abc22824fc Bug-Url: https://bugzilla.redhat.com/1035826 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit 2122d59b43af58bf72f2e7bc2b614735f9362f24) --- M src/__main__.py M src/config.py.in.in M src/sos/plugins/engine.py 3 files changed, 72 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I169d47db602584093210bc4795ff64abc22824fc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: distro-rpm: fix typo in new package detection
by sbonazzo＠redhat.com 03 Feb '14

03 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: distro-rpm: fix typo in new package detection ...................................................................... packaging: setup: distro-rpm: fix typo in new package detection Change-Id: Ibb2aa3ce1f1d9f0d4c5b250e0f70cbe22e931b71 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb2aa3ce1f1d9f0d4c5b250e0f70cbe22e931b71 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: 'concurrent' Not Displayed For Primary PM Agent
by oliel＠redhat.com 03 Feb '14

03 Feb '14

Ori Liel has submitted this change and it was merged. Change subject: restapi: 'concurrent' Not Displayed For Primary PM Agent ...................................................................... restapi: 'concurrent' Not Displayed For Primary PM Agent When there's more than one Power-Management agents, the field 'concurrent' becomes relevant. Prior to this fix, this field would only exist in the secondary agent. After this fix, this field will also exist in the first agent Change-Id: If0882d1db6c13b24c767e0cb40b9b797e8b61860 Bug-Url: http://bugzilla.redhat.com/977674 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0882d1db6c13b24c767e0cb40b9b797e8b61860 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: managed removal of memory volumes in negative flows
by iheim＠redhat.com 02 Feb '14

02 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: managed removal of memory volumes in negative flows ...................................................................... core: managed removal of memory volumes in negative flows On failure while importing VM or creating snapshot with memory, we need to remove the memory volumes that were copied/created. The remove image operation is asynchronous, i.e it is based on tasks. On negative flows such as the ones mentioned above, we need to remove the memory image in the end-action phase. Since our infrastructure for commands doesn't support scenarios where tasks are created in the end-action phase well, we used to create the tasks for the remove operation without polling them. The problem was that without polling the tasks they remained in VDSM forever. The solution is to invoke the command that removes memory volumes as a stand-alone command, and not as a child of the failed command. It means that the tasks will be created as tasks of RemoveMemoryVolumesCommand and thus its end-action methods will be called and not the ones of the failed command. Change-Id: Ib4b270ec0e1ab41cae34459dde9f9cf47b1b5bdf Bug-Url: https://bugzilla.redhat.com/1056598 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMemoryVolumesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverOnDataDomain.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveMemoryVolumesParameters.java 7 files changed, 114 insertions(+), 58 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/23831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4b270ec0e1ab41cae34459dde9f9cf47b1b5bdf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: fix typo in VdsDeploy
by iheim＠redhat.com 02 Feb '14

02 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: fix typo in VdsDeploy ...................................................................... core: fix typo in VdsDeploy Change-Id: I6d5b0784be20e37f95348af33a217dead0fd5ffb Bug-Url: https://bugzilla.redhat.com/1056307 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Eli Mesika: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23944 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d5b0784be20e37f95348af33a217dead0fd5ffb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: block virtio-scsi for unsupported OSes
by iheim＠redhat.com 02 Feb '14

02 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: block virtio-scsi for unsupported OSes ...................................................................... core: block virtio-scsi for unsupported OSes Block VirtIO-SCSI for unsupported operation systems: * Added isOsTypeSupportedForVirtioScsi method to VmHandler. * Added an appropriate VdcBllMessage. * Modified AddVmCommand and UpdateVmCommand accordingly. * Updated tests. Change-Id: Id9907d35b53c0447662bc638146c4c61ac5cce8a Bug-Url: https://bugzilla.redhat.com/1038613 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 131 insertions(+), 12 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9907d35b53c0447662bc638146c4c61ac5cce8a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0