- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: core: validate disks existence on create snapshot
by iheim＠redhat.com 02 Feb '14

02 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: validate disks existence on create snapshot ...................................................................... core: validate disks existence on create snapshot CreateAllSnapshotsFromVmCommand: Added validation for specified disks existence. * Included disks IDs in CanDo message. * Updated tests accordingly. Change-Id: I4d75ad139d048f83b08d9289e43d909b29f89695 Bug-Url: https://bugzilla.redhat.com/1057143 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskImagesValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 86 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23862 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d75ad139d048f83b08d9289e43d909b29f89695 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Don't attach external networks to NIC by label
by iheim＠redhat.com 02 Feb '14

02 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Don't attach external networks to NIC by label ...................................................................... webadmin: Don't attach external networks to NIC by label External networks shouldn't be statically attached to a host's interface, neither manually nor by label. Change-Id: I202843bce1635facda3228855e8b2569370e4ed6 Bug-Url: https://bugzilla.redhat.com/1059233 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/23858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I202843bce1635facda3228855e8b2569370e4ed6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Remove redundant else
by iheim＠redhat.com 02 Feb '14

02 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Remove redundant else ...................................................................... core: Remove redundant else There is no use for the else phase since when the if condition is true we already throw an exception. Change-Id: Idb49270dc895dd38752b1d49a070c4e11d891242 Related to Bug-Url: https://bugzilla.redhat.com/1037441 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/23914 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb49270dc895dd38752b1d49a070c4e11d891242 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Propagate the exception from VDSM to the user
by iheim＠redhat.com 02 Feb '14

02 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Propagate the exception from VDSM to the user ...................................................................... core: Propagate the exception from VDSM to the user Propagate the exception got from VDSM instead replacing it every time. Change-Id: Ief319b187950fe188b54aad240e59cda807c0ef9 Related to Bug-Url: https://bugzilla.redhat.com/1037441 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/23913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief319b187950fe188b54aad240e59cda807c0ef9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Use shorter scope for try catch block
by iheim＠redhat.com 02 Feb '14

02 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Use shorter scope for try catch block ...................................................................... core: Use shorter scope for try catch block There is no need to put try catch block on createTask since it is already swallows the exception in CommandBase. Change-Id: Icbdfa7acaac633a1e2010db5fd9fc9afe4fab219 Related to Bug-Url: https://bugzilla.redhat.com/1037441 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java 1 file changed, 13 insertions(+), 12 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/23912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbdfa7acaac633a1e2010db5fd9fc9afe4fab219 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Execute clear tasks with new thread.
by iheim＠redhat.com 02 Feb '14

02 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Execute clear tasks with new thread. ...................................................................... core: Execute clear tasks with new thread. clearAsyncTasksWithOutVdsmId is executed at the finally step when executing a vdc command. If the execute phase encountered a problem, the engine sets the transaction to rollback only and we can not use it any more. Since the clearAsyncTasksWithOutVdsmId uses calls to the DB, the engine throws an EJBTransactionRolledbackException, and the original exception does not seep to the user. The proposed solution is to clear the async tasks with a new transaction, so it will not be dependent on the related execute phase. Change-Id: I3434c2dbd605e741b2cfbbede8c4a120f21ca9fe Bug-Url: https://bugzilla.redhat.com/1037441 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 14 insertions(+), 5 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/23911 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3434c2dbd605e741b2cfbbede8c4a120f21ca9fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: rewrite
by ydary＠redhat.com 02 Feb '14

02 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: rewrite ...................................................................... packaging: setup: rewrite upgrade from legacy is not supported. Change-Id: I7ba43528b49d39019288819b5a54bf5a0514a677 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile M build/python-check.sh.in M ovirt-engine-reports.spec.in D packaging/legacy-setup/common_utils.py D packaging/legacy-setup/decorators.py D packaging/legacy-setup/ovirt-engine-reports-setup.py D packaging/legacy-setup/ssl2jkstrust.py A packaging/setup/ovirt_engine_setup/reportsconfig.py.in A packaging/setup/ovirt_engine_setup/reportsconstants.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/core/__init__.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/core/misc.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/__init__.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/connection.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/db/pgpass.py A packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-reports/db/__init__.py A packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-reports/db/clear.py A packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-reports/jasper/__init__.py A packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-reports/jasper/clear.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/apache/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/apache/reports.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/admin.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/jasper.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/sso.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/db/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/db/connection.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/distro-rpm/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/distro-rpm/packages.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/provisioning/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/provisioning/postgres.py 34 files changed, 3,134 insertions(+), 2,610 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ba43528b49d39019288819b5a54bf5a0514a677 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Filter storage domains of different type in live s...
by tnisan＠redhat.com 02 Feb '14

02 Feb '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Filter storage domains of different type in live storage migration ...................................................................... webadmin: Filter storage domains of different type in live storage migration This change filters the destination domain by the type of the source domain when performing live storage migration, if the source domain is a file domain, the destination domains that will appear will be only file domains and vice versa Change-Id: I94f9feb9eb2b678e76653bed0b022ed05af40fc1 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MoveDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/DisksAllocationPopupView.ui.xml 5 files changed, 49 insertions(+), 17 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23769 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94f9feb9eb2b678e76653bed0b022ed05af40fc1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Block live storage migration to domain of a different ...
by tnisan＠redhat.com 02 Feb '14

02 Feb '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Block live storage migration to domain of a different type ...................................................................... core: Block live storage migration to domain of a different type This change fails live storage migration CDA part in case that the source storage domain and the destination domain are not both either a file type domain or a block domain Change-Id: Iec4c34132a1a619527627cfa47fa99df3a023b62 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 77 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec4c34132a1a619527627cfa47fa99df3a023b62 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Edit data center dialog chooses shared type as def...
by tnisan＠redhat.com 02 Feb '14

02 Feb '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Edit data center dialog chooses shared type as default ...................................................................... webadmin: Edit data center dialog chooses shared type as default When editing a data center, the type combo box was always set to shared regardless of the actual data center type Change-Id: Iaaaf55768a72bc6f3f1349077ee9d54f41aa4995 Bug-Url: https://bugzilla.redhat.com/1057155 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaaaf55768a72bc6f3f1349077ee9d54f41aa4995 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0