- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Add tests to StorageHandlingCommandBaseTest
by tnisan＠redhat.com 02 Feb '14

02 Feb '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Add tests to StorageHandlingCommandBaseTest ...................................................................... core: Add tests to StorageHandlingCommandBaseTest Since the removal of DC type it's important to have test to test the logic of whether attachment of domains to a pool is allowed, this patch adds tests for the StorageHandlingCommandBase which holds most of the logic that determines attachment is allowed Change-Id: I97e45957f7ff0fe4c9e7d88e0d8dbab7e874c79b Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Relates-To: https://bugzilla.redhat.com/1038053 --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CanDoActionTestUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java 2 files changed, 212 insertions(+), 18 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23522 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97e45957f7ff0fe4c9e7d88e0d8dbab7e874c79b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix validate() in EditDiskModel
by tnisan＠redhat.com 02 Feb '14

02 Feb '14

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix validate() in EditDiskModel ...................................................................... webadmin: Fix validate() in EditDiskModel EditDiskModel validate() called parent validate method but ignored its results. Change-Id: I5df677f42b76b07d489a698978f62bd5df02c415 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Daniel Erez: Looks good to me, approved Sergey Gotliv: Verified -- To view, visit http://gerrit.ovirt.org/23959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5df677f42b76b07d489a698978f62bd5df02c415 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Remove redundant super.validate() from NewDiskModel
by derez＠redhat.com 02 Feb '14

02 Feb '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Remove redundant super.validate() from NewDiskModel ...................................................................... webadmin: Remove redundant super.validate() from NewDiskModel NewDiskModel validate() contained 2 calls to the super.validate() when result of the first call is completely ignored. Change-Id: Id744a08dd74d1536218363f3d9f19cd13cc4c97b Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Sergey Gotliv: Verified -- To view, visit http://gerrit.ovirt.org/23958 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id744a08dd74d1536218363f3d9f19cd13cc4c97b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: history: Added is_local_storage to dwh_datacenter_configurat...
by emesika＠redhat.com 02 Feb '14

02 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: history: Added is_local_storage to dwh_datacenter_configuration_history_view ...................................................................... history: Added is_local_storage to dwh_datacenter_configuration_history_view This patch adds is_local_storage to dwh_datacenter_configuration_history_view A storage pool can be marked as local - contains local on host storage or shared - contains shared storages of various types. Change-Id: I5100ec6dd030b096f8fa1f644f4e2b8be8916817 Related-To: https://bugzilla.redhat.com/1038053 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/dbscripts/create_dwh_views.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved Yaniv Dary: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5100ec6dd030b096f8fa1f644f4e2b8be8916817 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Hide panels related to Host Network QoS
by derez＠redhat.com 02 Feb '14

02 Feb '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Hide panels related to Host Network QoS ...................................................................... webadmin: Hide panels related to Host Network QoS Due to missing capabilities on the VDSM side, this patch hides the GUI elements related to the Host Network QoS feature, effectively making this a "dormant" feature. It does this simply by rendering containing panels invisible for the moment, and should be easily-revertible when the functionality is implemented. Change-Id: Ibd7eb87542dc460ad09615fb850cc0354375d3e3 Bug-Url: https://bugzilla.redhat.com/1043230 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.ui.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Gilad Chaplik: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/23897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd7eb87542dc460ad09615fb850cc0354375d3e3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Don't attach external networks to NIC by label
by derez＠redhat.com 02 Feb '14

02 Feb '14

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Don't attach external networks to NIC by label ...................................................................... webadmin: Don't attach external networks to NIC by label External networks shouldn't be statically attached to a host's interface, neither manually nor by label. Change-Id: I202843bce1635facda3228855e8b2569370e4ed6 Bug-Url: https://bugzilla.redhat.com/1059233 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/23857 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I202843bce1635facda3228855e8b2569370e4ed6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: sync proxy settings with engine
by ydary＠redhat.com 02 Feb '14

02 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: sync proxy settings with engine ...................................................................... packaging: setup: sync proxy settings with engine Change-Id: I7bb02d94390d1514aa7fafafe328a4444c773d85 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/conf/ovirt-engine-reports-proxy.conf.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23957 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bb02d94390d1514aa7fafafe328a4444c773d85 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Add warning when modifying management network
by iheim＠redhat.com 01 Feb '14

01 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Add warning when modifying management network ...................................................................... webadmin: Add warning when modifying management network Added warning that certain changes in the management network's properties could lead to loss of connectivity to hosts in the DC. Change-Id: Icf768a00fc78335227e77f23ed6b9ffe1aac39ec Bug-Url: https://bugzilla.redhat.com/906359 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 33 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/23893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf768a00fc78335227e77f23ed6b9ffe1aac39ec Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Hide panels related to Host Network QoS
by iheim＠redhat.com 01 Feb '14

01 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Hide panels related to Host Network QoS ...................................................................... webadmin: Hide panels related to Host Network QoS Due to missing capabilities on the VDSM side, this patch hides the GUI elements related to the Host Network QoS feature, effectively making this a "dormant" feature. It does this simply by rendering containing panels invisible for the moment, and should be easily-revertible when the functionality is implemented. Change-Id: Ibd7eb87542dc460ad09615fb850cc0354375d3e3 Bug-Url: https://bugzilla.redhat.com/1043230 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.ui.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/23898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd7eb87542dc460ad09615fb850cc0354375d3e3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: bin: instruct answer file at --config-appe...
by iheim＠redhat.com 31 Jan '14

31 Jan '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: bin: instruct answer file at --config-append usage ...................................................................... packaging: setup: bin: instruct answer file at --config-append usage Change-Id: I715a4d3f2037a147a0442e81b73029807651483b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/bin/ovirt-engine-remove M packaging/setup/bin/ovirt-engine-rename M packaging/setup/bin/ovirt-engine-setup 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23945 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I715a4d3f2037a147a0442e81b73029807651483b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0