- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Extract base class NetworkParametersBuilder
by masayag＠redhat.com 24 Dec '13

24 Dec '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Extract base class NetworkParametersBuilder ...................................................................... engine: Extract base class NetworkParametersBuilder The class will serve as a base class for setupNetworks parameters builders in the various scenarios: sync networks, adding networks or removing a network. Change-Id: I936cc52bf2c0badf0289e1afbd4af1c1617aa6b2 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 2 files changed, 26 insertions(+), 16 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/22707 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I936cc52bf2c0badf0289e1afbd4af1c1617aa6b2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Refactor InterfaceDaoDbFacadeImpl
by masayag＠redhat.com 24 Dec '13

24 Dec '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Refactor InterfaceDaoDbFacadeImpl ...................................................................... engine: Refactor InterfaceDaoDbFacadeImpl Reduced amount of duplicated code, cleared eclipse warnings and mostly shortening this class. There is still way to go: changing this class to inherit from DefaultGenericDaoDbFacade. Change-Id: I4a46cf2ea27c163ab5ed4fd7c03be37314d9e354 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java 1 file changed, 38 insertions(+), 88 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/22636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a46cf2ea27c163ab5ed4fd7c03be37314d9e354 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add labels to host interface
by masayag＠redhat.com 24 Dec '13

24 Dec '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Add labels to host interface ...................................................................... engine: Add labels to host interface Adding the labels property to the host nic entity to manage the networks to be attach to the nic by that label. Change-Id: I6552eb2b8414c7cff77407872ae72bd0ae72f8c2 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/create_views.sql M packaging/dbscripts/network_sp.sql A packaging/dbscripts/upgrade/03_04_0310_add_labels_column_to_vds_interfaces.sql 6 files changed, 41 insertions(+), 11 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/22635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6552eb2b8414c7cff77407872ae72bd0ae72f8c2 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[master]: config: added backward compatibilty
by sbonazzo＠redhat.com 24 Dec '13

24 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: config: added backward compatibilty ...................................................................... config: added backward compatibilty Added backward compatibility supporting upgrade from 3.1 version which used the keyword engine-ca instead of cert-file. Change-Id: I43befe3fa63e1fb5c624fd528399e867c2b5e882 Bug-Url: https://bugzilla.redhat.com/1046309 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/22702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43befe3fa63e1fb5c624fd528399e867c2b5e882 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-image-uploader[master]: config: added backward compatibilty
by sbonazzo＠redhat.com 24 Dec '13

24 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: config: added backward compatibilty ...................................................................... config: added backward compatibilty Added backward compatibility supporting upgrade from 3.1 version which used the keyword engine-ca instead of cert-file. Change-Id: Ie4b06eea10a31b675fac0cae98465988dd66894d Bug-Url: https://bugzilla.redhat.com/1046303 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/22699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4b06eea10a31b675fac0cae98465988dd66894d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-iso-uploader[master]: config: added backward compatibilty
by sbonazzo＠redhat.com 24 Dec '13

24 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: config: added backward compatibilty ...................................................................... config: added backward compatibilty Added backward compatibility supporting upgrade from 3.1 version which used the keyword engine-ca instead of cert-file. Change-Id: Ibdfae742e8dfea58eb19b61987e347003b69b57b Bug-Url: https://bugzilla.redhat.com/1032689 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/22698 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdfae742e8dfea58eb19b61987e347003b69b57b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix typo in VmDevice
by mlipchuk＠redhat.com 24 Dec '13

24 Dec '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix typo in VmDevice ...................................................................... core: Fix typo in VmDevice Change-Id: I19de1f4e391aa7bab33c299170fe7a5a4e35c52c Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19de1f4e391aa7bab33c299170fe7a5a4e35c52c Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Change DeactivateStorageDomain CDA to use failCanDoAction
by mlipchuk＠redhat.com 24 Dec '13

24 Dec '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Change DeactivateStorageDomain CDA to use failCanDoAction ...................................................................... core: Change DeactivateStorageDomain CDA to use failCanDoAction Changing all the return false in the CDA to use one line of failCanDoAction Change-Id: I9caac7939290b1429e67d4ef3a041ea29a8766ef Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java 1 file changed, 5 insertions(+), 10 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9caac7939290b1429e67d4ef3a041ea29a8766ef Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add label column to network
by masayag＠redhat.com 24 Dec '13

24 Dec '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Add label column to network ...................................................................... engine: Add label column to network Extending the network table to persist the label entity so it can managed as part of the network entity. Change-Id: I4e3c309cef92e63ebe6f1f48f19f8848e9bceb70 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/create_views.sql M packaging/dbscripts/network_sp.sql A packaging/dbscripts/upgrade/03_04_0300_add_label_column_to_networks.sql 7 files changed, 62 insertions(+), 8 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e3c309cef92e63ebe6f1f48f19f8848e9bceb70 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Findbugs exclussions in JBoss modules plugin
by oourfali＠redhat.com 24 Dec '13

24 Dec '13

Oved Ourfali has submitted this change and it was merged. Change subject: core: Findbugs exclussions in JBoss modules plugin ...................................................................... core: Findbugs exclussions in JBoss modules plugin The code generated by Maven for the JBoss modules plugin contains a class that has an minor issue pointed out by findbugs. These issue has already been reported to the maven developers: http://jira.codehaus.org/browse/MPLUGIN-255 While this is solved in Maven we are adding a findbugs configuration to ignore it. This configuration is the same used in all the rest of the engine modules, the only difference is the exclussions list. Change-Id: I76106b935e0e987db04d99e36f89adc536754021 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A build-tools-root/jboss-modules-maven-plugin/exclude-filters.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml 2 files changed, 52 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76106b935e0e987db04d99e36f89adc536754021 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0