- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Move setupNetworkSupported to NetworkHelper
by masayag＠redhat.com 24 Dec '13

24 Dec '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Move setupNetworkSupported to NetworkHelper ...................................................................... engine: Move setupNetworkSupported to NetworkHelper The method is moved to a static class so it can be reused from various network commands. Change-Id: Ice92f998275a7f206c0c349519a86c22b6c53163 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 2 files changed, 10 insertions(+), 7 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice92f998275a7f206c0c349519a86c22b6c53163 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Clear eclipse warnings
by masayag＠redhat.com 24 Dec '13

24 Dec '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Clear eclipse warnings ...................................................................... engine: Clear eclipse warnings Change-Id: Ib12a2c115231503940fd4d6914877976712fa987 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkClusterDaoDbFacadeImpl.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22633 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib12a2c115231503940fd4d6914877976712fa987 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: rename members to start with lowercase in NotifyCollecti...
by derez＠redhat.com 24 Dec '13

24 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: ui: rename members to start with lowercase in NotifyCollectionChangedEventsArgs ...................................................................... ui: rename members to start with lowercase in NotifyCollectionChangedEventsArgs Change-Id: I6d7fb60760548e661cc3b1b512313513c17783d4 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/NotifyCollectionChangedEventArgs.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d7fb60760548e661cc3b1b512313513c17783d4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: removed volume rebalance actions
by iheim＠redhat.com 24 Dec '13

24 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: removed volume rebalance actions ...................................................................... webadmin: removed volume rebalance actions Gluster Volume Rebalance feature is not fully implemented in ovirt-engine-3.3. Removing the actions for now Change-Id: I0768d48f432235f405e9a6d8fee36794e2a72628 Bug-Url: https://bugzilla.redhat.com/1046000 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java 1 file changed, 0 insertions(+), 28 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0768d48f432235f405e9a6d8fee36794e2a72628 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: disable scan alignment for non-block SDs
by iheim＠redhat.com 24 Dec '13

24 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: disable scan alignment for non-block SDs ...................................................................... webadmin: disable scan alignment for non-block SDs VMs -> Disks sub-tab: disable scan alignment action for non-block storage domains (as it's applicable only for block domains). Disks main-tab: scan alignment will be blocked on canDoAction in a separate patch. Change-Id: I2f4150f72332fb071a90001e63858a5212a0db0a Bug-Url: https://bugzilla.redhat.com/1046031 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f4150f72332fb071a90001e63858a5212a0db0a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: CDA to block disk alignment scan on file SDs
by iheim＠redhat.com 24 Dec '13

24 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: core: CDA to block disk alignment scan on file SDs ...................................................................... core: CDA to block disk alignment scan on file SDs The current implementation of disk alignment scanning is useless for file domains, and fails on NFS storage in particular. This patch blocks such operations by a canDoAction(), to prevent any useless calls to VDSM. Change-Id: Ib7a9505ac16c9dd3cf14b584b8ec7e7292d68e98 Bug-Url: https://bugzilla.redhat.com/1046031 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 23 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22696 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7a9505ac16c9dd3cf14b584b8ec7e7292d68e98 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Architecture related checks for VMs and templates
by rgolan＠redhat.com 24 Dec '13

24 Dec '13

Roy Golan has submitted this change and it was merged. Change subject: core: Architecture related checks for VMs and templates ...................................................................... core: Architecture related checks for VMs and templates This change introduces architecture related checks during the creation and modification of VMs, Templates and Pools. These checks include: * Verifies if the selected template has the same architecture of the selected cluster when adding VMs and pools; * Verifies if the selected cluster has a undefined architecture when updating and adding VMs, templates and pools; * Does not allow VMs to change their clusters if the destination cluster has a different architecture. Change-Id: Ia877dd2d13525de6693883e43d0ca786f77f9310 Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Signed-off-by: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 13 files changed, 88 insertions(+), 0 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia877dd2d13525de6693883e43d0ca786f77f9310 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: CDA to block disk alignment scan on file SDs
by amureini＠redhat.com 24 Dec '13

24 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: CDA to block disk alignment scan on file SDs ...................................................................... core: CDA to block disk alignment scan on file SDs The current implementation of disk alignment scanning is useless for file domains, and fails on NFS storage in particular. This patch blocks such operations by a canDoAction(), to prevent any useless calls to VDSM. Change-Id: Ib7a9505ac16c9dd3cf14b584b8ec7e7292d68e98 Bug-Url: https://bugzilla.redhat.com/1046031 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 23 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7a9505ac16c9dd3cf14b584b8ec7e7292d68e98 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: disable scan alignment for non-block SDs
by amureini＠redhat.com 24 Dec '13

24 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: disable scan alignment for non-block SDs ...................................................................... webadmin: disable scan alignment for non-block SDs VMs -> Disks sub-tab: disable scan alignment action for non-block storage domains (as it's applicable only for block domains). Disks main-tab: scan alignment will be blocked on canDoAction in a separate patch. Change-Id: I2f4150f72332fb071a90001e63858a5212a0db0a Bug-Url: https://bugzilla.redhat.com/1046031 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22665 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f4150f72332fb071a90001e63858a5212a0db0a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Notifier code cleanup
by emesika＠redhat.com 24 Dec '13

24 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: tools: Notifier code cleanup ...................................................................... tools: Notifier code cleanup Removes unused attribute log in NotificationProperties. Removes unused attribute pidFile in EngineMonitorService. Removes unnecessary @SuppressWarning in Notifier. Reformats code in Notifier. Change-Id: I0ddf6dbb01baa0e3fd1a8349f26aead0cd6a5fde Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java 3 files changed, 5 insertions(+), 13 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ddf6dbb01baa0e3fd1a8349f26aead0cd6a5fde Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0