- Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: ux: rephrase confirm installation dialog
by sbonazzo＠redhat.com 24 Dec '13

24 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: ux: rephrase confirm installation dialog ...................................................................... ux: rephrase confirm installation dialog Change-Id: Iee730d02e3b3b69cfc7ec3455cc07a1cde546089 Bug-Url: https://bugzilla.redhat.com/1046145 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/core/misc.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22676 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee730d02e3b3b69cfc7ec3455cc07a1cde546089 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: ux: rephrase screen usage text
by sbonazzo＠redhat.com 24 Dec '13

24 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: ux: rephrase screen usage text ...................................................................... ux: rephrase screen usage text Change-Id: I9d281d803d0c083d0835ad7ebdc88c10dc8e81a7 Bug-Url: https://bugzilla.redhat.com/1046146 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/core/shell.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d281d803d0c083d0835ad7ebdc88c10dc8e81a7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core+webadmin: reordering VM NICs
by oourfali＠redhat.com 24 Dec '13

24 Dec '13

Oved Ourfali has submitted this change and it was merged. Change subject: core+webadmin: reordering VM NICs ...................................................................... core+webadmin: reordering VM NICs This patch adds a reordering functionality to the VM interfaces. The logic is as follows: 1. All templated NICs that have a PCI address are left as is. 2. All the remaining NICs are given MAC addresses with the same NIC name ordering. Change-Id: I7d02e3eff9466d9094bc16cd489503d25c9f4bef Bug-Url: https://bugzilla.redhat.com/1040630 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmInterfaceCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ReorderVmNicsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModelNetworkAsyncCallback.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceCreatingManager.java 6 files changed, 139 insertions(+), 18 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22512 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d02e3eff9466d9094bc16cd489503d25c9f4bef Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: handle nic ordering when adding or importing a VM
by oourfali＠redhat.com 24 Dec '13

24 Dec '13

Oved Ourfali has submitted this change and it was merged. Change subject: core: handle nic ordering when adding or importing a VM ...................................................................... core: handle nic ordering when adding or importing a VM This patch handles the NIC ordering when creating or importing a VM, as follows: 1. When creating a VM from template a. If the template has PCI addresses, then sort the NICs according to that, allocating MAC addresses with the same ordering b. If the template doesn't contain PCI addresses, allocate MAC addresses with an ordering identical to the naming of the NICs 2. When creating a VM from snapshot a. Follow logic in 1a. b. If the snapshot doesn't contain PCI addresses, but it does contain the MAC addresses, allocate new MAC addresses with the same ordering as in the original snapshot c. If no PCI and no MAC addresses are available, order by the NIC name 3. When importing a VM - same as VM creation (but no template in this case, just the exported VM is the reference to compare to). Change-Id: I46b4ffc4ecaab824b90bf8b8ecdfe4ebad3074bf Bug-Url: https://bugzilla.redhat.com/1040630 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java 6 files changed, 117 insertions(+), 29 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46b4ffc4ecaab824b90bf8b8ecdfe4ebad3074bf Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.0]: agent: use certificate common name to identify host
by dfediuck＠redhat.com 24 Dec '13

24 Dec '13

Doron Fediuck has submitted this change and it was merged. Change subject: agent: use certificate common name to identify host ...................................................................... agent: use certificate common name to identify host The name the host calls itself in the global metadata must match the libvirt certificate's Common Name, else migrations will fail. Use this name when available, and fall back to the hostname in other cases. Change-Id: Ie9de4537685b11f8ecbe55b3c1b6845654f59311 Bug-Url: https://bugzilla.redhat.com/1039614 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/constants.py.in M ovirt_hosted_engine_ha/agent/hosted_engine.py 2 files changed, 35 insertions(+), 1 deletion(-) Approvals: Greg Padgett: Verified Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9de4537685b11f8ecbe55b3c1b6845654f59311 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.0 Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: ux: provide default gw for pingable address.
by sbonazzo＠redhat.com 24 Dec '13

24 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: ux: provide default gw for pingable address. ...................................................................... ux: provide default gw for pingable address. Change-Id: Id73ecc9d929e0afe9c62773975c9564b35c38da7 Bug-Url: https://bugzilla.redhat.com/1046147 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/network/gateway.py 1 file changed, 23 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/22678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id73ecc9d929e0afe9c62773975c9564b35c38da7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: api: fixing a typo in api.xsd
by emesika＠redhat.com 24 Dec '13

24 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: api: fixing a typo in api.xsd ...................................................................... api: fixing a typo in api.xsd Change-Id: Icd7b7aab9a126d16a3575184b329ada77672151e Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22226 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd7b7aab9a126d16a3575184b329ada77672151e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Delete jobs that their steps have no async-tasks
by emesika＠redhat.com 24 Dec '13

24 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: engine: Delete jobs that their steps have no async-tasks ...................................................................... engine: Delete jobs that their steps have no async-tasks Sometimes async tasks complete but there were database errors when closing the steps and jobs. This patch updates the periodic job deletion to delete such jobs. Change-Id: Iae00d615bff79f42d8428b867f1816d6e0aa9a72 Bug-Url: https://bugzilla.redhat.com/1040952 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M packaging/dbscripts/job_sp.sql 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae00d615bff79f42d8428b867f1816d6e0aa9a72 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Anonymous Coward #1000524 Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Hosts SearchBox doesn't filter correctly
by emesika＠redhat.com 24 Dec '13

24 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: engine: Hosts SearchBox doesn't filter correctly ...................................................................... engine: Hosts SearchBox doesn't filter correctly Hosts - SearchBox "Host:user.usrname =*" doesn't filter correctly Change-Id: I420b7705596335b9be6d6d8374a11f7542a03db9 Bug-Url: https://bugzilla.redhat.com/1006231 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 2 files changed, 5 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22438 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I420b7705596335b9be6d6d8374a11f7542a03db9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: build: validate shell scripts
by sbonazzo＠redhat.com 24 Dec '13

24 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: build: validate shell scripts ...................................................................... packaging: build: validate shell scripts Change-Id: Ib16140e4abcb3740a51f4c3b77b9eee3a6e5cffd Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile A build/shell-check.sh M ovirt-engine.spec.in M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.sysv.in M packaging/services/ovirt-engine/ovirt-engine.sysv.in M packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.sysv.in M packaging/setup/dbutils/encodingvalidator.sh 7 files changed, 54 insertions(+), 15 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib16140e4abcb3740a51f4c3b77b9eee3a6e5cffd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0