- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: tools: Fixing edit action of manage-domains
by iheim＠redhat.com 12 Dec '13

12 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: tools: Fixing edit action of manage-domains ...................................................................... tools: Fixing edit action of manage-domains Bug-Url: https://bugzilla.redhat.com/1037894 The following patches fixes the edit action of manage-domains tool to support edit of values provided by the "ldapServers" argument. Prior to this fix, the change was not stored at the proper location at the vdc_options table. Bare in mind that if -ldapServers is not provided during the edit action no change will be made to the entry. Change-Id: I9f86b8ce2c697931b9c8388ea87fe07d557530c6 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KerberosConfigCheck.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java 2 files changed, 29 insertions(+), 17 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Yair Zaslavsky: Verified Objections: Yair Zaslavsky: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/22314 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f86b8ce2c697931b9c8388ea87fe07d557530c6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fixing PM options caching
by emesika＠redhat.com 12 Dec '13

12 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Fixing PM options caching ...................................................................... core: Fixing PM options caching fencingOptionMapping cache map was declared as static as a result if it was initialized once with the 'general' version the values of this version was used for all instances no matter which version is given to the constructor. This eliminates new agents added in later versions to function and display supported port/slot/secure fields correctly Change-Id: I03e4a98919105bbb0d7ef382234b8810db044215 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1020344 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03e4a98919105bbb0d7ef382234b8810db044215 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Dashboard results an error, when reports is not de...
by emesika＠redhat.com 12 Dec '13

12 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: webadmin: Dashboard results an error, when reports is not deployed ...................................................................... webadmin: Dashboard results an error, when reports is not deployed Reports tab shows error page when accessed after a server restart before the reports web app has been deployed A new Status servlet has been added to Reports app which is used by the webadmin to check the deployment status of report webapp before showing reports in reports tab Change-Id: Ib6f63fe75110a6f799d355e78ed1fc0af2bd7d06 Bug-Url: https://bugzilla.redhat.com/1037667 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabReportsPresenter.java 2 files changed, 77 insertions(+), 6 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6f63fe75110a6f799d355e78ed1fc0af2bd7d06 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: remove host if it is already detached in gluster
by kmayilsa＠redhat.com 12 Dec '13

12 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: remove host if it is already detached in gluster ...................................................................... engine: remove host if it is already detached in gluster Handle the error returned from VDSM while removing a host. If the host is already detached from Gluster through Gluster CLI then remove the host from engine . Change-Id: Ib83bffebe99ef5553ffcb2ce8ef03d4bba4c12b3 Bug-Url:i https://bugzilla.redhat.com/1024183 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 6 files changed, 11 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit http://gerrit.ovirt.org/22240 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib83bffebe99ef5553ffcb2ce8ef03d4bba4c12b3 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix potential NumberFormatException in OsRepositoryImpl
by rgolan＠redhat.com 12 Dec '13

12 Dec '13

Roy Golan has submitted this change and it was merged. Change subject: engine: Fix potential NumberFormatException in OsRepositoryImpl ...................................................................... engine: Fix potential NumberFormatException in OsRepositoryImpl Added NumberFormatException check in getInt method to guard against bad number format. Change-Id: I3ec4c9704d35b7f2955ed41761d4f019969897c1 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17117 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ec4c9704d35b7f2955ed41761d4f019969897c1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: Clean up treatment of /etc/exports
by sbonazzo＠redhat.com 12 Dec '13

12 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Clean up treatment of /etc/exports ...................................................................... packaging: setup: Clean up treatment of /etc/exports Without this change, /etc/exports: - gets overwritten on setup if there is no /etc/exports.d - is added empty lines when edited by setup - is not restored to previous content on cleanup With this change: - If there is /etc/exports.d: -- Setup writes there a file with the iso domain path, which is removed on cleanup (if not changed since setup) -- Setup removes this path from /etc/exports if it's there (supposedly added by a previous legacy Setup), and this change is not reverted on cleanup - If there is only /etc/exports: -- Setup adds to it the path if it's not there already -- Cleanup reverts this change if the line was not changed since setup Bug-Url: https://bugzilla.redhat.com/1035511 Change-Id: I035817c048518f77fc666cc6d5212c8e46edd65d Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/system/exportfs.py 1 file changed, 80 insertions(+), 45 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I035817c048518f77fc666cc6d5212c8e46edd65d Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3.2]: packaging: spec: force update of openjdk which leaks memory
by iheim＠redhat.com 11 Dec '13

11 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: spec: force update of openjdk which leaks memory ...................................................................... packaging: spec: force update of openjdk which leaks memory this will only force upgrade if existing openjdk install is faulty Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1028966 Change-Id: Ifbc098ec79cc95783f775f856c4f4563c3f61a3b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbc098ec79cc95783f775f856c4f4563c3f61a3b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.2 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Remove redundant method from ISCSIStorageHelper
by amureini＠redhat.com 11 Dec '13

11 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Remove redundant method from ISCSIStorageHelper ...................................................................... engine: Remove redundant method from ISCSIStorageHelper Change-Id: I5450682f8e611a398405ec0f126e7d4e10cfbd7d Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5450682f8e611a398405ec0f126e7d4e10cfbd7d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Remove concreteStorageType property from StorageType...
by amureini＠redhat.com 11 Dec '13

11 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Remove concreteStorageType property from StorageType enum. ...................................................................... engine: Remove concreteStorageType property from StorageType enum. StorageType enum represents all supported types of storage, unfortunately it also contains UNKNOWN(0) and ALL(-1) values which are not a real storage types. In order to establish which type is real this enum doesn't need additional state 'concreteStorageType', it can just check the value. Change-Id: Ibdd785ccb3c0e074f5a14bec1ee60c6d374700a1 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageType.java 1 file changed, 11 insertions(+), 15 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdd785ccb3c0e074f5a14bec1ee60c6d374700a1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Simplify AddExistingFileStorageDomainCommand
by amureini＠redhat.com 11 Dec '13

11 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Simplify AddExistingFileStorageDomainCommand ...................................................................... engine: Simplify AddExistingFileStorageDomainCommand 1. Use regular imports instead of inline. 2. Use quick return in case of failure. 3. Use shorter runVdsCommand. Change-Id: I21960f64d45c01a65978a44d5874b8c94dfb9420 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java 1 file changed, 26 insertions(+), 34 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21960f64d45c01a65978a44d5874b8c94dfb9420 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0