- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Move AddStorageDomainCommand.checkExistingStorageDomain
by amureini＠redhat.com 11 Dec '13

11 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Move AddStorageDomainCommand.checkExistingStorageDomain ...................................................................... engine: Move AddStorageDomainCommand.checkExistingStorageDomain There is no reason to keep this method in the base class AddStorageDomainCommand just because it used by one of it's successors. I am moving it to AddExistingFileStorageDomainCommand. As a result of this change concreteCheckExistingStorageDomain() method can be removed from the base class. Change-Id: I2002f942d32aacf7bbcaa8b6caef3bb744d2dd48 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java 2 files changed, 48 insertions(+), 52 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21322 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2002f942d32aacf7bbcaa8b6caef3bb744d2dd48 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Remove StorageType.ALL value
by amureini＠redhat.com 11 Dec '13

11 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Remove StorageType.ALL value ...................................................................... engine: Remove StorageType.ALL value This value is used only by GetVGListVDSCommand, but the fact we are talking about VGs implies that this is a block storage - ISCSI or FCP so in case we can't determine its exact type the UNKNOWN option is probably more suitable than ALL. Change-Id: I761d322f88304353bb11fceeed39305dd6698045 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageType.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/StorageTypeTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVGListVDSCommand.java A packaging/dbscripts/upgrade/03_04_0210_replace_storage_type_all_with_unknown.sql 4 files changed, 7 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21315 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I761d322f88304353bb11fceeed39305dd6698045 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Populate error message placeholder in HotPlugDiskToV...
by amureini＠redhat.com 11 Dec '13

11 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Populate error message placeholder in HotPlugDiskToVmCommand ...................................................................... engine: Populate error message placeholder in HotPlugDiskToVmCommand Trying to deactivate a locked disk will throw the error with the {diskAliases} placeholder which now is populated with the actual disk alias. Change-Id: Iff5224477b8ba547ea7dcde9069ec8874fa8ed24 Bug-Url: https://bugzilla.redhat.com/1031386 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java 1 file changed, 16 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21800 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff5224477b8ba547ea7dcde9069ec8874fa8ed24 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: restapi: Fix Duplicate Name In Cloud-Init Schema (#1039921)
by iheim＠redhat.com 11 Dec '13

11 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: restapi: Fix Duplicate Name In Cloud-Init Schema (#1039921) ...................................................................... restapi: Fix Duplicate Name In Cloud-Init Schema (#1039921) Duplicate name 'network' in schema violated a name-uniqneness assumption of python-sdk code generation. Bug-Url: http://bugzilla.redhat.com/1039921 Change-Id: If251b2ee2dec5660cce04d4e1332f91a33c7485b Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/CloudInitValidator.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 4 files changed, 30 insertions(+), 28 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22302 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If251b2ee2dec5660cce04d4e1332f91a33c7485b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: rest: fix broken yaml file
by ofrenkel＠redhat.com 11 Dec '13

11 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: rest: fix broken yaml file ...................................................................... rest: fix broken yaml file Change-Id: I926d83187d19b11db47bd4029bb17adc1785761b Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I926d83187d19b11db47bd4029bb17adc1785761b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Fix Duplicate Name In Cloud-Init Schema (#1039921)
by oliel＠redhat.com 11 Dec '13

11 Dec '13

Ori Liel has submitted this change and it was merged. Change subject: restapi: Fix Duplicate Name In Cloud-Init Schema (#1039921) ...................................................................... restapi: Fix Duplicate Name In Cloud-Init Schema (#1039921) Duplicate name 'network' in schema violated a name-uniqneness assumption of python-sdk code generation. Bug-Url: http://bugzilla.redhat.com/1039921 Change-Id: If251b2ee2dec5660cce04d4e1332f91a33c7485b Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/CloudInitValidator.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 4 files changed, 30 insertions(+), 28 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If251b2ee2dec5660cce04d4e1332f91a33c7485b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3.2]: core: fix broken sysprep file name
by iheim＠redhat.com 11 Dec '13

11 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: core: fix broken sysprep file name ...................................................................... core: fix broken sysprep file name Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1025829 Change-Id: Icbd5f50a7faaa4d8dec8888956e8e9fd13c6b50f Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- R packaging/etc/sysprep/sysprep.2k8x64 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbd5f50a7faaa4d8dec8888956e8e9fd13c6b50f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.2 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: fix broken sysprep file name
by iheim＠redhat.com 11 Dec '13

11 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: core: fix broken sysprep file name ...................................................................... core: fix broken sysprep file name Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1025829 Change-Id: Icbd5f50a7faaa4d8dec8888956e8e9fd13c6b50f Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- R packaging/etc/sysprep/sysprep.2k8x64 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbd5f50a7faaa4d8dec8888956e8e9fd13c6b50f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Simplify ConnectStorageToVdsCommand
by amureini＠redhat.com 11 Dec '13

11 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Simplify ConnectStorageToVdsCommand ...................................................................... engine: Simplify ConnectStorageToVdsCommand 1. Remove connect method. 2. Convert single connection in to the list only once. 3. Remove inline imports. Change-Id: Ic44eba259690c625688ad322ef988af4a56d3e34 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java 1 file changed, 13 insertions(+), 16 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic44eba259690c625688ad322ef988af4a56d3e34 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: restapi: fix incorrectly implemented cloud-init metadata #10...
by iheim＠redhat.com 11 Dec '13

11 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: restapi: fix incorrectly implemented cloud-init metadata #1040513 ...................................................................... restapi: fix incorrectly implemented cloud-init metadata #1040513 Change-Id: I44111ab1c8d2c8b449bc1ac6924ba30dd21fcbca Signed-off-by: Michael pasternak <mpastern(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1040513 --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 11 insertions(+), 13 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22249 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44111ab1c8d2c8b449bc1ac6924ba30dd21fcbca Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0