- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: set sub-tab height in proportion with maintab
by kmayilsa＠redhat.com 11 Dec '13

11 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: set sub-tab height in proportion with maintab ...................................................................... webadmin: set sub-tab height in proportion with maintab When webadmin in viewed in small resolution, sub-tab is taking most of the space. The user has to use the splitter to reduce the height of the subtab. Sub-tab height will be set to half of main-tab's height, and with a maximum of 300PX. Change-Id: I8cdbb8ac17632e4e9d62a053b89e440f97eeea26 Bug-Url: https://bugzilla.redhat.com/1027178 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/MainContentView.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit http://gerrit.ovirt.org/22121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cdbb8ac17632e4e9d62a053b89e440f97eeea26 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove IllegalOperationException
by amureini＠redhat.com 11 Dec '13

11 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove IllegalOperationException ...................................................................... core: Remove IllegalOperationException Since IllegalOperationException is never caught directly, it can be replaced with the standard Java IllegalArgumentException which carries the exact same meaning and also extends RuntimeException. Change-Id: Ib0505a889a60ea86e0473ed8651c1e47eee148c9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateDeactivateSingleAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AfterDeactivateSingleAsyncOperationFactory.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/InvalidOperationException.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperationFactory.java 4 files changed, 8 insertions(+), 13 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0505a889a60ea86e0473ed8651c1e47eee148c9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Larissa Baracioli <lara.baracioli(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin : Allow deletion of sub-volumes from distributed-re...
by kmayilsa＠redhat.com 11 Dec '13

11 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : Allow deletion of sub-volumes from distributed-replicate volume ...................................................................... webadmin : Allow deletion of sub-volumes from distributed-replicate volume Refactored the code to allow, deleting multiple sub-volumes from distributed-replicate volume. Change-Id: Ib02785bc87af782a3d51c784bedac4e3d0e1b15a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1031585 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java 1 file changed, 30 insertions(+), 23 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22229 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib02785bc87af782a3d51c784bedac4e3d0e1b15a Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin : Hide cluster logical networks virt actions in Glu...
by kmayilsa＠redhat.com 11 Dec '13

11 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : Hide cluster logical networks virt actions in Gluster mode ...................................................................... webadmin : Hide cluster logical networks virt actions in Gluster mode The menu options like "Add Network", "Manage Networks" and "Set as Display" and the dialogues coming from these menu options, are not applicable to RHS.So,this patch hides them in Gluster only mode. Change-Id: I2436c11b51f6707c70aef426e1e253ff958fa6dd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1015020 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterNetworkView.java 1 file changed, 22 insertions(+), 18 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22189 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2436c11b51f6707c70aef426e1e253ff958fa6dd Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove unused consts from GlusterConstants
by amureini＠redhat.com 11 Dec '13

11 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused consts from GlusterConstants ...................................................................... core: Remove unused consts from GlusterConstants Change-Id: Ib755b3325614b0647468d8a21b3c09e960939de7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21999 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib755b3325614b0647468d8a21b3c09e960939de7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: fix repeated words while removing user role or perm...
by ofrenkel＠redhat.com 11 Dec '13

11 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: gluster: fix repeated words while removing user role or permission ...................................................................... gluster: fix repeated words while removing user role or permission Added new entries in AuditLogMessages.properties for add or remove user system permission. Change-Id: I3ec4962877168768879e45b10aa65d9416f54831 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1031901 Signed-off-by: Timothy Asir <tjeyasin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddSystemPermissionCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSystemPermissionCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/SystemPermissionListModel.java 7 files changed, 41 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ec4962877168768879e45b10aa65d9416f54831 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rename member in VmTemplateHandler to uppercase
by oourfali＠redhat.com 11 Dec '13

11 Dec '13

Oved Ourfali has submitted this change and it was merged. Change subject: core: rename member in VmTemplateHandler to uppercase ...................................................................... core: rename member in VmTemplateHandler to uppercase Fix a findbugs warning Change-Id: I7a4350959ddbef3c973f2f80366c92feb623de79 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesByStoragePoolIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java 13 files changed, 24 insertions(+), 25 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22248 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a4350959ddbef3c973f2f80366c92feb623de79 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3.2]: engine: Fix slow API query for list of templates in a Datace...
by iheim＠redhat.com 11 Dec '13

11 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Fix slow API query for list of templates in a Datacenter ...................................................................... engine: Fix slow API query for list of templates in a Datacenter This patch improves the performance of SearcQuery for templates by Datacenter. It improves performance by about a factor of 5. Change-Id: I13460ae1aa3d7cb2816ed53b5ca7da64f15b8845 Bug-Url: https://bugzilla.redhat.com/1029106 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/22246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13460ae1aa3d7cb2816ed53b5ca7da64f15b8845 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.2 Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: sos: postgresql: always use db host
by sbonazzo＠redhat.com 11 Dec '13

11 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: postgresql: always use db host ...................................................................... sos: postgresql: always use db host Previously it was possible to access the database through unix socket. Now the access for user engine is limited to tcp connection. Changed the call to sosreport for passing db host to postgresql plugin. Change-Id: Ibb4ac5e03e3b6f1f6d7b499c969bdeb5ed9026cb Bug-Url: https://bugzilla.redhat.com/1039747 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 10 insertions(+), 38 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/22245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb4ac5e03e3b6f1f6d7b499c969bdeb5ed9026cb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Derrick Ornelas <dornelas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: Allow user to reboot VM from within the installer
by sbonazzo＠redhat.com 11 Dec '13

11 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: Allow user to reboot VM from within the installer ...................................................................... Allow user to reboot VM from within the installer During setup, the engine VM is created twice: once to install the base operating system and once to install the engine. During either of these phases it may sometimes be necessary to reboot the VM additional times (ie. to correct PXE boot configuration or restart the installer). Provide an interactive means of rebooting the VM without forcing the user to resort to external invocations of hosted-engine --vm-start, etc. Signed-off-by: Adam Litke <alitke(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1034788 Change-Id: I176eb58b6b5400df7f98a4fa3e4ae55c2959fb93 --- M src/ovirt_hosted_engine_setup/mixins.py M src/plugins/ovirt-hosted-engine-setup/engine/health.py M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py 3 files changed, 71 insertions(+), 79 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Adam Litke: Verified -- To view, visit http://gerrit.ovirt.org/22203 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I176eb58b6b5400df7f98a4fa3e4ae55c2959fb93 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0