- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Fix REST API URL in UI plugin infra
by vszocs＠redhat.com 11 Dec '13

11 Dec '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Fix REST API URL in UI plugin infra ...................................................................... webadmin: Fix REST API URL in UI plugin infra This patch ensures that UI plugin infrastructure acquires REST API session using URL: /ovirt-engine/api/ (i.e. using appropriate base context path) instead of current URL: /api/ which yields HTTP 404 response without redirect. Change-Id: I5a538036f14a823ce831375ba3323fe2a0b7b7da Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22104 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a538036f14a823ce831375ba3323fe2a0b7b7da Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin, userportal: Fix GWT DevMode refresh issue
by vszocs＠redhat.com 11 Dec '13

11 Dec '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Fix GWT DevMode refresh issue ...................................................................... webadmin,userportal: Fix GWT DevMode refresh issue GWT SDK version 2.5.1 + gwt-maven-plugin version 2.5.1 combo has an issue where GUI code change (modifying *.java file) isn't reflected into (running) GWT DevMode debug session: https://jira.codehaus.org/browse/MGWT-350 In practice, this means developer has to restart GWT DevMode each time he (she) makes GUI code change, which is not good. This patch modifies 'gwtdev' Maven build profile to work around this issue by using gwt-maven-plugin version 2.4.0 instead of (GWT SDK based) version 2.5.1. Note that 'gwtdev' profile is used only for GWT debugging purposes, therefore this patch has no impact on regular GWT build. Change-Id: I831d0b2ce203bea3a4ffa1b42c27a3d0c300c7a1 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M pom.xml 3 files changed, 20 insertions(+), 0 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I831d0b2ce203bea3a4ffa1b42c27a3d0c300c7a1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix findbugs warnings
by vszocs＠redhat.com 11 Dec '13

11 Dec '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: fix findbugs warnings ...................................................................... webadmin: fix findbugs warnings Change-Id: Icbff8652b632cd24f029f9ba23ed63e8679d034f Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AsyncQuery.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleOptionsFrontendPersisterImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkQoSListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterQuotaListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaStorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserQuotaListModel.java 10 files changed, 29 insertions(+), 21 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbff8652b632cd24f029f9ba23ed63e8679d034f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fix findbugs 'ignore java.lang.Exception' warning
by vszocs＠redhat.com 11 Dec '13

11 Dec '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Fix findbugs 'ignore java.lang.Exception' warning ...................................................................... webadmin: Fix findbugs 'ignore java.lang.Exception' warning DynamicTabContainerPresenter.setInSlot method override repeats some code from superclass method (TabContainerPresenter.setInSlot) simply because it doesn't allow easy extension of its logic. This patch fixes 'ignore java.lang.Exception' findbugs warning by logging the exception via client-side logger infrastructure. Change-Id: I414216bdbf0419862a6beeebf037ec559d608290 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/DynamicTabContainerPresenter.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21056 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I414216bdbf0419862a6beeebf037ec559d608290 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin : Hide virt fields in the host->general sub-tab in ...
by vszocs＠redhat.com 11 Dec '13

11 Dec '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin : Hide virt fields in the host->general sub-tab in Gluster mode ...................................................................... webadmin : Hide virt fields in the host->general sub-tab in Gluster mode Not adding instead of just hiding virt-related fields in the host -> general sub-tab and hence fix the allignment issues. Modified the SubTabHostGeneralView to NOT take row numbers statically, as doing so,will introduce blank spaces if a particular row is made invisible in a particular application mode. So,modified FormBuilder to have a map("nextEmptyRowForColumn") of first unused rows for each column and hence decide dynamically which row to insert the current widget into for a given column. Change-Id: I770547907c681a4648999c9d0d3d3ff7aba93971 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1025101 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/AbstractFormPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormBuilder.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormItem.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateGeneralModelForm.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java 6 files changed, 107 insertions(+), 43 deletions(-) Approvals: anmolbabu: Verified Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I770547907c681a4648999c9d0d3d3ff7aba93971 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: fix incorrectly implemented cloud-init metadata
by mpastern＠redhat.com 11 Dec '13

11 Dec '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: fix incorrectly implemented cloud-init metadata ...................................................................... restapi: fix incorrectly implemented cloud-init metadata Change-Id: I44111ab1c8d2c8b449bc1ac6924ba30dd21fcbca Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 11 insertions(+), 13 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44111ab1c8d2c8b449bc1ac6924ba30dd21fcbca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: set cluster level CPU id
by sbonazzo＠redhat.com 11 Dec '13

11 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: set cluster level CPU id ...................................................................... packaging: setup: set cluster level CPU id Set CPU cluster compatibility to the same CPU family chosen for hosted engine VM. Change-Id: I141304606f4a1f11bb0f9fda8b1c822669d560c8 Bug-Url: https://bugzilla.redhat.com/1034821 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/vdsmd/cpu.py 3 files changed, 39 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I141304606f4a1f11bb0f9fda8b1c822669d560c8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: set cluster level CPU id
by sbonazzo＠redhat.com 11 Dec '13

11 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: set cluster level CPU id ...................................................................... packaging: setup: set cluster level CPU id Set CPU cluster compatibility to the same CPU family chosen for hosted engine VM. Change-Id: I141304606f4a1f11bb0f9fda8b1c822669d560c8 Bug-Url: https://bugzilla.redhat.com/1034821 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/vdsmd/cpu.py 3 files changed, 39 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I141304606f4a1f11bb0f9fda8b1c822669d560c8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix broken sysprep file name
by ofrenkel＠redhat.com 11 Dec '13

11 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix broken sysprep file name ...................................................................... core: fix broken sysprep file name Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1025829 Change-Id: Icbd5f50a7faaa4d8dec8888956e8e9fd13c6b50f Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- R packaging/etc/sysprep/sysprep.2k8x64 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbd5f50a7faaa4d8dec8888956e8e9fd13c6b50f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: spec: force update of openjdk which leaks memory
by iheim＠redhat.com 11 Dec '13

11 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: spec: force update of openjdk which leaks memory ...................................................................... packaging: spec: force update of openjdk which leaks memory this will only force upgrade if existing openjdk install is faulty Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1028966 Change-Id: Ifbc098ec79cc95783f775f856c4f4563c3f61a3b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22289 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbc098ec79cc95783f775f856c4f4563c3f61a3b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0