- Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[master]: Move VM operations into a mixin for reusability
by sbonazzo＠redhat.com 11 Dec '13

11 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: Move VM operations into a mixin for reusability ...................................................................... Move VM operations into a mixin for reusability The plugin in runvm.py has lots of useful logic for manipulating the hosted engine VM. This logic can be very useful to other plugins (eg. health.py) that may want to offer the user assistance with managing the VM. This patch moves the VM logic into a separate class that can be mixed in with any other plugin which may want the functionality. Signed-off-by: Adam Litke <alitke(a)redhat.com> Related-To: https://bugzilla.redhat.com/1034788 Change-Id: I811f6712cb5c9324c6a3acca0bfc5bc9195b25ef --- M src/ovirt_hosted_engine_setup/Makefile.am A src/ovirt_hosted_engine_setup/mixins.py M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py 3 files changed, 218 insertions(+), 185 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Adam Litke: Verified -- To view, visit http://gerrit.ovirt.org/22202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I811f6712cb5c9324c6a3acca0bfc5bc9195b25ef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: fix findBug warning in GlusterAsyncTaskStatusQueryBase
by kmayilsa＠redhat.com 11 Dec '13

11 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: fix findBug warning in GlusterAsyncTaskStatusQueryBase ...................................................................... gluster: fix findBug warning in GlusterAsyncTaskStatusQueryBase filling the task parameter after the null check for task and task ID. Change-Id: Ibeca077dc4fbc1f8d546f8aea0482c41300cb115 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncTaskStatusQueryBase.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit http://gerrit.ovirt.org/22227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibeca077dc4fbc1f8d546f8aea0482c41300cb115 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Log when gluster task started from CLI
by kmayilsa＠redhat.com 11 Dec '13

11 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Log when gluster task started from CLI ...................................................................... engine: Log when gluster task started from CLI Add event log messages when a gluster task - rebalance or remove brick - is started from CLI Change-Id: I381ecc028ff5dd36202916953f5c3c623b43e526 Bug-Url: https://bugzilla.redhat.com/1015444 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties A packaging/dbscripts/upgrade/03_04_0200_gluster_async_tasks_fromcli_event_map.sql 5 files changed, 56 insertions(+), 20 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/22078 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I381ecc028ff5dd36202916953f5c3c623b43e526 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: code: change data members to start with a lowercase letter
by oourfali＠redhat.com 11 Dec '13

11 Dec '13

Oved Ourfali has submitted this change and it was merged. Change subject: code: change data members to start with a lowercase letter ...................................................................... code: change data members to start with a lowercase letter Change-Id: Ib28d10aead22f2753ab5b98b9abc4e71d860f087 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmImagesCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmFromTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveAllVmImagesParameters.java 4 files changed, 7 insertions(+), 7 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib28d10aead22f2753ab5b98b9abc4e71d860f087 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix typo in Add-Bricks popup
by kmayilsa＠redhat.com 11 Dec '13

11 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: fix typo in Add-Bricks popup ...................................................................... webadmin: fix typo in Add-Bricks popup "create" -> "created". Change-Id: I36c3022a6d6189a751f0c83d1c0c1159d8a25923 Bug-Url: https://bugzilla.redhat.com/886478 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36c3022a6d6189a751f0c83d1c0c1159d8a25923 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: disable rebalance action when its being started
by kmayilsa＠redhat.com 11 Dec '13

11 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: disable rebalance action when its being started ...................................................................... webadmin: disable rebalance action when its being started Once the user clicks on 'Rebalance' action in volumes tab, glusterfs takes few seconds to start the rebalance operation. 'Rebalance' action will be disabled immediately without waiting for the result from glusterfs. Change-Id: I961955f15310e5d0566019556e7f7e601e8ec957 Bug-Url: https://bugzilla.redhat.com/1021814 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22224 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I961955f15310e5d0566019556e7f7e601e8ec957 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Improve log message on failure to connect to storage...
by mlipchuk＠redhat.com 10 Dec '13

10 Dec '13

Maor Lipchuk has submitted this change and it was merged. Change subject: engine: Improve log message on failure to connect to storage server ...................................................................... engine: Improve log message on failure to connect to storage server >From now on log message will contain name and id of the relevant storage domain a host failed to connect to. Change-Id: Ife941b59766e699a046122abc74aaede366a2015 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectSingleAsyncOperation.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife941b59766e699a046122abc74aaede366a2015 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: spec: force update of openjdk which leaks memory
by sbonazzo＠redhat.com 10 Dec '13

10 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: force update of openjdk which leaks memory ...................................................................... packaging: spec: force update of openjdk which leaks memory this will only force upgrade if existing openjdk install is faulty Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1028966 Change-Id: Ifbc098ec79cc95783f775f856c4f4563c3f61a3b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22261 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbc098ec79cc95783f775f856c4f4563c3f61a3b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: build: ovirt-hosted-engine-setup-1.0.0-0.11.beta6
by sbonazzo＠redhat.com 10 Dec '13

10 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-1.0.0-0.11.beta6 ...................................................................... build: ovirt-hosted-engine-setup-1.0.0-0.11.beta6 Change-Id: I6e529edb7b5219f278e05515ab982b288a89a916 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 10 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/22254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e529edb7b5219f278e05515ab982b288a89a916 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: build: ovirt-hosted-engine-ha-0.1.0-0.9.beta1
by gpadgett＠redhat.com 10 Dec '13

10 Dec '13

Greg Padgett has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-ha-0.1.0-0.9.beta1 ...................................................................... build: ovirt-hosted-engine-ha-0.1.0-0.9.beta1 Change-Id: I445ca3ece96a9e7588e7114b599058ddcc9223bf Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified Greg Padgett: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22252 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I445ca3ece96a9e7588e7114b599058ddcc9223bf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0