- Engine-commits - oVirt List Archives

Change in ovirt-dwh[master]: packaging: changed the db dict get method
by ydary＠redhat.com 30 Oct '13

30 Oct '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: changed the db dict get method ...................................................................... packaging: changed the db dict get method Engine now saved config values with quotes marks. This breaks the current db dict get method. Added replace for these values. Change-Id: I68b69296bffd98c7262751bc807da54885791b28 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-dwh-setup.py 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Alex Lourie: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68b69296bffd98c7262751bc807da54885791b28 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: changed the db dict get method
by ydary＠redhat.com 30 Oct '13

30 Oct '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: changed the db dict get method ...................................................................... packaging: changed the db dict get method Engine now saved config values with quotes marks. This breaks the current db dict get method. Added replace for these values. Change-Id: I72e386787f7b074f365506dedb9976fed2554dc4 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-reports-setup.py 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72e386787f7b074f365506dedb9976fed2554dc4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RemoveStorageDomainCommandTest: local var
by amureini＠redhat.com 30 Oct '13

30 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveStorageDomainCommandTest: local var ...................................................................... core: RemoveStorageDomainCommandTest: local var Convert useless members to local variables in the setUp() method. Change-Id: I4323e3d644168fcbc07705ac5a32b1d792a4da56 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4323e3d644168fcbc07705ac5a32b1d792a4da56 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: RemoveStorageDomainCommandTest: generics
by amureini＠redhat.com 30 Oct '13

30 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveStorageDomainCommandTest: generics ...................................................................... core: RemoveStorageDomainCommandTest: generics Use Java7 generics syntax to make the code easier to read. Change-Id: I49473952c318ede46f9a2c95184b07f27c933324 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49473952c318ede46f9a2c95184b07f27c933324 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: RemoveStorageDomainCommandTest: annotations
by amureini＠redhat.com 30 Oct '13

30 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveStorageDomainCommandTest: annotations ...................................................................... core: RemoveStorageDomainCommandTest: annotations Use the modern @Mock annotation instead of explicitly calling Mockito.mock. The resulting class is easier to understand since the mocking does not interrupt the flow of reading setUp(). Change-Id: I3f2c9d3ccf1810f0532b2200acda27679fee158d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f2c9d3ccf1810f0532b2200acda27679fee158d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: RemoveStorageDomainCommandTest spelling
by amureini＠redhat.com 30 Oct '13

30 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveStorageDomainCommandTest spelling ...................................................................... core: RemoveStorageDomainCommandTest spelling Fixed typos and spelling mistakes. Change-Id: I9a4031c6a362589c96d6b2a41ee3f32193959aea Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a4031c6a362589c96d6b2a41ee3f32193959aea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: differentiate command test utils
by amureini＠redhat.com 30 Oct '13

30 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: differentiate command test utils ...................................................................... core: differentiate command test utils CommandAssertUtils and CanDoActionTestUtils contained duplicated logic as both were used to test canDoAction() methods. This patch moves all the (remaining) canDoAction() tests to use CanDoActionTestUtils and removes the redundant methods from CommandAssertUtils, leaving it as a utility to test execute() methods only. Change-Id: Iadce121f4cf3d04e4eab8200c679230e4b4adf8b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandAssertUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ForceSelectSPMCommandTest.java 2 files changed, 19 insertions(+), 45 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20685 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadce121f4cf3d04e4eab8200c679230e4b4adf8b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Unify RemoveStorageDomain[Command]Test
by amureini＠redhat.com 30 Oct '13

30 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Unify RemoveStorageDomain[Command]Test ...................................................................... core: Unify RemoveStorageDomain[Command]Test RemoveStorageDomainTest and RemoveStorageDomainCommandTest both test the same command. Neither sets up any special environment, and in fact, they have multiple duplications. This patch streamlines the testing of RemoveStorageDomainCommand to a single test case (RemoveStorageDomainCommandTest, as per JUnit convention). It includes: 1. Removing duplicate tests. 2. Bundling all the tests for executeAction() in a single method. 3. Cleaning up the mocking scheme (minor refactoring to the command itself was required in order to achieve this). Change-Id: Id85d95109b48f9191e972218f9a1a220db5aeeeb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainTest.java 5 files changed, 133 insertions(+), 316 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20684 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id85d95109b48f9191e972218f9a1a220db5aeeeb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: RemoveStorageDomainCommandTest: CDATestUtils
by amureini＠redhat.com 30 Oct '13

30 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveStorageDomainCommandTest: CDATestUtils ...................................................................... core: RemoveStorageDomainCommandTest: CDATestUtils Use CanDoActionTestUtils instead of CommandAssertUtils in order to streamline the code. This patch is part of a series of patches designed to clearly separate between CanDoActionTestUtils and CommandAssertUtils. Change-Id: Ibf1f0b05f1ed2320131071f928372e259584b040 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CanDoActionTestUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java 2 files changed, 83 insertions(+), 15 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20683 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf1f0b05f1ed2320131071f928372e259584b040 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add missing mock of config value in GlusterHookSyncJob...
by amureini＠redhat.com 30 Oct '13

30 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: add missing mock of config value in GlusterHookSyncJobTest ...................................................................... core: add missing mock of config value in GlusterHookSyncJobTest Change-Id: I058db989c6ef0bee6a6dcc6fb37b9af30e24bbd5 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJobTest.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I058db989c6ef0bee6a6dcc6fb37b9af30e24bbd5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zelkha(a)gmail.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0