- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3.1]: packaging: ovirt-engine-3.3.1
by iheim＠redhat.com 30 Oct '13

30 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: ovirt-engine-3.3.1 ...................................................................... packaging: ovirt-engine-3.3.1 Updated version to 3.3.1-1 Change-Id: I8150af7dbdef4bda92cb4532f05e5595de86d70f Bug-Url: https://bugzilla.redhat.com/1019391 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in M version.mak 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8150af7dbdef4bda92cb4532f05e5595de86d70f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: fix vm link for template's watchdog
by gchaplik＠redhat.com 30 Oct '13

30 Oct '13

Gilad Chaplik has submitted this change and it was merged. Change subject: restapi: fix vm link for template's watchdog ...................................................................... restapi: fix vm link for template's watchdog Change-Id: Ie84c9809a8cbb0fddf0daf39f22be97a8eadb938 Bug-Url: https://bugzilla.redhat.com/1019211 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateWatchdogsResource.java 2 files changed, 25 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie84c9809a8cbb0fddf0daf39f22be97a8eadb938 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: NPE in setJobLink flow
by gchaplik＠redhat.com 30 Oct '13

30 Oct '13

Gilad Chaplik has submitted this change and it was merged. Change subject: restapi: NPE in setJobLink flow ...................................................................... restapi: NPE in setJobLink flow Action should be initialized prior to setting a job id. Change-Id: Iadfd502de54cd34d9cc5e4dc70d4bd6f52f83cf7 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20629 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadfd502de54cd34d9cc5e4dc70d4bd6f52f83cf7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: fix typo in ManageDomainsResult
by amureini＠redhat.com 30 Oct '13

30 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: fix typo in ManageDomainsResult ...................................................................... engine: fix typo in ManageDomainsResult Change-Id: I4d9d92d34f6267d359e22adf90e940f1034a2f3e Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsResult.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20601 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d9d92d34f6267d359e22adf90e940f1034a2f3e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Don't display DCs that imported external network
by iheim＠redhat.com 30 Oct '13

30 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Don't display DCs that imported external network ...................................................................... webadmin: Don't display DCs that imported external network Changed the import networks dialog so that the choice of DC to import an external network to, will only include DCs where the network doesn't exist yet. This required modification of the backend query to not only retrieve all the external networks that exist on a provider, but also map each network to the set of DCs where that network had already been imported. This set is then used to efficiently check whether a certain external network had been imported to a certain DC. Change-Id: Ifd76b527500957ec47db6d60894b0d7316d17058 Bug-Url: https://bugzilla.redhat.com/989909 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/GetAllExternalNetworksOnProviderQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/provider/network/GetAllExternalNetworksOnProviderQueryTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java M packaging/dbscripts/storages_sp.sql 11 files changed, 135 insertions(+), 18 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd76b527500957ec47db6d60894b0d7316d17058 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Remove vNIC items changed listener before flush
by iheim＠redhat.com 30 Oct '13

30 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Remove vNIC items changed listener before flush ...................................................................... webadmin: Remove vNIC items changed listener before flush Upon flushing the AddRemoveRowWidget, it sets the backing ListModel's items according to the entries in the widget. However, in the add/edit VM dialog, since it is listening on the items changed event, this re-initializes the widget just before it closes, thus adding a new vNIC row. This patch moves the listening logic into ProfilesInstanceTypeEditor and removes the listener prior to flushing the widget, in order to avoid that flicker. Change-Id: I5f153a3b19e467d41131015c7e2819c3ce365c22 Bug-Url: https://bugzilla.redhat.com/1020755 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java 2 files changed, 38 insertions(+), 17 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20658 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f153a3b19e467d41131015c7e2819c3ce365c22 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Allow different options for different entries
by iheim＠redhat.com 30 Oct '13

30 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Allow different options for different entries ...................................................................... webadmin: Allow different options for different entries ListModelListBoxCell used to have one set of options for all of the entries. Now it only sets the options in the last minute, when a specific entry is rendered, according to the items in the ListModel backing the specific entry, which enables to have different options for different entries. Change-Id: I703ab631ef959fa3ca3ad5bb6dd878634993a3b2 Bug-Url: https://bugzilla.redhat.com/989909 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/ListModelListBoxCell.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/ListModelListBoxColumn.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.java 4 files changed, 8 insertions(+), 44 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I703ab631ef959fa3ca3ad5bb6dd878634993a3b2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: build: use own temp directory and preferences for gwt
by iheim＠redhat.com 30 Oct '13

30 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: build: use own temp directory and preferences for gwt ...................................................................... build: use own temp directory and preferences for gwt during build, gwt generates a lots of files into temp directory which not always cleaned up. best to generate these at own project directory so once project is cleaned up these will also be cleaned up. to avoid conflicts with other running instances, set java preferences location to be in temp directory as well. Change-Id: If2551534ccf0c181fdd755c64e11328ad24b47b2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M frontend/webadmin/modules/pom.xml 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20665 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2551534ccf0c181fdd755c64e11328ad24b47b2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Don't log unsynchronized unmanaged networks
by iheim＠redhat.com 30 Oct '13

30 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Don't log unsynchronized unmanaged networks ...................................................................... engine: Don't log unsynchronized unmanaged networks If the network is not synchronized, it should be logged only if it's managed. Otherwise, it's of no interest to us. Change-Id: I7b8a582134f5c9d37d64bcd5970f2f3bfb24ab20 Bug-Url: https://bugzilla.redhat.com/1023705 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b8a582134f5c9d37d64bcd5970f2f3bfb24ab20 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3.1]: core: empty quota causes FK violation
by iheim＠redhat.com 30 Oct '13

30 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: empty quota causes FK violation ...................................................................... core: empty quota causes FK violation When creating a disk in Foreman, the disk object is sent via REST with empty string in id attribute: <quota id=""/> REST creates an empty UUID (000...) out of empty string, and causes FK violation, since there is no quota with that id. This patch fixes it by ignoring empty quota for adding disk. Change-Id: Ic488486edc7c5602d24e804c9a89aeccc98fc32b Bug-Url: https://bugzilla.redhat.com/1022942 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Itamar Heim: Verified; Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/20702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic488486edc7c5602d24e804c9a89aeccc98fc32b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.1 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0