- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Rendered checkbox headers resizeable
by lvernia＠redhat.com 30 Oct '13

30 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Rendered checkbox headers resizeable ...................................................................... webadmin: Rendered checkbox headers resizeable Previously, CheckboxHeader wasn't resizeable. Created a class ResizeableCheckboxHeader to fix this, a wrapper for CheckboxHeader that inherits from ResizableHeader (classic case for multiple inheritance, but used composition due to Java limitations). A CheckboxHeader is automatically wrapped with a ResizeableCheckboxHeader when it is added to a ColumnResizeCellTable that has column resizing enabled, as in such a case it would be expected that the checkbox headers are resizeable as well. Change-Id: Ie442350893282e7838e5216d277718e654f1d884 Bug-Url: https://bugzilla.redhat.com/1009745 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/SafeHtmlCellWithTooltip.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/CheckboxHeader.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/ResizeableCheckboxHeader.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ResizableHeader.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.java 8 files changed, 67 insertions(+), 13 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie442350893282e7838e5216d277718e654f1d884 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: empty quota causes FK violation
by iheim＠redhat.com 30 Oct '13

30 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: empty quota causes FK violation ...................................................................... core: empty quota causes FK violation When creating a disk in Foreman, the disk object is sent via REST with empty string in id attribute: <quota id=""/> REST creates an empty UUID (000...) out of empty string, and causes FK violation, since there is no quota with that id. This patch fixes it by ignoring empty quota for adding disk. Change-Id: Ic488486edc7c5602d24e804c9a89aeccc98fc32b Bug-Url: https://bugzilla.redhat.com/1022942 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20499 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic488486edc7c5602d24e804c9a89aeccc98fc32b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk-java[sdk_3.3]: sdk: release 1.0.0.19-1
by mpastern＠redhat.com 30 Oct '13

30 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: release 1.0.0.19-1 ...................................................................... sdk: release 1.0.0.19-1 Change-Id: I39a5dd4ac945649badcec311a4f8630856fd5401 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/Makefile M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in M ovirt-engine-sdk-java/pom.xml 3 files changed, 12 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20693 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39a5dd4ac945649badcec311a4f8630856fd5401 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_3.3 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[sdk_3.3]: sdk: regenerate against the latest api
by mpastern＠redhat.com 30 Oct '13

30 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: regenerate against the latest api ...................................................................... sdk: regenerate against the latest api - to host.install() added ssh related arguments - to template added virtio_scsi.enabled - to vm added virtio_scsi.enabled - added ability to attach a disk snapshot to the virtual machine - to File class added 'content' field - Payload class now reuses Files instead of own PayloadFile collection Change-Id: If0ea500890f41d3bf58508a720cb183b7a6eb890 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Host.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Template.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Templates.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VM.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDisks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMs.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Disk.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/File.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/ObjectFactory.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Payload.java D ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/PayloadFile.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Template.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/VM.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/VirtIOSCSI.java 14 files changed, 313 insertions(+), 186 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20692 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0ea500890f41d3bf58508a720cb183b7a6eb890 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_3.3 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: regenerate against the latest api
by mpastern＠redhat.com 30 Oct '13

30 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: regenerate against the latest api ...................................................................... sdk: regenerate against the latest api - to host.install() added ssh related arguments - to template added virtio_scsi.enabled - to vm added virtio_scsi.enabled - added ability to attach a disk snapshot to the virtual machine - to File class added 'content' field - Payload class now reuses Files instead of own PayloadFile collection Change-Id: If0ea500890f41d3bf58508a720cb183b7a6eb890 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Host.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Template.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Templates.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VM.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDisks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMs.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Disk.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/File.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/ObjectFactory.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Payload.java D ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/PayloadFile.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Template.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/VM.java A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/VirtIOSCSI.java 14 files changed, 313 insertions(+), 186 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0ea500890f41d3bf58508a720cb183b7a6eb890 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: regenerate against the latest api
by mpastern＠redhat.com 30 Oct '13

30 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: regenerate against the latest api ...................................................................... sdk: regenerate against the latest api - to host.install() added ssh related details - to template added virtio_scsi.enabled - to vm added virtio_scsi.enabled - added ability to attach a disk snapshot to the virtual machine - to File class added 'content' field - Payload class now reuses Files instead of own List<PayloadFile> collection Change-Id: Id1705ba21e3ae4b36a3689e566f33bb664a02e02 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/xml/params.py 2 files changed, 199 insertions(+), 131 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1705ba21e3ae4b36a3689e566f33bb664a02e02 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: moved engine-backup into -tools
by sbonazzo＠redhat.com 30 Oct '13

30 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: moved engine-backup into -tools ...................................................................... packaging: moved engine-backup into -tools Moved engine-backup from -setup to -tools subpackage. Note that engine-backup already needed -tools for using engine-prolog.sh and we don't want -setup to depend on -tools. Change-Id: I09d70101ca88b19a9c593017bcd3a3eda243d7a3 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20690 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09d70101ca88b19a9c593017bcd3a3eda243d7a3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine : Moved SizeConverter to backend utils
by tnisan＠redhat.com 30 Oct '13

30 Oct '13

Tal Nisan has submitted this change and it was merged. Change subject: engine : Moved SizeConverter to backend utils ...................................................................... engine : Moved SizeConverter to backend utils SizeConverter is a generic converter which can take the size in a given i/p unit and convert to a unit of users choice.It is also capable of rendering size as a string along with respective units.Moved Size-converter to backend utils.Moving this is required so that it can be used by both frontend and backend packages. Change-Id: I650436e48cdc0fc1c73f86d3424c9f5153e453d0 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SizeConverter.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/DiskSizeLabel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/StorageSizeLabel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/DiskSizeRenderer.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskSizeColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StorageSizeColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateDiskListModelTable.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/QuotaMemoryProgressBar.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/QuotaStorageProgressBar.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabQuotaView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageIsoView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/RebalanceFileSizeRenderer.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/storage/TemplatesTree.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/storage/VMsTree.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/template/DisksTree.java 23 files changed, 28 insertions(+), 24 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20506 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I650436e48cdc0fc1c73f86d3424c9f5153e453d0 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Bad request error doesn't returns enough...
by ofrenkel＠redhat.com 30 Oct '13

30 Oct '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: Bad request error doesn't returns enough... ...................................................................... core: Bad request error doesn't returns enough... Bad request error doesn't returns enough details (cannot understand from the error what was bad/missing in request) Removing the notNull annotation from the managementIp field since although that this is true for new PM definitions, it is not mandatory for updates and should be define exactly as the secondary management IP field. Change-Id: I163166bb6d58c475c7e3361821e928bc3f7b3a47 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1013301 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19676 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I163166bb6d58c475c7e3361821e928bc3f7b3a47 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin : units of time (sec/ min) in runtime column
by kmayilsa＠redhat.com 30 Oct '13

30 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : units of time (sec/ min) in runtime column ...................................................................... webadmin : units of time (sec/ min) in runtime column Units of time (sec/ min) in runtime column in remove brick status and rebalance status dialog. Change-Id: I1b72bb58fb4fd0181c912c97842e10faf50d6296 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1019599 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/HumanReadableTimeRenderer.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HumanReadableTimeColumn.java 3 files changed, 54 insertions(+), 3 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20249 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b72bb58fb4fd0181c912c97842e10faf50d6296 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0