- Engine-commits - oVirt List Archives

Change in ovirt-live[master]: ovirt-live fix makefile iso path
by obasan＠redhat.com 27 Oct '13

27 Oct '13

Ohad Basan has submitted this change and it was merged. Change subject: ovirt-live fix makefile iso path ...................................................................... ovirt-live fix makefile iso path the oVirtLiveFiles is the liveuser's home directory therefore the iso has to be placed in there in order to be available in the live environment for usage Change-Id: I915d26aaeac14145f316ff9fa5cb1b71e7811327 Signed-off-by: Ohad Basan <obasan(a)redhat.com> --- D .gitignore M centos/.gitignore M centos/Makefile 3 files changed, 4 insertions(+), 3 deletions(-) Approvals: Ohad Basan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20500 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I915d26aaeac14145f316ff9fa5cb1b71e7811327 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: host-deploy: output stderr content as error in audit log
by amureini＠redhat.com 27 Oct '13

27 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: host-deploy: output stderr content as error in audit log ...................................................................... host-deploy: output stderr content as error in audit log Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1021222 Change-Id: If1cc9bf7e9e9875965fa4830c68e2a63d801b96b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHDialog.java 2 files changed, 16 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1cc9bf7e9e9875965fa4830c68e2a63d801b96b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: os repository - remove "linux" and "windows"
by iheim＠redhat.com 27 Oct '13

27 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: os repository - remove "linux" and "windows" ...................................................................... core: os repository - remove "linux" and "windows" "linux" and "windows" introduced to be the base oss but dosn't really have a use as real OSs. * remove linux and windows os from osinfo * refactor each os which rely on linux and windows to rely on other_linux and windows_xp respectivly * upgrade db records in vm_static. * this change will break import/export but since this change introduced in 3.3 and is removed in 3.3 I'm not suppling handling in the code for that. to fix the import its enough to add to $PREFIX/etc/ovirt-engine/osinfo.conf.d/20-import-export-linux-windows-fix.properties 20-import-export-linux-windows-fix.properties backwardCompatibility.linux = 5 backwardCompatibility.windows = 1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1009013 Change-Id: I9c32efc276fa32af39b35ce081a7bd2003afc129 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties A packaging/dbscripts/upgrade/03_03_0970_move_rename_of_other_linux_type.sql 2 files changed, 22 insertions(+), 26 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c32efc276fa32af39b35ce081a7bd2003afc129 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: removing comment
by amureini＠redhat.com 27 Oct '13

27 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: removing comment ...................................................................... core: removing comment Change-Id: I1c9ecf44c7e1d1ad99a3cdf222399a079304d168 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommandTest.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c9ecf44c7e1d1ad99a3cdf222399a079304d168 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix findbugs boolean comprasion warning
by amureini＠redhat.com 27 Oct '13

27 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: fix findbugs boolean comprasion warning ...................................................................... core: fix findbugs boolean comprasion warning Change-Id: I68e6b0453d8e599e3516de8832096c4b37300fda Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68e6b0453d8e599e3516de8832096c4b37300fda Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: ReconstructMasterParameters - return removed initializ...
by amureini＠redhat.com 27 Oct '13

27 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: ReconstructMasterParameters - return removed initialization ...................................................................... core: ReconstructMasterParameters - return removed initialization In change I3bb06f63b6fae8d4bc0c2b931cbfeb6b71a023a9, the initialization of the member privateNewMasterDomainId has been moved to the ctor. The issue is that the initialization was placed only in some of the ctors leading the unexpected behaviour when reconstruct is executed. Change-Id: I752c8065ee15faaeb6ffd41909d349297b8a3a58 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReconstructMasterParameters.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I752c8065ee15faaeb6ffd41909d349297b8a3a58 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: expose ACTION_TYPE_FAILED_DISK_IS_NOT_VM_DISK code...
by mlipchuk＠redhat.com 27 Oct '13

27 Oct '13

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin: expose ACTION_TYPE_FAILED_DISK_IS_NOT_VM_DISK code in UI ...................................................................... webadmin: expose ACTION_TYPE_FAILED_DISK_IS_NOT_VM_DISK code in UI Change-Id: I9dd47380594b27db7347e28fce27abcf11cf63ac Bug-Url: https://bugzilla.redhat.com/1021420 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommand.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Sergey Gotliv: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9dd47380594b27db7347e28fce27abcf11cf63ac Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Don't log unsynchronized unmanaged networks
by mkolesni＠redhat.com 27 Oct '13

27 Oct '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Don't log unsynchronized unmanaged networks ...................................................................... engine: Don't log unsynchronized unmanaged networks If the network is not synchronized, it should be logged only if it's managed. Otherwise, it's of no interest to us. Change-Id: I7b8a582134f5c9d37d64bcd5970f2f3bfb24ab20 Bug-Url: https://bugzilla.redhat.com/906393 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b8a582134f5c9d37d64bcd5970f2f3bfb24ab20 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Remove advanced parameters from vNIC dialog
by lvernia＠redhat.com 27 Oct '13

27 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Remove advanced parameters from vNIC dialog ...................................................................... webadmin: Remove advanced parameters from vNIC dialog Since the port mirroring checkbox moved to the vNIC profile dialog, the advanced parameters section in the vNIC dialog only includes plug/unplug at the moment, rendering it quite unnecessary. Also rearranged some of the widget declarations so hitting tab will move between them in a more logical order. Change-Id: Idc9e865f9f8c2fe371d3a33703ea1a8172fea8aa Bug-Url: https://bugzilla.redhat.com/1011999 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.ui.xml 2 files changed, 40 insertions(+), 54 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc9e865f9f8c2fe371d3a33703ea1a8172fea8aa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Added scrolling to vNIC section in add VM
by lvernia＠redhat.com 27 Oct '13

27 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Added scrolling to vNIC section in add VM ...................................................................... webadmin: Added scrolling to vNIC section in add VM Added a vertical scroll bar to the vNIC section in the add VM dialog. Change-Id: I0d1c45470c23fdb561bfb5573e133591c138c276 Bug-Url: https://bugzilla.redhat.com/1012798 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20342 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d1c45470c23fdb561bfb5573e133591c138c276 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0